Message ID | 20180611174243.31070-1-ehabkost@redhat.com |
---|---|
State | New |
Headers | show |
Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: 20180611174243.31070-1-ehabkost@redhat.com Subject: [Qemu-devel] [PULL 00/13] Python queue, 2018-06-11 === TEST SCRIPT BEGIN === #!/bin/bash BASE=base n=1 total=$(git log --oneline $BASE.. | wc -l) failed=0 git config --local diff.renamelimit 0 git config --local diff.renames True git config --local diff.algorithm histogram commits="$(git log --format=%H --reverse $BASE..)" for c in $commits; do echo "Checking PATCH $n/$total: $(git log -n 1 --format=%s $c)..." if ! git show $c --format=email | ./scripts/checkpatch.pl --mailback -; then failed=1 echo fi n=$((n+1)) done exit $failed === TEST SCRIPT END === Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384 Switched to a new branch 'test' 9befc781a3 python: Remove scripts/ordereddict.py 5c22101565 python: Remove scripts/argparse.py 1c07589cb9 configure: Require Python 2.7 or newer 47a73d5f8a python: futurize -f lib2to3.fixes.fix_numliterals e0512db6fe python: futurize -f lib2to3.fixes.fix_except ff4f6bf56d python: futurize -f lib2to3.fixes.fix_renames 029e4039c4 python: futurize -f lib2to3.fixes.fix_tuple_params d560c7b24d python: futurize -f lib2to3.fixes.fix_reduce ff1b0480fe python: futurize -f lib2to3.fixes.fix_standarderror 89e08e39a0 python: futurize -f lib2to3.fixes.fix_has_key 77e2e30a73 python: futurize -f libfuturize.fixes.fix_next_call 8cf63c3b07 python: futurize -f libfuturize.fixes.fix_absolute_import e631df3427 python: futurize -f libfuturize.fixes.fix_print_with_import === OUTPUT BEGIN === Checking PATCH 1/13: python: futurize -f libfuturize.fixes.fix_print_with_import... ERROR: line over 90 characters #45: FILE: scripts/analyse-9p-simpletrace.py:86: + print("RERROR (tag =", tag, ", id =", symbol_9p[id], ", err = \"", os.strerror(err), "\")") ERROR: line over 90 characters #49: FILE: scripts/analyse-9p-simpletrace.py:89: + print("TVERSION (tag =", tag, ", msize =", msize, ", version =", version, ")") ERROR: line over 90 characters #53: FILE: scripts/analyse-9p-simpletrace.py:92: + print("RVERSION (tag =", tag, ", msize =", msize, ", version =", version, ")") ERROR: line over 90 characters #57: FILE: scripts/analyse-9p-simpletrace.py:95: + print("TATTACH (tag =", tag, ", fid =", fid, ", afid =", afid, ", uname =", uname, ", aname =", aname, ")") ERROR: line over 90 characters #61: FILE: scripts/analyse-9p-simpletrace.py:98: + print("RATTACH (tag =", tag, ", qid={type =", type, ", version =", version, ", path =", path, "})") ERROR: line over 90 characters #69: FILE: scripts/analyse-9p-simpletrace.py:104: + print("RSTAT (tag =", tag, ", mode =", mode, ", atime =", atime, ", mtime =", mtime, ", length =", length, ")") ERROR: line over 90 characters #73: FILE: scripts/analyse-9p-simpletrace.py:107: + print("TGETATTR (tag =", tag, ", fid =", fid, ", request_mask =", hex(request_mask), ")") ERROR: line over 90 characters #77: FILE: scripts/analyse-9p-simpletrace.py:110: + print("RGETATTR (tag =", tag, ", result_mask =", hex(result_mask), ", mode =", oct(mode), ", uid =", uid, ", gid =", gid, ")") ERROR: line over 90 characters #81: FILE: scripts/analyse-9p-simpletrace.py:113: + print("TWALK (tag =", tag, ", fid =", fid, ", newfid =", newfid, ", nwnames =", nwnames, ")") ERROR: line over 90 characters #85: FILE: scripts/analyse-9p-simpletrace.py:116: + print("RWALK (tag =", tag, ", nwnames =", nwnames, ", qids =", hex(qids), ")") WARNING: line over 80 characters #89: FILE: scripts/analyse-9p-simpletrace.py:119: + print("TOPEN (tag =", tag, ", fid =", fid, ", mode =", oct(mode), ")") ERROR: line over 90 characters #93: FILE: scripts/analyse-9p-simpletrace.py:122: + print("ROPEN (tag =", tag, ", qid={type =", type, ", version =", version, ", path =", path, "}, iounit =", iounit, ")") ERROR: line over 90 characters #97: FILE: scripts/analyse-9p-simpletrace.py:125: + print("TLCREATE (tag =", tag, ", dfid =", dfid, ", flags =", oct(flags), ", mode =", oct(mode), ", gid =", gid, ")") ERROR: line over 90 characters #101: FILE: scripts/analyse-9p-simpletrace.py:128: + print("RLCREATE (tag =", tag, ", qid={type =", type, ", version =", version, ", path =", path, "}, iounit =", iounit, ")") WARNING: line over 80 characters #105: FILE: scripts/analyse-9p-simpletrace.py:131: + print("TFSYNC (tag =", tag, ", fid =", fid, ", datasync =", datasync, ")") ERROR: line over 90 characters #113: FILE: scripts/analyse-9p-simpletrace.py:137: + print("TREAD (tag =", tag, ", fid =", fid, ", off =", off, ", max_count =", max_count, ")") WARNING: line over 80 characters #117: FILE: scripts/analyse-9p-simpletrace.py:140: + print("RREAD (tag =", tag, ", count =", count, ", err =", err, ")") ERROR: line over 90 characters #121: FILE: scripts/analyse-9p-simpletrace.py:143: + print("TREADDIR (tag =", tag, ", fid =", fid, ", offset =", offset, ", max_count =", max_count, ")") ERROR: line over 90 characters #125: FILE: scripts/analyse-9p-simpletrace.py:146: + print("RREADDIR (tag =", tag, ", count =", count, ", retval =", retval, ")") ERROR: line over 90 characters #129: FILE: scripts/analyse-9p-simpletrace.py:149: + print("TWRITE (tag =", tag, ", fid =", fid, ", off =", off, ", count =", count, ", cnt =", cnt, ")") WARNING: line over 80 characters #133: FILE: scripts/analyse-9p-simpletrace.py:152: + print("RWRITE (tag =", tag, ", total =", total, ", err =", err, ")") ERROR: line over 90 characters #137: FILE: scripts/analyse-9p-simpletrace.py:155: + print("TCREATE (tag =", tag, ", fid =", fid, ", perm =", oct(perm), ", name =", name, ", mode =", oct(mode), ")") ERROR: line over 90 characters #141: FILE: scripts/analyse-9p-simpletrace.py:158: + print("RCREATE (tag =", tag, ", qid={type =", type, ", version =", version, ", path =", path, "}, iounit =", iounit, ")") ERROR: line over 90 characters #145: FILE: scripts/analyse-9p-simpletrace.py:161: + print("TSYMLINK (tag =", tag, ", fid =", fid, ", name =", name, ", symname =", symname, ", gid =", gid, ")") ERROR: line over 90 characters #149: FILE: scripts/analyse-9p-simpletrace.py:164: + print("RSYMLINK (tag =", tag, ", qid={type =", type, ", version =", version, ", path =", path, "})") ERROR: line over 90 characters #157: FILE: scripts/analyse-9p-simpletrace.py:170: + print("TLINK (tag =", tag, ", dfid =", dfid, ", oldfid =", oldfid, ", name =", name, ")") ERROR: line over 90 characters #165: FILE: scripts/analyse-9p-simpletrace.py:176: + print("TWSTAT (tag =", tag, ", fid =", fid, ", mode =", oct(mode), ", atime =", atime, "mtime =", mtime, ")") ERROR: line over 90 characters #169: FILE: scripts/analyse-9p-simpletrace.py:179: + print("TMKNOD (tag =", tag, ", fid =", fid, ", mode =", oct(mode), ", major =", major, ", minor =", minor, ")") ERROR: line over 90 characters #173: FILE: scripts/analyse-9p-simpletrace.py:182: + print("TLOCK (tag =", tag, ", fid =", fid, "type =", type, ", start =", start, ", length =", length, ")") ERROR: line over 90 characters #181: FILE: scripts/analyse-9p-simpletrace.py:188: + print("TGETLOCK (tag =", tag, ", fid =", fid, "type =", type, ", start =", start, ", length =", length, ")") ERROR: line over 90 characters #185: FILE: scripts/analyse-9p-simpletrace.py:191: + print("RGETLOCK (tag =", tag, "type =", type, ", start =", start, ", length =", length, ", proc_id =", proc_id, ")") ERROR: line over 90 characters #189: FILE: scripts/analyse-9p-simpletrace.py:194: + print("TMKDIR (tag =", tag, ", fid =", fid, ", name =", name, ", mode =", mode, ", gid =", gid, ")") ERROR: line over 90 characters #193: FILE: scripts/analyse-9p-simpletrace.py:197: + print("RMKDIR (tag =", tag, ", qid={type =", type, ", version =", version, ", path =", path, "}, err =", err, ")") ERROR: line over 90 characters #197: FILE: scripts/analyse-9p-simpletrace.py:200: + print("TXATTRWALK (tag =", tag, ", fid =", fid, ", newfid =", newfid, ", xattr name =", name, ")") ERROR: line over 90 characters #205: FILE: scripts/analyse-9p-simpletrace.py:206: + print("TXATTRCREATE (tag =", tag, ", fid =", fid, ", name =", name, ", xattrsize =", size, ", flags =", flags, ")") WARNING: line over 80 characters #848: FILE: scripts/vmstate-static-checker.py:182: + print("expected field \"" + s_item["field"] + "\",", end=' ') WARNING: line over 80 characters #904: FILE: scripts/vmstate-static-checker.py:293: + print("Section \"" + sec + "\", Description \"" + desc + "\":", end=' ') WARNING: line over 80 characters #1012: FILE: scripts/vmstate-static-checker.py:419: + print("Section \"" + sec + "\": Entry \"" + entry + "\"", end=' ') WARNING: line over 80 characters #1147: FILE: tests/image-fuzzer/runner.py:41: + "'--config' and '--command' options are not supported.", file=sys.stderr) WARNING: line over 80 characters #1158: FILE: tests/image-fuzzer/runner.py:161: + print("Error: The working directory '%s' cannot be used. Reason: %s"\ ERROR: line over 90 characters #1187: FILE: tests/image-fuzzer/runner.py:359: + print("Error: %s\n\nTry 'runner.py --help' for more information" % e, file=sys.stderr) WARNING: line over 80 characters #1249: FILE: tests/migration/guestperf/engine.py:121: + print("Sleeping %d seconds for initial guest workload run" % self._sleep) ERROR: line over 90 characters #1267: FILE: tests/migration/guestperf/engine.py:220: + print("Sleeping %d seconds for final guest workload run" % self._sleep) WARNING: line over 80 characters #1276: FILE: tests/migration/guestperf/engine.py:231: + print("Iter %d: remain %5dMB of %5dMB (total %5dMB @ %5dMb/sec)" % ( ERROR: line over 90 characters #1288: FILE: tests/migration/guestperf/engine.py:241: + print("No completion after %d iterations over RAM" % scenario._max_iters) ERROR: line over 90 characters #1304: FILE: tests/migration/guestperf/engine.py:255: + print("Switching to post-copy after %d iterations" % scenario._post_copy_iters) WARNING: line over 80 characters #1313: FILE: tests/migration/guestperf/engine.py:263: + print("Pausing VM after %d iterations" % scenario._pause_iters) ERROR: line over 90 characters #1671: FILE: tests/qemu-iotests/qcow2.py:226: + print("'%s' is not a valid group, try 'incompatible', 'compatible', or 'autoclear'" % group) total: 36 errors, 12 warnings, 1495 lines checked Your patch has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. Checking PATCH 2/13: python: futurize -f libfuturize.fixes.fix_absolute_import... Checking PATCH 3/13: python: futurize -f libfuturize.fixes.fix_next_call... Checking PATCH 4/13: python: futurize -f lib2to3.fixes.fix_has_key... Checking PATCH 5/13: python: futurize -f lib2to3.fixes.fix_standarderror... Checking PATCH 6/13: python: futurize -f lib2to3.fixes.fix_reduce... Checking PATCH 7/13: python: futurize -f lib2to3.fixes.fix_tuple_params... Checking PATCH 8/13: python: futurize -f lib2to3.fixes.fix_renames... Checking PATCH 9/13: python: futurize -f lib2to3.fixes.fix_except... Checking PATCH 10/13: python: futurize -f lib2to3.fixes.fix_numliterals... Checking PATCH 11/13: configure: Require Python 2.7 or newer... Checking PATCH 12/13: python: Remove scripts/argparse.py... WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #15: deleted file mode 100644 total: 0 errors, 1 warnings, 0 lines checked Your patch has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. Checking PATCH 13/13: python: Remove scripts/ordereddict.py... WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #28: deleted file mode 100644 total: 0 errors, 1 warnings, 25 lines checked Your patch has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. === OUTPUT END === Test command exited with code: 1 --- Email generated automatically by Patchew [http://patchew.org/]. Please send your feedback to patchew-devel@redhat.com
On 11 June 2018 at 18:42, Eduardo Habkost <ehabkost@redhat.com> wrote: > The following changes since commit 0d2fa03dae4fbe185a082f361342b1e30aed4582: > > Merge remote-tracking branch 'remotes/pmaydell/tags/pull-target-arm-20180608' into staging (2018-06-08 16:26:51 +0100) > > are available in the Git repository at: > > git://github.com/ehabkost/qemu.git tags/python-next-pull-request > > for you to fetch changes up to c7883412440905b41dde7e70f4af782932e80e90: > > python: Remove scripts/ordereddict.py (2018-06-08 16:40:54 -0300) > > ---------------------------------------------------------------- > Python queue, 2018-06-11 > > * Make code compatible with Python 3 using 'futurize --stage1' > * Require Python >= 2.7 and remove Python 2.6 compatibility > modules > > ---------------------------------------------------------------- Applied, thanks. -- PMM
On 11 June 2018 at 18:42, Eduardo Habkost <ehabkost@redhat.com> wrote: > The following changes since commit 0d2fa03dae4fbe185a082f361342b1e30aed4582: > > Merge remote-tracking branch 'remotes/pmaydell/tags/pull-target-arm-20180608' into staging (2018-06-08 16:26:51 +0100) > > are available in the Git repository at: > > git://github.com/ehabkost/qemu.git tags/python-next-pull-request > > for you to fetch changes up to c7883412440905b41dde7e70f4af782932e80e90: > > python: Remove scripts/ordereddict.py (2018-06-08 16:40:54 -0300) > > ---------------------------------------------------------------- > Python queue, 2018-06-11 > > * Make code compatible with Python 3 using 'futurize --stage1' > * Require Python >= 2.7 and remove Python 2.6 compatibility > modules > > ---------------------------------------------------------------- Hi; I noticed that running configure on my machine can now produce a python traceback from docker.py: make: Entering directory '/home/petmay01/linaro/qemu-for-merges/build/alldbg' config-host.mak is out-of-date, running configure Traceback (most recent call last): File "/home/petmay01/linaro/qemu-for-merges/tests/docker/docker.py", line 29, in <module> from StringIO import StringIO ImportError: No module named 'StringIO' Install prefix /usr/local [etc] I don't know if this is because of this change, but this is the most recent change involving python... The error also doesn't cause configure to fail, which is probably a separate bug. thanks -- PMM
On Tue, Jun 19, 2018 at 12:13:41PM +0100, Peter Maydell wrote: > On 11 June 2018 at 18:42, Eduardo Habkost <ehabkost@redhat.com> wrote: > > The following changes since commit 0d2fa03dae4fbe185a082f361342b1e30aed4582: > > > > Merge remote-tracking branch 'remotes/pmaydell/tags/pull-target-arm-20180608' into staging (2018-06-08 16:26:51 +0100) > > > > are available in the Git repository at: > > > > git://github.com/ehabkost/qemu.git tags/python-next-pull-request > > > > for you to fetch changes up to c7883412440905b41dde7e70f4af782932e80e90: > > > > python: Remove scripts/ordereddict.py (2018-06-08 16:40:54 -0300) > > > > ---------------------------------------------------------------- > > Python queue, 2018-06-11 > > > > * Make code compatible with Python 3 using 'futurize --stage1' > > * Require Python >= 2.7 and remove Python 2.6 compatibility > > modules > > > > ---------------------------------------------------------------- > > Hi; I noticed that running configure on my machine can now produce a > python traceback from docker.py: > > make: Entering directory '/home/petmay01/linaro/qemu-for-merges/build/alldbg' > config-host.mak is out-of-date, running configure > Traceback (most recent call last): > File "/home/petmay01/linaro/qemu-for-merges/tests/docker/docker.py", > line 29, in <module> > from StringIO import StringIO > ImportError: No module named 'StringIO' > Install prefix /usr/local > [etc] > > I don't know if this is because of this change, but this is the > most recent change involving python... This seems to be introduced by: commit 51a12b51fd3693a16eb73362713a98d467e15af7 Author: Alex Bennée <alex.bennee@linaro.org> Date: Wed Apr 4 14:24:39 2018 +0100 configure: add test for docker availability This tests for a working docker installation without sudo and sets up config-host.mak accordingly. This will be useful from cross compiling things in the future. Signed-off-by: Alex Bennée <alex.bennee@linaro.org> Reviewed-by: Richard Henderson <richard.henderson@linaro.org> tests/docker/docker.py is still python2-only but ./configure is trying to run it using $python (which can be Python 3).
On 19 June 2018 at 13:05, Eduardo Habkost <ehabkost@redhat.com> wrote: > On Tue, Jun 19, 2018 at 12:13:41PM +0100, Peter Maydell wrote: >> Hi; I noticed that running configure on my machine can now produce a >> python traceback from docker.py: >> >> make: Entering directory '/home/petmay01/linaro/qemu-for-merges/build/alldbg' >> config-host.mak is out-of-date, running configure >> Traceback (most recent call last): >> File "/home/petmay01/linaro/qemu-for-merges/tests/docker/docker.py", >> line 29, in <module> >> from StringIO import StringIO >> ImportError: No module named 'StringIO' >> Install prefix /usr/local >> [etc] >> >> I don't know if this is because of this change, but this is the >> most recent change involving python... > > This seems to be introduced by: > > commit 51a12b51fd3693a16eb73362713a98d467e15af7 > Author: Alex Bennée <alex.bennee@linaro.org> > Date: Wed Apr 4 14:24:39 2018 +0100 > > configure: add test for docker availability > > This tests for a working docker installation without sudo and sets up > config-host.mak accordingly. This will be useful from cross compiling > things in the future. > > Signed-off-by: Alex Bennée <alex.bennee@linaro.org> > Reviewed-by: Richard Henderson <richard.henderson@linaro.org> > > tests/docker/docker.py is still python2-only but ./configure is > trying to run it using $python (which can be Python 3). Aha, yes -- I'd forgotten, but this config in my buildtest setup is indeed configuring with --python=python3. thanks -- PMM