From patchwork Mon Apr 25 17:54:05 2011 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sassan Panahinejad X-Patchwork-Id: 92765 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.gnu.org (lists.gnu.org [140.186.70.17]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTPS id E880B1007D1 for ; Tue, 26 Apr 2011 03:54:31 +1000 (EST) Received: from localhost ([::1]:44396 helo=lists2.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QEPzP-00012v-Mf for incoming@patchwork.ozlabs.org; Mon, 25 Apr 2011 13:54:27 -0400 Received: from eggs.gnu.org ([140.186.70.92]:41987) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QEPzI-00012o-5q for qemu-devel@nongnu.org; Mon, 25 Apr 2011 13:54:20 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1QEPzH-0008CJ-8L for qemu-devel@nongnu.org; Mon, 25 Apr 2011 13:54:20 -0400 Received: from mail-wy0-f195.google.com ([74.125.82.195]:56920) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QEPzH-0008C6-49 for qemu-devel@nongnu.org; Mon, 25 Apr 2011 13:54:19 -0400 Received: by wyb32 with SMTP id 32so382753wyb.10 for ; Mon, 25 Apr 2011 10:54:17 -0700 (PDT) Received: by 10.216.134.207 with SMTP id s57mr4089376wei.25.1303754057041; Mon, 25 Apr 2011 10:54:17 -0700 (PDT) Received: from localhost.localdomain (cpc2-aztw23-2-0-cust797.aztw.cable.virginmedia.com [94.171.235.30]) by mx.google.com with ESMTPS id d6sm2653936wer.2.2011.04.25.10.54.15 (version=SSLv3 cipher=OTHER); Mon, 25 Apr 2011 10:54:16 -0700 (PDT) From: Sassan Panahinejad To: qemu-devel@nongnu.org Date: Mon, 25 Apr 2011 18:54:05 +0100 Message-Id: <1303754045-19635-1-git-send-email-sassan@sassan.me.uk> X-Mailer: git-send-email 1.7.0.4 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 2) X-Received-From: 74.125.82.195 Cc: Sassan Panahinejad Subject: [Qemu-devel] [PATCH] Fix bug with virtio-9p fsync X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org v9fs_fsync and possibly others break when asked to operate on a directory. It does not check fid_type to see if it is operating on a directory and therefore accesses the wrong element of the fs union. This error can result in guest applications failing (in my case it was dpkg). This patch fixes the issue, although there may be other, similar bugs in virtio-9p. --- hw/virtio-9p.c | 5 ++++- 1 files changed, 4 insertions(+), 1 deletions(-) diff --git a/hw/virtio-9p.c b/hw/virtio-9p.c index 7e29535..09fb5da 100644 --- a/hw/virtio-9p.c +++ b/hw/virtio-9p.c @@ -1875,7 +1875,10 @@ static void v9fs_fsync(V9fsState *s, V9fsPDU *pdu) v9fs_post_do_fsync(s, pdu, err); return; } - err = v9fs_do_fsync(s, fidp->fs.fd, datasync); + if (fidp->fid_type == P9_FID_DIR) + err = v9fs_do_fsync(s, dirfd(fidp->fs.dir), datasync); + else + err = v9fs_do_fsync(s, fidp->fs.fd, datasync); v9fs_post_do_fsync(s, pdu, err); }