[Ada] Mark extended return of unconstrained type as never inlined

Message ID 20180611092230.GA134945@adacore.com
State New
Headers show
Series
  • [Ada] Mark extended return of unconstrained type as never inlined
Related show

Commit Message

Pierre-Marie de Rodat June 11, 2018, 9:22 a.m.
Calls to subprograms whose body was an extended return of an unconstrained
type were marked as not inlined, while the subprogram itself was marked as
always inlined. This was inconsistent and could lead to crash in GNATprove.
Now such subprograms are marked as not candidates for inlining.

This mostly impacts GNATprove, as it relates to frontend inlining which is
not used anymore in normal compilation.

Tested on x86_64-pc-linux-gnu, committed on trunk

2018-06-11  Yannick Moy  <moy@adacore.com>

gcc/ada/

	* inline.adb (Build_Body_To_Inline): Consider case of extended return
	of unconstrained type as one case where inlining is not supported.
	(Expand_Inlined_Call): Remove special case for body as extended return
	of unconstrained type.

Patch

--- gcc/ada/inline.adb
+++ gcc/ada/inline.adb
@@ -879,6 +879,10 @@  package body Inline is
       Body_To_Analyze : Node_Id;
       Max_Size        : constant := 10;
 
+      function Has_Extended_Return return Boolean;
+      --  This function returns True if the subprogram has an extended return
+      --  statement.
+
       function Has_Pending_Instantiation return Boolean;
       --  If some enclosing body contains instantiations that appear before
       --  the corresponding generic body, the enclosing body has a freeze node
@@ -899,6 +903,49 @@  package body Inline is
       --  unconstrained type, the secondary stack is involved, and it
       --  is not worth inlining.
 
+      -------------------------
+      -- Has_Extended_Return --
+      -------------------------
+
+      function Has_Extended_Return return Boolean is
+         Body_To_Inline : constant Node_Id := N;
+
+         function Check_Return (N : Node_Id) return Traverse_Result;
+         --  Returns OK on node N if this is not an extended return statement
+
+         ------------------
+         -- Check_Return --
+         ------------------
+
+         function Check_Return (N : Node_Id) return Traverse_Result is
+         begin
+            case Nkind (N) is
+               when N_Extended_Return_Statement =>
+                  return Abandon;
+
+               --  Skip locally declared subprogram bodies inside the body to
+               --  inline, as the return statements inside those do not count.
+
+               when N_Subprogram_Body =>
+                  if N = Body_To_Inline then
+                     return OK;
+                  else
+                     return Skip;
+                  end if;
+
+               when others =>
+                  return OK;
+            end case;
+         end Check_Return;
+
+         function Check_All_Returns is new Traverse_Func (Check_Return);
+
+      --  Start of processing for Has_Extended_Return
+
+      begin
+         return Check_All_Returns (N) /= OK;
+      end Has_Extended_Return;
+
       -------------------------------
       -- Has_Pending_Instantiation --
       -------------------------------
@@ -1048,7 +1095,16 @@  package body Inline is
         and then not Is_Access_Type (Etype (Spec_Id))
         and then not Is_Constrained (Etype (Spec_Id))
       then
-         if not Has_Single_Return (N) then
+         if not Has_Single_Return (N)
+
+           --  Skip inlining if the function returns an unconstrained type
+           --  using an extended return statement since this part of the
+           --  new inlining model which is not yet supported by the current
+           --  implementation. ???
+
+           or else (Returns_Unconstrained_Type (Spec_Id)
+                     and then Has_Extended_Return)
+         then
             Cannot_Inline
               ("cannot inline & (unconstrained return type)?", N, Spec_Id);
             return;
@@ -2873,18 +2929,6 @@  package body Inline is
 
       elsif Nkind (Orig_Bod) in N_Entity then
          return;
-
-      --  Skip inlining if the function returns an unconstrained type using
-      --  an extended return statement since this part of the new inlining
-      --  model which is not yet supported by the current implementation. ???
-
-      elsif Is_Unc
-        and then
-          Nkind (First (Statements (Handled_Statement_Sequence (Orig_Bod)))) =
-            N_Extended_Return_Statement
-        and then not Back_End_Inlining
-      then
-         return;
       end if;
 
       if Nkind (Orig_Bod) = N_Defining_Identifier