From patchwork Sun Jun 10 20:28:00 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sergey Korolev X-Patchwork-Id: 927413 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=uclibc-ng.org (client-ip=2a00:1828:2000:679::23; helo=helium.openadk.org; envelope-from=devel-bounces@uclibc-ng.org; receiver=) Authentication-Results: ozlabs.org; dmarc=none (p=none dis=none) header.from=ndmsystems.com Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=ndmsystems-com.20150623.gappssmtp.com header.i=@ndmsystems-com.20150623.gappssmtp.com header.b="07WU9YqQ"; dkim-atps=neutral Received: from helium.openadk.org (helium.openadk.org [IPv6:2a00:1828:2000:679::23]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 413nmP0Sfgz9ryk for ; Mon, 11 Jun 2018 06:28:50 +1000 (AEST) Received: from helium.openadk.org (localhost [IPv6:::1]) by helium.openadk.org (Postfix) with ESMTP id 649A410652; Sun, 10 Jun 2018 22:28:46 +0200 (CEST) X-Original-To: devel@uclibc-ng.org Delivered-To: devel@helium.openadk.org Received: from mail-ot0-f181.google.com (mail-ot0-f181.google.com [74.125.82.181]) by helium.openadk.org (Postfix) with ESMTPS id BDC4D10652 for ; Sun, 10 Jun 2018 22:28:43 +0200 (CEST) Received: by mail-ot0-f181.google.com with SMTP id d19-v6so15943886oti.8 for ; Sun, 10 Jun 2018 13:28:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ndmsystems-com.20150623.gappssmtp.com; s=20150623; h=mime-version:from:date:message-id:subject:to; bh=nN/pAySllMVyJty0QI8GkTYP8BeQTiFSaLwxkKLwdYI=; b=07WU9YqQ9hvvl1GQJVS9PLaxF4SomEGuDv2k9+GmGMoT90nBhJKsornxarTzAUknij oEIowYJwLt0/iWjlGxaBR0UoaLN1pmxVyPLFSqPOtm0NFjJwF3joCd6eZ57bvW6BZ+Zd qI9xjTxzUi6PqUTvpJspYMVP//+8VZqm7af/JZXeJtHmpQoHbthfmQ3QWn8OLikHBUgk wTf+dECsqFkdLN4S+uLbF5aB0dOLzYSKotp/F0UFxf8v9GrhtwrOR5NAcFxGPRwLRGjy F69A5AELBpUJhpZ5s60WsE4NQlkuqJFB37ATeWNeENwVETXtwduEnpV4rl1V1M1/NW2S DrhA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:from:date:message-id:subject:to; bh=nN/pAySllMVyJty0QI8GkTYP8BeQTiFSaLwxkKLwdYI=; b=aUUY+iHW1wKQg9vxJ72KvqJaGPNC614AfzfMzF1RjvdSFpuGOa+0yYtzxoaNZqqwDg dX78XuuU8bekgV6CdFVObfdpNdoVZg+yz6bSjnF6H+i0QW50Dkvmd7LCSCuf9KJASUoy Obv3td0KQ/CE5TuGqTJY/3zK2mnom1fcvj/s4yNmzsh0YrPJ8DuK+7tyzlM0TzmAISEY QXOEaLCLL2z8U7VlEwokY4Ka12UgCbpbDIdh6xswkAl/lKYA9y+TfLYM9WFNrC/2tEwU N3E1Sr+rLMAuVbRUfVcOzOT6g89laPLRHaUb+fQzAGwheqKXcWXFODaJ3bJoojzOl8ep fG4Q== X-Gm-Message-State: APt69E2tue/LRaNItgDXEAxEJhfY5t3n7pUHurGm0h7NtH4l34pR8i+0 JNAa9jarY0l2U3r7IXVVcth+bOWKW5Rw/uwzPlOruJso X-Google-Smtp-Source: ADUXVKKYpsMTS1ANqR+89uWqrEmE6Zf2dJSpfN5953NeDRy+GQl1rakaODiKOkwy7TdjOD6BjJhoMXjncPTiSUgpM1U= X-Received: by 2002:a9d:1bd6:: with SMTP id v22-v6mr8940007otv.85.1528662521795; Sun, 10 Jun 2018 13:28:41 -0700 (PDT) MIME-Version: 1.0 Received: by 2002:a9d:4b97:0:0:0:0:0 with HTTP; Sun, 10 Jun 2018 13:28:00 -0700 (PDT) From: Sergey Korolev Date: Sun, 10 Jun 2018 23:28:00 +0300 Message-ID: To: devel@uclibc-ng.org Subject: [uclibc-ng-devel] _FILE_OFFSET_BITS=64 and preadv/pwritev prototypes X-BeenThere: devel@uclibc-ng.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: uClibc-ng Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: devel-bounces@uclibc-ng.org Sender: "devel" As preadv and pwritev accept off_t type the prototypes should be declared as follows extern ssize_t preadv (int __fd, const struct iovec *__iovec, int __count, off_t __offset) __wur; extern ssize_t pwritev (int __fd, const struct iovec *__iovec, int __count, off_t __offset) __wur; to take into account _FILE_OFFSET_BITS=64 define. I am not sure but probably it is better to redeclare these prototypes by analogy with sendfile using __REDIRECT_NTH. From 12347ece4b48c81a1db80eec660fc7ec7c542c19 Mon Sep 17 00:00:00 2001 From: Vlad Starodubtsev Date: Thu, 26 Oct 2017 17:22:33 +0300 Subject: [PATCH] Fix prototypes for preadv pwritev. --- include/sys/uio.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/include/sys/uio.h b/include/sys/uio.h index 78341ed40..aa766f9b1 100644 --- a/include/sys/uio.h +++ b/include/sys/uio.h @@ -59,7 +59,7 @@ extern ssize_t writev (int __fd, const struct iovec *__iovec, int __count); This function is a cancellation point and therefore not marked with __THROW. */ extern ssize_t preadv (int __fd, const struct iovec *__iovec, int __count, - __off_t __offset) __wur; + off_t __offset) __wur; /* Write data pointed by the buffers described by IOVEC, which is a vector of COUNT 'struct iovec's, to file descriptor FD at the given @@ -71,7 +71,7 @@ extern ssize_t preadv (int __fd, const struct iovec *__iovec, int __count, This function is a cancellation point and therefore not marked with __THROW. */ extern ssize_t pwritev (int __fd, const struct iovec *__iovec, int __count, - __off_t __offset) __wur; + off_t __offset) __wur; #endif /* Use misc. */ __END_DECLS -- 2.17.1