[SRU,Bionic,1/1] UBUNTU: SAUCE: Add Lenovo V330 to the ideapad_laptop rfkill blacklist

Message ID 90be299b1b3fba6e092b80336e0fb98111f28590.1527884719.git.joseph.salisbury@canonical.com
State New
Headers show
Series
  • UBUNTU: SAUCE: Add Lenovo V330 to the ideapad_laptop rfkill blacklist
Related show

Commit Message

Joseph Salisbury June 8, 2018, 7:55 p.m.
From: Johannes Wienke <languitar@semipol.de>

BugLink: http://bugs.launchpad.net/bugs/1774636

This laptop doesn't have a working hardware kill switch and thus the
wifi and bluetooth might become hard blocked without an option to revert
this state at runtime.

Signed-off-by: Johannes Wienke <languitar@semipol.de>
---
 drivers/platform/x86/ideapad-laptop.c | 7 +++++++
 1 file changed, 7 insertions(+)

Comments

Stefan Bader June 8, 2018, 8:23 p.m. | #1
On 08.06.2018 12:55, Joseph Salisbury wrote:
> From: Johannes Wienke <languitar@semipol.de>
> 
> BugLink: http://bugs.launchpad.net/bugs/1774636
> 
> This laptop doesn't have a working hardware kill switch and thus the
> wifi and bluetooth might become hard blocked without an option to revert
> this state at runtime.
> 
> Signed-off-by: Johannes Wienke <languitar@semipol.de>
Signed-off-by: Joseph Salisbury <joseph.salisbury@canonical.com>
Acked-by: Stefan Bader <stefan.bader@canonical.com>
> ---

Not sure but would/should there not be another s-o-b for forwarding?

-Stefan

>  drivers/platform/x86/ideapad-laptop.c | 7 +++++++
>  1 file changed, 7 insertions(+)
> 
> diff --git a/drivers/platform/x86/ideapad-laptop.c b/drivers/platform/x86/ideapad-laptop.c
> index 4c477f4..724baa9 100644
> --- a/drivers/platform/x86/ideapad-laptop.c
> +++ b/drivers/platform/x86/ideapad-laptop.c
> @@ -1006,6 +1006,13 @@ static const struct dmi_system_id no_hw_rfkill_list[] = {
>  		},
>  	},
>  	{
> +		.ident = "Lenovo V330-14IKB",
> +		.matches = {
> +			DMI_MATCH(DMI_SYS_VENDOR, "LENOVO"),
> +			DMI_MATCH(DMI_PRODUCT_VERSION, "Lenovo V330-14IKB"),
> +		},
> +	},
> +	{
>  		.ident = "Lenovo V510-15IKB",
>  		.matches = {
>  			DMI_MATCH(DMI_SYS_VENDOR, "LENOVO"),
>
Kleber Souza June 8, 2018, 8:59 p.m. | #2
On 06/08/18 12:55, Joseph Salisbury wrote:
> From: Johannes Wienke <languitar@semipol.de>
> 
> BugLink: http://bugs.launchpad.net/bugs/1774636
> 
> This laptop doesn't have a working hardware kill switch and thus the
> wifi and bluetooth might become hard blocked without an option to revert
> this state at runtime.
> 
> Signed-off-by: Johannes Wienke <languitar@semipol.de>

Same comment as Stefan regarding the additional s-o-b.

Acked-by: Kleber Sacilotto de Souza <kleber.souza@canonical.com>

> ---
>  drivers/platform/x86/ideapad-laptop.c | 7 +++++++
>  1 file changed, 7 insertions(+)
> 
> diff --git a/drivers/platform/x86/ideapad-laptop.c b/drivers/platform/x86/ideapad-laptop.c
> index 4c477f4..724baa9 100644
> --- a/drivers/platform/x86/ideapad-laptop.c
> +++ b/drivers/platform/x86/ideapad-laptop.c
> @@ -1006,6 +1006,13 @@ static const struct dmi_system_id no_hw_rfkill_list[] = {
>  		},
>  	},
>  	{
> +		.ident = "Lenovo V330-14IKB",
> +		.matches = {
> +			DMI_MATCH(DMI_SYS_VENDOR, "LENOVO"),
> +			DMI_MATCH(DMI_PRODUCT_VERSION, "Lenovo V330-14IKB"),
> +		},
> +	},
> +	{
>  		.ident = "Lenovo V510-15IKB",
>  		.matches = {
>  			DMI_MATCH(DMI_SYS_VENDOR, "LENOVO"),
>
Joseph Salisbury June 8, 2018, 9:09 p.m. | #3
On 06/08/2018 04:23 PM, Stefan Bader wrote:
> On 08.06.2018 12:55, Joseph Salisbury wrote:
>> From: Johannes Wienke <languitar@semipol.de>
>>
>> BugLink: http://bugs.launchpad.net/bugs/1774636
>>
>> This laptop doesn't have a working hardware kill switch and thus the
>> wifi and bluetooth might become hard blocked without an option to revert
>> this state at runtime.
>>
>> Signed-off-by: Johannes Wienke <languitar@semipol.de>
> Signed-off-by: Joseph Salisbury <joseph.salisbury@canonical.com>
> Acked-by: Stefan Bader <stefan.bader@canonical.com>
>> ---
> Not sure but would/should there not be another s-o-b for forwarding?
>
> -Stefan
>
>>  drivers/platform/x86/ideapad-laptop.c | 7 +++++++
>>  1 file changed, 7 insertions(+)
>>
>> diff --git a/drivers/platform/x86/ideapad-laptop.c b/drivers/platform/x86/ideapad-laptop.c
>> index 4c477f4..724baa9 100644
>> --- a/drivers/platform/x86/ideapad-laptop.c
>> +++ b/drivers/platform/x86/ideapad-laptop.c
>> @@ -1006,6 +1006,13 @@ static const struct dmi_system_id no_hw_rfkill_list[] = {
>>  		},
>>  	},
>>  	{
>> +		.ident = "Lenovo V330-14IKB",
>> +		.matches = {
>> +			DMI_MATCH(DMI_SYS_VENDOR, "LENOVO"),
>> +			DMI_MATCH(DMI_PRODUCT_VERSION, "Lenovo V330-14IKB"),
>> +		},
>> +	},
>> +	{
>>  		.ident = "Lenovo V510-15IKB",
>>  		.matches = {
>>  			DMI_MATCH(DMI_SYS_VENDOR, "LENOVO"),
>>
>
>
>
Thanks for adding my sob!

Patch

diff --git a/drivers/platform/x86/ideapad-laptop.c b/drivers/platform/x86/ideapad-laptop.c
index 4c477f4..724baa9 100644
--- a/drivers/platform/x86/ideapad-laptop.c
+++ b/drivers/platform/x86/ideapad-laptop.c
@@ -1006,6 +1006,13 @@  static const struct dmi_system_id no_hw_rfkill_list[] = {
 		},
 	},
 	{
+		.ident = "Lenovo V330-14IKB",
+		.matches = {
+			DMI_MATCH(DMI_SYS_VENDOR, "LENOVO"),
+			DMI_MATCH(DMI_PRODUCT_VERSION, "Lenovo V330-14IKB"),
+		},
+	},
+	{
 		.ident = "Lenovo V510-15IKB",
 		.matches = {
 			DMI_MATCH(DMI_SYS_VENDOR, "LENOVO"),