diff mbox series

[PULL,13/30] ahci: fix host register max address

Message ID	20180608174733.4936-14-jsnow@redhat.com
State	New
Headers	show Return-Path: <qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org> From: John Snow <jsnow@redhat.com> To: qemu-devel@nongnu.org Date: Fri, 8 Jun 2018 13:47:16 -0400 Message-Id: <20180608174733.4936-14-jsnow@redhat.com> In-Reply-To: <20180608174733.4936-1-jsnow@redhat.com> References: <20180608174733.4936-1-jsnow@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Subject: [Qemu-devel] [PULL 13/30] ahci: fix host register max address Precedence: list Cc: peter.maydell@linaro.org, jsnow@redhat.com Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: "Qemu-devel" <qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>
Series	[PULL,01/30] ahci: trim signatures on raise/lower \| expand [PULL,01/30] ahci: trim signatures on raise/lower [PULL,02/30] ahci: fix PxCI register race [PULL,03/30] ahci: don't schedule unnecessary BH [PULL,04/30] ahci: add port register enumeration [PULL,05/30] ahci: modify ahci_port_read to use register numbers [PULL,06/30] ahci: make port read traces more descriptive [PULL,07/30] ahci: fix spacing damage on ahci_port_write [PULL,08/30] ahci: combine identical clauses in port write [PULL,09/30] ahci: modify ahci_port_write to use register numbers [PULL,10/30] ahci: make port write traces more descriptive [PULL,11/30] ahci: delete old port register address definitions [PULL,12/30] ahci: add host register enumeration [PULL,13/30] ahci: fix host register max address [PULL,14/30] ahci: modify ahci_mem_read_32 to work on register numbers [PULL,15/30] ahci: make mem_read_32 traces more descriptive [PULL,16/30] ahci: fix spacing damage on ahci_mem_write [PULL,17/30] ahci: adjust ahci_mem_write to work on registers [PULL,18/30] ahci: delete old host register address definitions [PULL,19/30] ahci: make ahci_mem_write traces more descriptive [PULL,20/30] tests/boot-sector: Add magic bytes to s390x boot code header [PULL,21/30] tests/cdrom-test: Test booting from CD-ROM ISO image file [PULL,22/30] tests/cdrom-test: Test that -cdrom parameter is working [PULL,23/30] MAINTAINERS: Add the cdrom-test to John's section [PULL,24/30] libqos/ahci: track sector size [PULL,25/30] ahci: move PIO Setup FIS before transfer, fix it for ATAPI commands [PULL,26/30] ide: push end_transfer_func out of start_transfer callback, rename callback [PULL,27/30] ide: call ide_cmd_done from ide_transfer_stop [PULL,28/30] ide: make ide_transfer_stop idempotent [PULL,29/30] atapi: call ide_set_irq before ide_transfer_start [PULL,30/30] ide: introduce ide_transfer_start_norecurse

Commit Message

John Snow June 8, 2018, 5:47 p.m. UTC

Yes, comment, it ought to be 0x2C.

Signed-off-by: John Snow <jsnow@redhat.com>
Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
Message-id: 20180531222835.16558-11-jsnow@redhat.com
Signed-off-by: John Snow <jsnow@redhat.com>
---
 hw/ide/ahci_internal.h | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff mbox series

Patch

diff --git a/hw/ide/ahci_internal.h b/hw/ide/ahci_internal.h
index af366db6f3..f9dcf8b6e6 100644
--- a/hw/ide/ahci_internal.h
+++ b/hw/ide/ahci_internal.h
@@ -224,8 +224,7 @@  enum AHCIPortIRQ {
 #define SATA_SIGNATURE_CDROM               0xeb140101
 #define SATA_SIGNATURE_DISK                0x00000101
 
-#define AHCI_GENERIC_HOST_CONTROL_REGS_MAX_ADDR 0x20
-                                            /* Shouldn't this be 0x2c? */
+#define AHCI_GENERIC_HOST_CONTROL_REGS_MAX_ADDR 0x2c
 
 #define AHCI_PORT_REGS_START_ADDR          0x100
 #define AHCI_PORT_ADDR_OFFSET_MASK         0x7f