Message ID | 20180608061316.4909-1-samuel.thibault@ens-lyon.org |
---|---|
State | New |
Headers | show |
Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: 20180608061316.4909-1-samuel.thibault@ens-lyon.org Subject: [Qemu-devel] [PULL 0/5] slirp updates === TEST SCRIPT BEGIN === #!/bin/bash BASE=base n=1 total=$(git log --oneline $BASE.. | wc -l) failed=0 git config --local diff.renamelimit 0 git config --local diff.renames True git config --local diff.algorithm histogram commits="$(git log --format=%H --reverse $BASE..)" for c in $commits; do echo "Checking PATCH $n/$total: $(git log -n 1 --format=%s $c)..." if ! git show $c --format=email | ./scripts/checkpatch.pl --mailback -; then failed=1 echo fi n=$((n+1)) done exit $failed === TEST SCRIPT END === Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384 From https://github.com/patchew-project/qemu * [new tag] patchew/20180608061316.4909-1-samuel.thibault@ens-lyon.org -> patchew/20180608061316.4909-1-samuel.thibault@ens-lyon.org Switched to a new branch 'test' 00a042daa6 slirp: reformat m_inc routine b2bd5ee65e slirp: correct size computation while concatenating mbuf c9786d65a1 slirp: fix domainname version availability 4f34ee0609 slirp: Add Samuel Thibault's staging tree for slirp 9159762703 slirp: Fix spurious error report when sending directly === OUTPUT BEGIN === Checking PATCH 1/5: slirp: Fix spurious error report when sending directly... ERROR: code indent should never use tabs #25: FILE: slirp/socket.c:343: +^Iint n;$ ERROR: code indent should never use tabs #34: FILE: slirp/socket.c:362: +^I^Iint len = (sb->sb_data + sb->sb_datalen) - sb->sb_rptr;$ ERROR: code indent should never use tabs #43: FILE: slirp/socket.c:378: +^I^Iif (n != len) {$ WARNING: line over 80 characters #44: FILE: slirp/socket.c:379: + DEBUG_ERROR((dfd, "Didn't send all data urgently XXXXX\n")); ERROR: code indent should never use tabs #44: FILE: slirp/socket.c:379: +^I^I^IDEBUG_ERROR((dfd, "Didn't send all data urgently XXXXX\n"));$ ERROR: code indent should never use tabs #45: FILE: slirp/socket.c:380: +^I^I}$ total: 5 errors, 1 warnings, 34 lines checked Your patch has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. Checking PATCH 2/5: slirp: Add Samuel Thibault's staging tree for slirp... Checking PATCH 3/5: slirp: fix domainname version availability... Checking PATCH 4/5: slirp: correct size computation while concatenating mbuf... ERROR: code indent should never use tabs #25: FILE: slirp/mbuf.c:141: +^I^Im_inc(m, m->m_len + n->m_len);$ ERROR: code indent should never use tabs #43: FILE: slirp/mbuf.c:161: +^I m->m_ext = g_realloc(m->m_ext, size + datasize);$ ERROR: code indent should never use tabs #49: FILE: slirp/mbuf.c:166: +^I dat = g_malloc(size + datasize);$ ERROR: code indent should never use tabs #81: FILE: slirp/mbuf.h:73: +^Iint^Im_size;^I^I^I/* Size of mbuf, from m_dat or m_ext */$ ERROR: code indent should never use tabs #86: FILE: slirp/mbuf.h:76: +^Icaddr_t^Im_data;^I^I^I/* Current location of data */$ WARNING: line over 80 characters #87: FILE: slirp/mbuf.h:77: + int m_len; /* Amount of data in this mbuf, from m_data */ ERROR: code indent should never use tabs #87: FILE: slirp/mbuf.h:77: +^Iint^Im_len;^I^I^I/* Amount of data in this mbuf, from m_data */$ total: 6 errors, 1 warnings, 61 lines checked Your patch has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. Checking PATCH 5/5: slirp: reformat m_inc routine... === OUTPUT END === Test command exited with code: 1 --- Email generated automatically by Patchew [http://patchew.org/]. Please send your feedback to patchew-devel@redhat.com
On 8 June 2018 at 07:13, Samuel Thibault <samuel.thibault@ens-lyon.org> wrote: > The following changes since commit 9be4af13305f24d2dabf94bb53e6b65c76d08bb2: > > Merge remote-tracking branch 'remotes/thibault/tags/samuel-thibault' into staging (2018-06-01 14:58:53 +0100) > > are available in the Git repository at: > > https://people.debian.org/~sthibault/qemu.git tags/samuel-thibault > > for you to fetch changes up to c22098c74a09164797fae6511c5eaf68f32c4dd8: > > slirp: reformat m_inc routine (2018-06-08 09:08:30 +0300) > > ---------------------------------------------------------------- > slirp updates > > Prasad J Pandit (2): > slirp: Fix buffer overflow on packet reassembling > > Samuel Thibault (3): > slirp: Add Samuel Thibault's staging tree for slirp > slirp: fix domainname version availability > Applied, thanks. -- PMM