Move include lock.h to fsp-console.h from console.h

Message ID 20180608044751.30503-1-stewart@linux.ibm.com
State Accepted
Headers show
Series
  • Move include lock.h to fsp-console.h from console.h
Related show

Commit Message

Stewart Smith June 8, 2018, 4:47 a.m.
It's only used there, let's minimise our needed includes.

Signed-off-by: Stewart Smith <stewart@linux.ibm.com>
---
 hw/fsp/fsp-console.c | 1 +
 include/console.h    | 1 -
 2 files changed, 1 insertion(+), 1 deletion(-)

Comments

Stewart Smith June 19, 2018, 5:45 a.m. | #1
Stewart Smith <stewart@linux.ibm.com> writes:
> It's only used there, let's minimise our needed includes.
>
> Signed-off-by: Stewart Smith <stewart@linux.ibm.com>
> ---
>  hw/fsp/fsp-console.c | 1 +
>  include/console.h    | 1 -
>  2 files changed, 1 insertion(+), 1 deletion(-)

merged to master as of 900f86ab6ff7a2b56bb99af25344f44d3415b895

Patch

diff --git a/hw/fsp/fsp-console.c b/hw/fsp/fsp-console.c
index 2c6151da2518..9d9b7ab47441 100644
--- a/hw/fsp/fsp-console.c
+++ b/hw/fsp/fsp-console.c
@@ -27,6 +27,7 @@ 
 #include <device.h>
 #include <fsp-sysparam.h>
 #include <errorlog.h>
+#include <lock.h>
 
 DEFINE_LOG_ENTRY(OPAL_RC_CONSOLE_HANG, OPAL_PLATFORM_ERR_EVT, OPAL_CONSOLE,
 		 OPAL_PLATFORM_FIRMWARE,
diff --git a/include/console.h b/include/console.h
index 708b696bf03e..94138af308dc 100644
--- a/include/console.h
+++ b/include/console.h
@@ -18,7 +18,6 @@ 
 #define __CONSOLE_H
 
 #include "unistd.h"
-#include <lock.h>
 
 /*
  * Our internal console uses the format of BML new-style in-memory