| Message ID | 20180608022341.27225-1-anarsoul@gmail.com |
|---|---|
| State | Accepted |
| Delegated to: | Marek Vasut |
| Headers | show |
| Series | [U-Boot,v3,1/4] sunxi: clock: Fix EHCI and OHCI clocks on A64 | expand |
On 2018-06-07, Vasily Khoruzhick wrote: > EHCI0 is bit 24, EHCI1 - 25, OHCI0 - 28, OHCI1 - 29 > > Fixes commit fef73766d9ad ("sunxi: clock: Fix OHCI clock gating for H3/H5") > > Signed-off-by: Vasily Khoruzhick <anarsoul@gmail.com> > --- > arch/arm/include/asm/arch-sunxi/clock_sun6i.h | 6 ++++-- > 1 file changed, 4 insertions(+), 2 deletions(-) Tested on pine64+ grub EFI from USB, which then loaded kernel+initrd off of USB, as well as using distro_bootcmd's exlinux.conf, loading kernel+initrd+dtb from USB... For the whole series of 4 v3 patches: Tested-by: Vagrant Cascadian <vagrant@debian.org> live well, vagrant > diff --git a/arch/arm/include/asm/arch-sunxi/clock_sun6i.h b/arch/arm/include/asm/arch-sunxi/clock_sun6i.h > index 8acf79fbba..8afeaf872e 100644 > --- a/arch/arm/include/asm/arch-sunxi/clock_sun6i.h > +++ b/arch/arm/include/asm/arch-sunxi/clock_sun6i.h > @@ -280,8 +280,10 @@ struct sunxi_ccm_reg { > #define AHB_GATE_OFFSET_USB_EHCI1 26 > #define AHB_GATE_OFFSET_USB_EHCI0 24 > #elif defined(CONFIG_MACH_SUN50I) > -#define AHB_GATE_OFFSET_USB_OHCI0 29 > -#define AHB_GATE_OFFSET_USB_EHCI0 25 > +#define AHB_GATE_OFFSET_USB_OHCI0 28 > +#define AHB_GATE_OFFSET_USB_OHCI1 29 > +#define AHB_GATE_OFFSET_USB_EHCI0 24 > +#define AHB_GATE_OFFSET_USB_EHCI1 25 > #else > #define AHB_GATE_OFFSET_USB_OHCI1 30 > #define AHB_GATE_OFFSET_USB_OHCI0 29
On Thu, Jun 7, 2018 at 7:23 PM, Vasily Khoruzhick <anarsoul@gmail.com> wrote: > EHCI0 is bit 24, EHCI1 - 25, OHCI0 - 28, OHCI1 - 29 > > Fixes commit fef73766d9ad ("sunxi: clock: Fix OHCI clock gating for H3/H5") > > Signed-off-by: Vasily Khoruzhick <anarsoul@gmail.com> Any feedback on this patch series? > --- > arch/arm/include/asm/arch-sunxi/clock_sun6i.h | 6 ++++-- > 1 file changed, 4 insertions(+), 2 deletions(-) > > diff --git a/arch/arm/include/asm/arch-sunxi/clock_sun6i.h b/arch/arm/include/asm/arch-sunxi/clock_sun6i.h > index 8acf79fbba..8afeaf872e 100644 > --- a/arch/arm/include/asm/arch-sunxi/clock_sun6i.h > +++ b/arch/arm/include/asm/arch-sunxi/clock_sun6i.h > @@ -280,8 +280,10 @@ struct sunxi_ccm_reg { > #define AHB_GATE_OFFSET_USB_EHCI1 26 > #define AHB_GATE_OFFSET_USB_EHCI0 24 > #elif defined(CONFIG_MACH_SUN50I) > -#define AHB_GATE_OFFSET_USB_OHCI0 29 > -#define AHB_GATE_OFFSET_USB_EHCI0 25 > +#define AHB_GATE_OFFSET_USB_OHCI0 28 > +#define AHB_GATE_OFFSET_USB_OHCI1 29 > +#define AHB_GATE_OFFSET_USB_EHCI0 24 > +#define AHB_GATE_OFFSET_USB_EHCI1 25 > #else > #define AHB_GATE_OFFSET_USB_OHCI1 30 > #define AHB_GATE_OFFSET_USB_OHCI0 29 > -- > 2.17.1 >
On 06/08/2018 04:23 AM, Vasily Khoruzhick wrote: > EHCI0 is bit 24, EHCI1 - 25, OHCI0 - 28, OHCI1 - 29 > > Fixes commit fef73766d9ad ("sunxi: clock: Fix OHCI clock gating for H3/H5") > > Signed-off-by: Vasily Khoruzhick <anarsoul@gmail.com> > --- > arch/arm/include/asm/arch-sunxi/clock_sun6i.h | 6 ++++-- > 1 file changed, 4 insertions(+), 2 deletions(-) > > diff --git a/arch/arm/include/asm/arch-sunxi/clock_sun6i.h b/arch/arm/include/asm/arch-sunxi/clock_sun6i.h > index 8acf79fbba..8afeaf872e 100644 > --- a/arch/arm/include/asm/arch-sunxi/clock_sun6i.h > +++ b/arch/arm/include/asm/arch-sunxi/clock_sun6i.h > @@ -280,8 +280,10 @@ struct sunxi_ccm_reg { > #define AHB_GATE_OFFSET_USB_EHCI1 26 > #define AHB_GATE_OFFSET_USB_EHCI0 24 > #elif defined(CONFIG_MACH_SUN50I) > -#define AHB_GATE_OFFSET_USB_OHCI0 29 > -#define AHB_GATE_OFFSET_USB_EHCI0 25 > +#define AHB_GATE_OFFSET_USB_OHCI0 28 > +#define AHB_GATE_OFFSET_USB_OHCI1 29 > +#define AHB_GATE_OFFSET_USB_EHCI0 24 > +#define AHB_GATE_OFFSET_USB_EHCI1 25 > #else > #define AHB_GATE_OFFSET_USB_OHCI1 30 > #define AHB_GATE_OFFSET_USB_OHCI0 29 > Applied all 4, thanks.
diff --git a/arch/arm/include/asm/arch-sunxi/clock_sun6i.h b/arch/arm/include/asm/arch-sunxi/clock_sun6i.h index 8acf79fbba..8afeaf872e 100644 --- a/arch/arm/include/asm/arch-sunxi/clock_sun6i.h +++ b/arch/arm/include/asm/arch-sunxi/clock_sun6i.h @@ -280,8 +280,10 @@ struct sunxi_ccm_reg { #define AHB_GATE_OFFSET_USB_EHCI1 26 #define AHB_GATE_OFFSET_USB_EHCI0 24 #elif defined(CONFIG_MACH_SUN50I) -#define AHB_GATE_OFFSET_USB_OHCI0 29 -#define AHB_GATE_OFFSET_USB_EHCI0 25 +#define AHB_GATE_OFFSET_USB_OHCI0 28 +#define AHB_GATE_OFFSET_USB_OHCI1 29 +#define AHB_GATE_OFFSET_USB_EHCI0 24 +#define AHB_GATE_OFFSET_USB_EHCI1 25 #else #define AHB_GATE_OFFSET_USB_OHCI1 30 #define AHB_GATE_OFFSET_USB_OHCI0 29
EHCI0 is bit 24, EHCI1 - 25, OHCI0 - 28, OHCI1 - 29 Fixes commit fef73766d9ad ("sunxi: clock: Fix OHCI clock gating for H3/H5") Signed-off-by: Vasily Khoruzhick <anarsoul@gmail.com> --- arch/arm/include/asm/arch-sunxi/clock_sun6i.h | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-)