[v4,2/3] dt-bindings: usb: new ehci-npcm7xx dt

Message ID 20180607145821.322979-3-avifishman70@gmail.com
State Not Applicable, archived
Headers show
Series
  • USB host: Add USB ehci support for nuvoton npcm7xx
Related show

Commit Message

Avi Fishman June 7, 2018, 2:58 p.m.
From: Avi Fishman <AviFishman70@gmail.com>

Device Tree documentation for Nuvoton npcm7xx EHCI.

Signed-off-by: Avi Fishman <AviFishman70@gmail.com>
---
 Documentation/devicetree/bindings/usb/npcm7xx-usb.txt | 17 +++++++++++++++++
 1 file changed, 17 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/usb/npcm7xx-usb.txt

Comments

Rob Herring June 11, 2018, 6:16 p.m. | #1
On Thu, Jun 07, 2018 at 05:58:20PM +0300, avifishman70@gmail.com wrote:
> From: Avi Fishman <AviFishman70@gmail.com>
> 
> Device Tree documentation for Nuvoton npcm7xx EHCI.
> 
> Signed-off-by: Avi Fishman <AviFishman70@gmail.com>
> ---
>  Documentation/devicetree/bindings/usb/npcm7xx-usb.txt | 17 +++++++++++++++++
>  1 file changed, 17 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/usb/npcm7xx-usb.txt

Please add acks/reviewed-bys when posting new versions.

Rob
Avi Fishman June 11, 2018, 6:24 p.m. | #2
On Mon, Jun 11, 2018 at 9:16 PM, Rob Herring <robh@kernel.org> wrote:
> On Thu, Jun 07, 2018 at 05:58:20PM +0300, avifishman70@gmail.com wrote:
>> From: Avi Fishman <AviFishman70@gmail.com>
>>
>> Device Tree documentation for Nuvoton npcm7xx EHCI.
>>
>> Signed-off-by: Avi Fishman <AviFishman70@gmail.com>

Reviewed-by: Rob Herring <robh@kernel.org>
Rob, if I understand you want me to add another version (v5) with the
above line (only on the dt)?

>> ---
>>  Documentation/devicetree/bindings/usb/npcm7xx-usb.txt | 17 +++++++++++++++++
>>  1 file changed, 17 insertions(+)
>>  create mode 100644 Documentation/devicetree/bindings/usb/npcm7xx-usb.txt
>
> Please add acks/reviewed-bys when posting new versions.
>
> Rob
Rob Herring June 11, 2018, 6:55 p.m. | #3
On Mon, Jun 11, 2018 at 12:24 PM, Avi Fishman <avifishman70@gmail.com> wrote:
> On Mon, Jun 11, 2018 at 9:16 PM, Rob Herring <robh@kernel.org> wrote:
>> On Thu, Jun 07, 2018 at 05:58:20PM +0300, avifishman70@gmail.com wrote:
>>> From: Avi Fishman <AviFishman70@gmail.com>
>>>
>>> Device Tree documentation for Nuvoton npcm7xx EHCI.
>>>
>>> Signed-off-by: Avi Fishman <AviFishman70@gmail.com>
>
> Reviewed-by: Rob Herring <robh@kernel.org>
> Rob, if I understand you want me to add another version (v5) with the
> above line (only on the dt)?

No need to *only* do that. Maintainers will collect them on the last
version when they apply patches. You just can't expect that
maintainers will go look at prior versions and collect them.

>>> ---
>>>  Documentation/devicetree/bindings/usb/npcm7xx-usb.txt | 17 +++++++++++++++++
>>>  1 file changed, 17 insertions(+)
>>>  create mode 100644 Documentation/devicetree/bindings/usb/npcm7xx-usb.txt
>>
>> Please add acks/reviewed-bys when posting new versions.
>>
>> Rob

Patch

diff --git a/Documentation/devicetree/bindings/usb/npcm7xx-usb.txt b/Documentation/devicetree/bindings/usb/npcm7xx-usb.txt
new file mode 100644
index 000000000000..b682bec103f9
--- /dev/null
+++ b/Documentation/devicetree/bindings/usb/npcm7xx-usb.txt
@@ -0,0 +1,17 @@ 
+Nuvoton NPCM7XX SoC USB controllers:
+-----------------------------
+
+EHCI:
+-----
+
+Required properties:
+- compatible: "nuvoton,npcm750-ehci"
+- interrupts: Should contain the EHCI interrupt
+
+Example:
+
+	ehci1: usb@f0806000 {
+		compatible = "nuvoton,npcm750-ehci";
+		reg = <0xf0806000 0x1000>;
+		interrupts = <0 61 4>;
+	};