trival: Remove an extra reg read of VUART1_GCTRLA

Message ID 20180607132903.16617-1-bsingharora@gmail.com
State New
Headers show
Series
  • trival: Remove an extra reg read of VUART1_GCTRLA
Related show

Commit Message

Balbir Singh June 7, 2018, 1:29 p.m.
The comments did not say if the read was needed to
ensure the previous write completed, but otherwise
the read is followed by a read of VUART1_GCTRLB and the
value of v is discarded.

Signed-off-by: Balbir singh <bsingharora@gmail.com>
---

NOTE: As you might suspect I have no way of testing this
except for compile testing it

 hw/ast-bmc/ast-io.c | 1 -
 1 file changed, 1 deletion(-)

Patch

diff --git a/hw/ast-bmc/ast-io.c b/hw/ast-bmc/ast-io.c
index 1e826fcc..a07f5822 100644
--- a/hw/ast-bmc/ast-io.c
+++ b/hw/ast-bmc/ast-io.c
@@ -434,7 +434,6 @@  void ast_setup_vuart1(uint16_t io_base, uint8_t irq)
 	v = bmc_sio_ahb_readl(VUART1_GCTRLA);
 	v = v & ~2u;
 	bmc_sio_ahb_writel(v, VUART1_GCTRLA);
-	v = bmc_sio_ahb_readl(VUART1_GCTRLA);
 
 	/* IRQ number */
 	v = bmc_sio_ahb_readl(VUART1_GCTRLB);