[09/11] target/m68k: Add trailing '\n' to qemu_log() call

Message ID	20180606152128.449-10-f4bug@amsat.org
State	Accepted, archived
Headers	show Return-Path: <qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org> From: =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= <f4bug@amsat.org> To: Laurent Vivier <laurent@vivier.eu> Date: Wed, 6 Jun 2018 12:21:26 -0300 Message-Id: <20180606152128.449-10-f4bug@amsat.org> In-Reply-To: <20180606152128.449-1-f4bug@amsat.org> References: <20180606152128.449-1-f4bug@amsat.org> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Subject: [Qemu-devel] [PATCH 09/11] target/m68k: Add trailing '\n' to qemu_log() call Precedence: list Cc: qemu-trivial@nongnu.org, =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= <f4bug@amsat.org>, qemu-devel@nongnu.org Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: "Qemu-devel" <qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>
Series	misc: Add trailing '\n' to qemu_log() calls \| expand [00/11] misc: Add trailing '\n' to qemu_log() calls [01/11] hw/sd/milkymist-memcard: Add trailing '\n' to qemu_log() call [02/11] hw/digic: Add trailing '\n' to qemu_log() calls [03/11] xilinx-dp: Add trailing '\n' to qemu_log() call [04/11] ppc/pnv: Add trailing '\n' to qemu_log() calls [05/11] hw/core/register: Add trailing '\n' to qemu_log() call [06/11] hw/mips/boston: Add trailing '\n' to qemu_log() calls [07/11] stellaris: Add trailing '\n' to qemu_log() calls [08/11] target/arm: Add trailing '\n' to qemu_log() calls [09/11] target/m68k: Add trailing '\n' to qemu_log() call [10/11] RISC-V: Add trailing '\n' to qemu_log() calls [RFC,11/11] target/xtensa: Add trailing '\n' to qemu_log() calls

Message ID

20180606152128.449-10-f4bug@amsat.org

State

Accepted, archived

Headers

From: =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= <f4bug@amsat.org>
To: Laurent Vivier <laurent@vivier.eu>
Date: Wed,  6 Jun 2018 12:21:26 -0300
Message-Id: <20180606152128.449-10-f4bug@amsat.org>
In-Reply-To: <20180606152128.449-1-f4bug@amsat.org>
References: <20180606152128.449-1-f4bug@amsat.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
Subject: [Qemu-devel] [PATCH 09/11] target/m68k: Add trailing '\n' to
	qemu_log() call
Precedence: list
Cc: qemu-trivial@nongnu.org, =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?=
	<f4bug@amsat.org>, 	qemu-devel@nongnu.org
Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org
Sender: "Qemu-devel"
	<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>

Series

misc: Add trailing '\n' to qemu_log() calls | expand

Comments

Laurent Vivier June 6, 2018, 3:26 p.m. UTC | #1

Le 06/06/2018 à 17:21, Philippe Mathieu-Daudé a écrit :
> Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
> ---
>  target/m68k/translate.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/target/m68k/translate.c b/target/m68k/translate.c
> index 37d6ffd853..4b5dbdb51c 100644
> --- a/target/m68k/translate.c
> +++ b/target/m68k/translate.c
> @@ -1556,7 +1556,7 @@ DISAS_INSN(undef)
>      /* ??? This is both instructions that are as yet unimplemented
>         for the 680x0 series, as well as those that are implemented
>         but actually illegal for CPU32 or pre-68020.  */
> -    qemu_log_mask(LOG_UNIMP, "Illegal instruction: %04x @ %08x",
> +    qemu_log_mask(LOG_UNIMP, "Illegal instruction: %04x @ %08x\n",
>                    insn, s->insn_pc);
>      gen_exception(s, s->insn_pc, EXCP_UNSUPPORTED);
>  }
> 

Reviewed-by: Laurent Vivier <laurent@vivier.eu>

diff --git a/target/m68k/translate.c b/target/m68k/translate.c
index 37d6ffd853..4b5dbdb51c 100644
--- a/target/m68k/translate.c
+++ b/target/m68k/translate.c
@@ -1556,7 +1556,7 @@  DISAS_INSN(undef)
     /* ??? This is both instructions that are as yet unimplemented
        for the 680x0 series, as well as those that are implemented
        but actually illegal for CPU32 or pre-68020.  */
-    qemu_log_mask(LOG_UNIMP, "Illegal instruction: %04x @ %08x",
+    qemu_log_mask(LOG_UNIMP, "Illegal instruction: %04x @ %08x\n",
                   insn, s->insn_pc);
     gen_exception(s, s->insn_pc, EXCP_UNSUPPORTED);
 }

[09/11] target/m68k: Add trailing '\n' to qemu_log() call

Commit Message

Comments

Patch