[kteam-tools] maintscripts: maint-modify-patch: Switch from http to https for BugLinks

Message ID 20180606150913.GA24302@xps13.dannf
State New
Headers show
Series
  • [kteam-tools] maintscripts: maint-modify-patch: Switch from http to https for BugLinks
Related show

Commit Message

dann frazier June 6, 2018, 3:09 p.m.
We wouldn't want the man in the middle rick-rolling our users, now would we?

Signed-off-by: dann frazier <dann.frazier@canonical.com>
---
 maintscripts/maint-modify-patch | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Thadeu Lima de Souza Cascardo June 6, 2018, 3:10 p.m. | #1
On Wed, Jun 06, 2018 at 09:09:13AM -0600, dann frazier wrote:
> We wouldn't want the man in the middle rick-rolling our users, now would we?
> 
> Signed-off-by: dann frazier <dann.frazier@canonical.com>

Acked-by: Thadeu Lima de Souza Cascardo <cascardo@canonical.com>

> ---
>  maintscripts/maint-modify-patch | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/maintscripts/maint-modify-patch b/maintscripts/maint-modify-patch
> index 99673ec0..442919ed 100755
> --- a/maintscripts/maint-modify-patch
> +++ b/maintscripts/maint-modify-patch
> @@ -207,7 +207,7 @@ class ModifyPatch(StdApp):
>          self.defaults['list-aliases']     = False
>          self.defaults['modify-operation'] = False
>          self.defaults['dry-run']          = False
> -        self.defaults['buglink_base_url'] = "http://bugs.launchpad.net/bugs/"
> +        self.defaults['buglink_base_url'] = "https://bugs.launchpad.net/bugs/"
>  
>          self.cp_rc = compile('\(cherry picked from commit ([0-9a-zA-Z]+)\)')
>          self.bp_rc = compile('\(backported from commit ([0-9a-zA-Z]+) upstream\)')
> -- 
> 2.17.1
> 
> 
> -- 
> kernel-team mailing list
> kernel-team@lists.ubuntu.com
> https://lists.ubuntu.com/mailman/listinfo/kernel-team
Colin King June 6, 2018, 3:14 p.m. | #2
On 06/06/18 16:09, dann frazier wrote:
> We wouldn't want the man in the middle rick-rolling our users, now would we?
> 
> Signed-off-by: dann frazier <dann.frazier@canonical.com>
> ---
>  maintscripts/maint-modify-patch | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/maintscripts/maint-modify-patch b/maintscripts/maint-modify-patch
> index 99673ec0..442919ed 100755
> --- a/maintscripts/maint-modify-patch
> +++ b/maintscripts/maint-modify-patch
> @@ -207,7 +207,7 @@ class ModifyPatch(StdApp):
>          self.defaults['list-aliases']     = False
>          self.defaults['modify-operation'] = False
>          self.defaults['dry-run']          = False
> -        self.defaults['buglink_base_url'] = "http://bugs.launchpad.net/bugs/"
> +        self.defaults['buglink_base_url'] = "https://bugs.launchpad.net/bugs/"
>  
>          self.cp_rc = compile('\(cherry picked from commit ([0-9a-zA-Z]+)\)')
>          self.bp_rc = compile('\(backported from commit ([0-9a-zA-Z]+) upstream\)')
> 
Acked-by: Colin Ian King <colin.king@canonical.com>
Stefan Bader June 6, 2018, 7:20 p.m. | #3
On 06.06.2018 08:09, dann frazier wrote:
> We wouldn't want the man in the middle rick-rolling our users, now would we?
> 
> Signed-off-by: dann frazier <dann.frazier@canonical.com>
> ---
>  maintscripts/maint-modify-patch | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/maintscripts/maint-modify-patch b/maintscripts/maint-modify-patch
> index 99673ec0..442919ed 100755
> --- a/maintscripts/maint-modify-patch
> +++ b/maintscripts/maint-modify-patch
> @@ -207,7 +207,7 @@ class ModifyPatch(StdApp):
>          self.defaults['list-aliases']     = False
>          self.defaults['modify-operation'] = False
>          self.defaults['dry-run']          = False
> -        self.defaults['buglink_base_url'] = "http://bugs.launchpad.net/bugs/"
> +        self.defaults['buglink_base_url'] = "https://bugs.launchpad.net/bugs/"
>  
>          self.cp_rc = compile('\(cherry picked from commit ([0-9a-zA-Z]+)\)')
>          self.bp_rc = compile('\(backported from commit ([0-9a-zA-Z]+) upstream\)')
> 
Applied to kteam-tools. Thanks.

-Stefan

Patch

diff --git a/maintscripts/maint-modify-patch b/maintscripts/maint-modify-patch
index 99673ec0..442919ed 100755
--- a/maintscripts/maint-modify-patch
+++ b/maintscripts/maint-modify-patch
@@ -207,7 +207,7 @@  class ModifyPatch(StdApp):
         self.defaults['list-aliases']     = False
         self.defaults['modify-operation'] = False
         self.defaults['dry-run']          = False
-        self.defaults['buglink_base_url'] = "http://bugs.launchpad.net/bugs/"
+        self.defaults['buglink_base_url'] = "https://bugs.launchpad.net/bugs/"
 
         self.cp_rc = compile('\(cherry picked from commit ([0-9a-zA-Z]+)\)')
         self.bp_rc = compile('\(backported from commit ([0-9a-zA-Z]+) upstream\)')