From patchwork Wed Jun 6 07:02:13 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Rashmica Gupta X-Patchwork-Id: 925757 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 41103m4RcvzB3h4 for ; Wed, 6 Jun 2018 17:02:28 +1000 (AEST) Authentication-Results: ozlabs.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="FNEJMfBs"; dkim-atps=neutral Received: from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3]) by lists.ozlabs.org (Postfix) with ESMTP id 41103m2JgdzF152 for ; Wed, 6 Jun 2018 17:02:28 +1000 (AEST) Authentication-Results: lists.ozlabs.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: lists.ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="FNEJMfBs"; dkim-atps=neutral X-Original-To: pdbg@lists.ozlabs.org Delivered-To: pdbg@lists.ozlabs.org Authentication-Results: lists.ozlabs.org; spf=pass (mailfrom) smtp.mailfrom=gmail.com (client-ip=2607:f8b0:400e:c01::244; helo=mail-pl0-x244.google.com; envelope-from=rashmica.g@gmail.com; receiver=) Authentication-Results: lists.ozlabs.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: lists.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="FNEJMfBs"; dkim-atps=neutral Received: from mail-pl0-x244.google.com (mail-pl0-x244.google.com [IPv6:2607:f8b0:400e:c01::244]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 41103h12QqzDqG0 for ; Wed, 6 Jun 2018 17:02:23 +1000 (AEST) Received: by mail-pl0-x244.google.com with SMTP id c41-v6so3196504plj.10 for ; Wed, 06 Jun 2018 00:02:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id; bh=ZTfbnad89UGenYnrWJtvNw/XcFJHLlj940ZXJqLpoT8=; b=FNEJMfBs2P3i3i98RRYGTdOBmI8dnLhF6Bu69rgq1KSe9IcAMnKnoCG8/ZYT0In8mV JzffgYdZmdk/59YGfoxkHKjIaMAORoZF+5hsbzXEmX4FVVeCdyKGz/nhAQTTTE5gbGMI dJV+4UQYaz8/uo0/p1pqxGIawLGrDHR6oApfQKh2Oi04DdX5cHK8P+WIU4CaXJ3+87+p 4kVtk6H37oG80MFyL20t6AwQQdnrKDGJB805N6MJHLImDOvOjjY6y4JaiMbFUEnJxu1b kxUhyNBhSGnq3Nrs2n3xgGHSCADi2QyUkRP/3jmb4sPYqwkmJBBUsl0DgMJrXkQCqChm 7LUg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=ZTfbnad89UGenYnrWJtvNw/XcFJHLlj940ZXJqLpoT8=; b=s4goM8Jh0Q6bgLNeD/FB2qtTNtP26FZahEKMH0zzpRRfPelEBaRqPe7VGLkaGfgNb5 AEqlVpuU8574Tst3JY9nMFP/YwvdXLFxj0/R+s8UjH+0zFeSSa65vBoyFjRO5clRgOfq T7SgFPc7N18yk/+/XBlHSHH8kcqZ8DtDrsPC6Gt8azoYjlW8n0Zbfwisrfdxd0LZq0Ev WRn+Q2+bQ6TexVTUegUWo8KXxNdKk/EnOjE2jSGvt8/63DPe3yesa2tvcDdw8x0YFLRm lEMBI/duEGnIxaIRuyr+zK2TdbKoAHQguJxd3T10u5d+sTkWoGwexrxAXbMkuxf5Hefm tlMA== X-Gm-Message-State: APt69E1bqKAPwdAr2BmmrsKSNeqB2lNcLAhTKXNeO/rF2BkJCxKHOl1j kx5u9RyrKz0ghw5KMD5oPQji6w== X-Google-Smtp-Source: ADUXVKLi+6uDSmTClN5u9IDynKG+VJB0NwHltfgPOHN6ZoFJczRhbZe5YpPP6ruzEa0q6D7irrciQg== X-Received: by 2002:a17:902:b217:: with SMTP id t23-v6mr2065055plr.312.1528268541993; Wed, 06 Jun 2018 00:02:21 -0700 (PDT) Received: from rashmica.ozlabs.ibm.com ([122.99.82.10]) by smtp.gmail.com with ESMTPSA id s27-v6sm33401694pfk.184.2018.06.06.00.02.19 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Wed, 06 Jun 2018 00:02:21 -0700 (PDT) From: Rashmica Gupta To: pdbg@lists.ozlabs.org Date: Wed, 6 Jun 2018 17:02:13 +1000 Message-Id: <20180606070213.30974-1-rashmica.g@gmail.com> X-Mailer: git-send-email 2.14.4 Subject: [Pdbg] [PATCH] libpdbg: Always fail sreset on p8 X-BeenThere: pdbg@lists.ozlabs.org X-Mailman-Version: 2.1.26 Precedence: list List-Id: "mailing list for https://github.com/open-power/pdbg development" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: pdbg-bounces+incoming=patchwork.ozlabs.org@lists.ozlabs.org Sender: "Pdbg" Currently attempting to do a './pdbg -p x -c x -t x sreset' segfaults as there is no sreset function defined for p8. Apparently we can't easily sreset on p8, so add in function that always fails as this is better than segfaulting. --- libpdbg/p8chip.c | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/libpdbg/p8chip.c b/libpdbg/p8chip.c index 817ef2c..5e3ad97 100644 --- a/libpdbg/p8chip.c +++ b/libpdbg/p8chip.c @@ -283,6 +283,12 @@ static int p8_thread_start(struct thread *thread) return 0; } +static int p8_thread_sreset(struct thread *thread) +{ + /* Broken on p8 */ + return 1; +} + static int p8_ram_setup(struct thread *thread) { struct pdbg_target *target; @@ -432,6 +438,7 @@ static struct thread p8_thread = { .step = p8_thread_step, .start = p8_thread_start, .stop = p8_thread_stop, + .sreset = p8_thread_sreset, .ram_setup = p8_ram_setup, .ram_instruction = p8_ram_instruction, .ram_destroy = p8_ram_destroy,