From patchwork Tue Jun 5 14:37:42 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ilya Maximets X-Patchwork-Id: 925505 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (mailfrom) smtp.mailfrom=openvswitch.org (client-ip=140.211.169.12; helo=mail.linuxfoundation.org; envelope-from=ovs-dev-bounces@openvswitch.org; receiver=) Authentication-Results: ozlabs.org; dmarc=fail (p=none dis=none) header.from=samsung.com Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (1024-bit key; unprotected) header.d=samsung.com header.i=@samsung.com header.b="XRWZA1lV"; dkim-atps=neutral Received: from mail.linuxfoundation.org (mail.linuxfoundation.org [140.211.169.12]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 410ZCz49WWz9s08 for ; Wed, 6 Jun 2018 00:38:07 +1000 (AEST) Received: from mail.linux-foundation.org (localhost [127.0.0.1]) by mail.linuxfoundation.org (Postfix) with ESMTP id AA042C09; Tue, 5 Jun 2018 14:38:04 +0000 (UTC) X-Original-To: ovs-dev@openvswitch.org Delivered-To: ovs-dev@mail.linuxfoundation.org Received: from smtp1.linuxfoundation.org (smtp1.linux-foundation.org [172.17.192.35]) by mail.linuxfoundation.org (Postfix) with ESMTPS id 00C5DAF8 for ; Tue, 5 Jun 2018 14:38:03 +0000 (UTC) X-Greylist: domain auto-whitelisted by SQLgrey-1.7.6 Received: from mailout1.w1.samsung.com (mailout1.w1.samsung.com [210.118.77.11]) by smtp1.linuxfoundation.org (Postfix) with ESMTPS id E3EAA6D8 for ; Tue, 5 Jun 2018 14:38:01 +0000 (UTC) Received: from eucas1p2.samsung.com (unknown [182.198.249.207]) by mailout1.w1.samsung.com (KnoxPortal) with ESMTP id 20180605143759euoutp01e041c409be2783f90b8a432aeea9cbdb~1SmywxBpS0483804838euoutp016; Tue, 5 Jun 2018 14:37:59 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 mailout1.w1.samsung.com 20180605143759euoutp01e041c409be2783f90b8a432aeea9cbdb~1SmywxBpS0483804838euoutp016 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=samsung.com; s=mail20170921; t=1528209479; bh=LdTzXyniM5p/20WeOb5s8zcVpeyXCyzjW+yksmH9Bhg=; h=From:To:Cc:Subject:Date:References:From; b=XRWZA1lVyZ0+ry9YoV0G7bzna++gWjlg4OcwP8/e1K3nxXhA3WURrFwsEagZ4OzQY snck6824/MepIqThMVAEslYOqkpEpCqkM40MmwqYTn8HHUodi1lwaT919U4yF+L+GO E1pWvLVV9dzc9bW15trWRLOs5MROOB5qR4NzgjJI= Received: from eusmges1new.samsung.com (unknown [203.254.199.242]) by eucas1p1.samsung.com (KnoxPortal) with ESMTP id 20180605143757eucas1p1fe2357a53aaa2cb3e836883513d4308e~1Smxhm7Yc1720117201eucas1p1y; Tue, 5 Jun 2018 14:37:57 +0000 (GMT) Received: from eucas1p1.samsung.com ( [182.198.249.206]) by eusmges1new.samsung.com (EUCPMTA) with SMTP id 35.24.05700.440A61B5; Tue, 5 Jun 2018 15:37:56 +0100 (BST) Received: from eusmgms1.samsung.com (unknown [182.198.249.179]) by eucas1p2.samsung.com (KnoxPortal) with ESMTP id 20180605143756eucas1p298c511066165fcfec0726065d5d06d71~1SmvyYla11188811888eucas1p2I; Tue, 5 Jun 2018 14:37:56 +0000 (GMT) X-AuditID: cbfec7f2-5ffe19c000011644-ed-5b16a0446ce4 Received: from eusync3.samsung.com ( [203.254.199.213]) by eusmgms1.samsung.com (EUCPMTA) with SMTP id F6.8F.04178.440A61B5; Tue, 5 Jun 2018 15:37:56 +0100 (BST) Received: from imaximets.rnd.samsung.ru ([106.109.129.180]) by eusync3.samsung.com (Oracle Communications Messaging Server 7.0.5.31.0 64bit (built May 5 2014)) with ESMTPA id <0P9U00I4MTZ1LF70@eusync3.samsung.com>; Tue, 05 Jun 2018 15:37:55 +0100 (BST) From: Ilya Maximets To: ovs-dev@openvswitch.org, Ben Pfaff Date: Tue, 05 Jun 2018 17:37:42 +0300 Message-id: <1528209462-29773-1-git-send-email-i.maximets@samsung.com> X-Mailer: git-send-email 2.7.4 X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFuplkeLIzCtJLcpLzFFi42LZduznOV2XBWLRBgtOm1u8mtzAaDHrUhO7 xZX2n+wWcz89Z7R4f3kviwOrx85Zd9k9nt38z+jx/FoPi0ffllWMASxRXDYpqTmZZalF+nYJ XBlTH65hKvjIUbH60nfGBsbl7F2MnBwSAiYSjy48Zupi5OIQEljBKDFpzmd2COczo8Sfz5tY uxg5wKratltDxJcxSrzZNo8RpFtIoJlJ4tObBBCbTUBH4tTqI2BxEaD6ZVO/sYHYzAJVEntW 3wGzhQWCJdZOPssCYrMIqEr8bXsMFucVcJPoP3uGDeIiOYmb5zqZQZZJCFxllWiceRoq4SJx askCKFtY4tXxLVAvyEh0dhxkgrDrJe63vGSEaO5glJh+6B9Uwl5iy+tz7BAX8UlM2jadGeIz XomONiGIEg+Jnwt/sUM8Fiux58ZixgmMEgsYGVYxiqeWFuempxYb5qWW6xUn5haX5qXrJefn bmIERtLpf8c/7WD8einpEKMAB6MSD++KbrFoIdbEsuLK3EOMEhzMSiK80ycDhXhTEiurUovy 44tKc1KLDzFKc7AoifPGadRFCQmkJ5akZqemFqQWwWSZODilGhijuOx/XPz08/P14/9a0y77 dxy9YKf9+8Ttmx9v/zlyZ1Hg+dp1jwr3cjRltN7/0i3998mKPmNztgXOF3eePBlx44TBiwub Zyc/c30c9/B0rFvrrH2FihfbNqbIpJSms3z6Z3X47I0TAtM/r2a+ofazw/aEdMuEVcpsj1dM i5NS23my60lG0fZqNyWW4oxEQy3mouJEAG6PIQKgAgAA X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFnrAJMWRmVeSWpSXmKPExsVy+t/xq7ouC8SiDdZ9ZbR4NbmB0WLWpSZ2 iyvtP9kt5n56zmjx/vJeFgdWj52z7rJ7PLv5n9Hj+bUeFo++LasYA1iiuGxSUnMyy1KL9O0S uDKmPlzDVPCRo2L1pe+MDYzL2bsYOTgkBEwk2rZbdzFycQgJLGGUWD3hGDuE08okcavjDVsX IycHm4COxKnVRxhBbBGghmVTv4HFmQWqJG4s+8AKYgsLBEusnXyWBcRmEVCV+Nv2GKyGV8BN ov/sGTBbQkBO4ua5TuYJjFwLGBlWMYqklhbnpucWG+oVJ+YWl+al6yXn525iBPp727Gfm3cw XtoYfIhRgINRiYd3RbdYtBBrYllxZe4hRgkOZiUR3umTgUK8KYmVValF+fFFpTmpxYcYpTlY lMR5zxtURgkJpCeWpGanphakFsFkmTg4pRoY6778Orq5Ycb2vMKd+23XFJfMm8fXZ3TpI8Oz uxe5i7aJ8LjeXVORcomb/1vr+9Dtm9b2C1l8TZqxUTZa5cSx68sv53b1rshPPGISlStk9DJA 7f76JVmnare2XsxlNL7DXv+H8X1+i2to47f52/JeBgUs8w96dej5kQffUt13xtSsXjnj1zWz PUosxRmJhlrMRcWJACAT4CPzAQAA X-CMS-MailID: 20180605143756eucas1p298c511066165fcfec0726065d5d06d71 X-Msg-Generator: CA CMS-TYPE: 201P X-CMS-RootMailID: 20180605143756eucas1p298c511066165fcfec0726065d5d06d71 References: X-Spam-Status: No, score=-7.0 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on smtp1.linux-foundation.org Cc: Ilya Maximets , Ivan Dyukov Subject: [ovs-dev] [PATCH] tests/stp: Make validation of flows before changing of topology. X-BeenThere: ovs-dev@openvswitch.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Sender: ovs-dev-bounces@openvswitch.org Errors-To: ovs-dev-bounces@openvswitch.org From: Ivan Dyukov The change fixes random stp test failure. Accuracy is about 20%. Failed test is following: 2337: STP - flush the fdb and mdb when topology changed In some cases, a validation is executed after topology change and it increase time of stp stabilization. To prevent this, delay which wait validation is added before deleting a port. CC: Tonghao Zhang Fixes: 427e9751f300 ("tests: Add and improve stp tests.") Signed-off-by: Ivan Dyukov --- tests/stp.at | 3 +++ 1 file changed, 3 insertions(+) diff --git a/tests/stp.at b/tests/stp.at index 9550f72..8a0a868 100644 --- a/tests/stp.at +++ b/tests/stp.at @@ -562,6 +562,9 @@ OVS_WAIT_UNTIL([ovs-appctl mdb/show br0 | grep 'querier']) OVS_WAIT_UNTIL([ovs-appctl mdb/show br1 | grep 'querier']) OVS_WAIT_UNTIL([ovs-appctl mdb/show br2 | grep 'querier']) +# Make sure that validation of flows was before changing of topology. +ovs-appctl revalidator/wait + # del p2 on the br0, the topology will be changed AT_CHECK([ovs-vsctl del-port br0 p2])