diff mbox series

[1/1] skeleton: PAGER without blank and unset at end of for loop

Message ID 20180605134745.24435-1-F.LaRoche@pilz.de
State Accepted
Headers show
Series [1/1] skeleton: PAGER without blank and unset at end of for loop | expand

Commit Message

Florian La Roche June 5, 2018, 1:47 p.m. UTC
The PAGER environment variable is including a blank character at the
end. Remove this.
A for loop has been unsetting the variable inside the loop, this is only
needed once at the end of the loop.

Signed-off-by: Florian La Roche <F.LaRoche@pilz.de>
---
 system/skeleton/etc/profile | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Comments

Thomas Petazzoni June 5, 2018, 4:51 p.m. UTC | #1
Hello,

On Tue, 5 Jun 2018 15:47:45 +0200, Florian La Roche wrote:
> The PAGER environment variable is including a blank character at the
> end. Remove this.
> A for loop has been unsetting the variable inside the loop, this is only
> needed once at the end of the loop.
> 
> Signed-off-by: Florian La Roche <F.LaRoche@pilz.de>
> ---
>  system/skeleton/etc/profile | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)

Applied to master, thanks.

Thomas
Peter Korsgaard June 17, 2018, 3:50 p.m. UTC | #2
>>>>> "Florian" == Florian La Roche <F.LaRoche@pilz.de> writes:

 > The PAGER environment variable is including a blank character at the
 > end. Remove this.
 > A for loop has been unsetting the variable inside the loop, this is only
 > needed once at the end of the loop.

 > Signed-off-by: Florian La Roche <F.LaRoche@pilz.de>

Committed to 2018.02.x, thanks.
diff mbox series

Patch

diff --git a/system/skeleton/etc/profile b/system/skeleton/etc/profile
index 3a97427fdf..1255d23ff4 100644
--- a/system/skeleton/etc/profile
+++ b/system/skeleton/etc/profile
@@ -8,7 +8,7 @@  if [ "$PS1" ]; then
 	fi
 fi
 
-export PAGER='/bin/more '
+export PAGER='/bin/more'
 export EDITOR='/bin/vi'
 
 # Source configuration files from /etc/profile.d
@@ -16,5 +16,5 @@  for i in /etc/profile.d/*.sh ; do
 	if [ -r "$i" ]; then
 		. $i
 	fi
-	unset i
 done
+unset i