From patchwork Tue Jun 5 07:13:36 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Joel Stanley X-Patchwork-Id: 925327 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 410NNY3L7hz9s0W for ; Tue, 5 Jun 2018 17:14:53 +1000 (AEST) Authentication-Results: ozlabs.org; dmarc=none (p=none dis=none) header.from=jms.id.au Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="XCdOJwi5"; dkim-atps=neutral Received: from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3]) by lists.ozlabs.org (Postfix) with ESMTP id 410NNY1mylzF1wt for ; Tue, 5 Jun 2018 17:14:53 +1000 (AEST) Authentication-Results: lists.ozlabs.org; dmarc=none (p=none dis=none) header.from=jms.id.au Authentication-Results: lists.ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="XCdOJwi5"; dkim-atps=neutral X-Original-To: skiboot@lists.ozlabs.org Delivered-To: skiboot@lists.ozlabs.org Authentication-Results: lists.ozlabs.org; spf=pass (mailfrom) smtp.mailfrom=gmail.com (client-ip=2607:f8b0:400e:c01::22a; helo=mail-pl0-x22a.google.com; envelope-from=joel.stan@gmail.com; receiver=) Authentication-Results: lists.ozlabs.org; dmarc=none (p=none dis=none) header.from=jms.id.au Authentication-Results: lists.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="XCdOJwi5"; dkim-atps=neutral Received: from mail-pl0-x22a.google.com (mail-pl0-x22a.google.com [IPv6:2607:f8b0:400e:c01::22a]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 410NMm2dypzF1kw for ; Tue, 5 Jun 2018 17:14:12 +1000 (AEST) Received: by mail-pl0-x22a.google.com with SMTP id g20-v6so977853plq.1 for ; Tue, 05 Jun 2018 00:14:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references; bh=UWbazarCcwLjZ2DjHVnbIROb2emybdaQmwV0NweD83I=; b=XCdOJwi5z75OQJg34elQtCvPNTq4Q2SU/9Gv9hrBUhuUoCBUfbLzvUf4SnZF63KVud 395LtNa07yrhYjOVk3+g7I7f0LnIzZ4G0ckbkYrj6QeRP+j66mwgm/LwYRWn+ovkFwvF QVl/M8SoNW9HxHhUv2XeO9wGtV3u+rsVBawhBZfVpIZYtScIl96ID4CM11358MTldAL1 gzctS30eUoi3YOVSGhQ1V2I1vB+mVCq8zgkepsT+UjOAUX8xNsWfaazL0G9aUHAdiDWM s3Y7z3A9cpPvNDw1odPXVnaUpV2EZtHPCYXazXggis+T2sMoNOresWWT9zYzTbzoOU3G 7Ocg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references; bh=UWbazarCcwLjZ2DjHVnbIROb2emybdaQmwV0NweD83I=; b=K141e3QnUNalylDFw+cA2HYwXrUlmcH3VnYHo2+1KDfrHrq+Zfvw9aU7AzapVxGHBL +O+rVuS2vypU0M9WoSed5QPvOuPWcg9MBBj0pvPCJLPpFPi4FKM/LrM8rR6xnESMbuib m2Urw0GC9RLCva7g++Rq3c0iA8qYP5kH+Aal+JVsUxKST79ozUcJOV99GmAXFxEuKQr/ A7F+MalstMLqZkI37TtmkbYy5rU9sSEXIVugmo9Pie6NZObT5zWf0krObQG02GvysBoK PP6QpLqbSptZR9KvNw7d3uCbCp3ciMjE+ywz3Zz8i2/5GaEKwPuLOK098KllpOahe5s7 ZI+A== X-Gm-Message-State: ALKqPwelKhy7JTYgFIYW3/9AiOeVdYRnFFMNi8Nl3A9KRxmZsygJaDCk tvDOGcTyQcV1oN35f70YgEtLwwCd X-Google-Smtp-Source: ADUXVKIteS2blLXaGr1COT9B+YuOV5kNhFvleJ8R6m3t0QA6cM1p57eRSeRp5vLfbeGAoQfIEAsKmw== X-Received: by 2002:a17:902:b195:: with SMTP id s21-v6mr19327813plr.202.1528182849809; Tue, 05 Jun 2018 00:14:09 -0700 (PDT) Received: from aurora.jms.id.au ([203.0.153.9]) by smtp.gmail.com with ESMTPSA id u19-v6sm62668219pgv.25.2018.06.05.00.14.07 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 05 Jun 2018 00:14:09 -0700 (PDT) Received: by aurora.jms.id.au (sSMTP sendmail emulation); Tue, 05 Jun 2018 16:44:03 +0930 From: Joel Stanley To: skiboot@lists.ozlabs.org Date: Tue, 5 Jun 2018 16:43:36 +0930 Message-Id: <20180605071337.22915-4-joel@jms.id.au> X-Mailer: git-send-email 2.17.0 In-Reply-To: <20180605071337.22915-1-joel@jms.id.au> References: <20180605071337.22915-1-joel@jms.id.au> Subject: [Skiboot] [PATCH 3/4] hdata: Remove hn variable where it is unused X-BeenThere: skiboot@lists.ozlabs.org X-Mailman-Version: 2.1.26 Precedence: list List-Id: Mailing list for skiboot development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: skiboot-bounces+incoming=patchwork.ozlabs.org@lists.ozlabs.org Sender: "Skiboot" Whatever this was used for appears to pre-date the public release of skiboot. Found using scan-build. Signed-off-by: Joel Stanley --- hdata/iohub.c | 11 +++++------ 1 file changed, 5 insertions(+), 6 deletions(-) diff --git a/hdata/iohub.c b/hdata/iohub.c index 1630d2a8be32..f37f5abf31c8 100644 --- a/hdata/iohub.c +++ b/hdata/iohub.c @@ -848,7 +848,6 @@ static void io_parse_slots(const struct HDIF_common_hdr *sp_iohubs, int hub_id) static void io_parse_fru(const void *sp_iohubs) { unsigned int i; - struct dt_node *hn; int count; count = HDIF_get_iarray_size(sp_iohubs, CECHUB_FRU_IO_HUBS); @@ -863,6 +862,7 @@ static void io_parse_fru(const void *sp_iohubs) for (i = 0; i < count; i++) { const struct cechub_io_hub *hub; unsigned int size, hub_id; + struct dt_node *hn; uint32_t chip_id; hub = HDIF_get_iarray_item(sp_iohubs, CECHUB_FRU_IO_HUBS, @@ -906,26 +906,25 @@ static void io_parse_fru(const void *sp_iohubs) case CECHUB_HUB_MURANO: case CECHUB_HUB_MURANO_SEGU: prlog(PR_INFO, "CEC: Murano !\n"); - hn = io_add_p8(hub, sp_iohubs); + io_add_p8(hub, sp_iohubs); break; case CECHUB_HUB_VENICE_WYATT: prlog(PR_INFO, "CEC: Venice !\n"); - hn = io_add_p8(hub, sp_iohubs); + io_add_p8(hub, sp_iohubs); break; case CECHUB_HUB_NIMBUS_SFORAZ: case CECHUB_HUB_NIMBUS_MONZA: case CECHUB_HUB_NIMBUS_LAGRANGE: prlog(PR_INFO, "CEC: Nimbus !\n"); - hn = io_add_p9(hub, sp_iohubs); + io_add_p9(hub, sp_iohubs); break; case CECHUB_HUB_CUMULUS_DUOMO: prlog(PR_INFO, "CEC: Cumulus !\n"); - hn = io_add_p9(hub, sp_iohubs); + io_add_p9(hub, sp_iohubs); break; default: prlog(PR_ERR, "CEC: Hub ID 0x%04x unsupported !\n", hub_id); - hn = NULL; } chip_id = pcid_to_chip_id(be32_to_cpu(hub->proc_chip_id));