| Submitter | Fernando Luis Vázquez Cao |
|---|---|
| Date | April 22, 2011, 7:02 a.m. |
| Message ID | <1303455759.2023.39.camel@nausicaa> |
| Download | mbox | patch |
| Permalink | /patch/92504/ |
| State | Not Applicable |
| Delegated to: | David Miller |
| Headers | show |
Comments
On Fri, 2011-04-22 at 00:08 -0700, David Miller wrote: > From: Fernando Luis Vazquez Cao <fernando@oss.ntt.co.jp> > Date: Fri, 22 Apr 2011 16:02:39 +0900 > > > The mask indicates the bits one wants to zero out, so it needs to be > > inverted before applying to the original TOS field. > > > > Signed-off-by: Fernando Luis Vazquez Cao <fernando@oss.ntt.co.jp> > > --- > > Netfilter patches should be sent to the netfilter developer > list, CC:'d Thank you for the heads-up, David. By the way, I have just sent one more patch that fixes what I think is another netfilter bug. If everyone is ok with these two patches it would be great if we could get them merged for the next -rc release (we hit these bugs in our production systems). Regards, Fernando -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Patch
diff -urNp linux-2.6.37-orig/net/netfilter/xt_DSCP.c linux-2.6.37/net/netfilter/xt_DSCP.c --- linux-2.6.37-orig/net/netfilter/xt_DSCP.c 2011-01-05 09:50:19.000000000 +0900 +++ linux-2.6.37/net/netfilter/xt_DSCP.c 2011-04-21 16:01:25.801890733 +0900 @@ -99,7 +99,7 @@ tos_tg6(struct sk_buff *skb, const struc u_int8_t orig, nv; orig = ipv6_get_dsfield(iph); - nv = (orig & info->tos_mask) ^ info->tos_value; + nv = (orig & ~info->tos_mask) ^ info->tos_value; if (orig != nv) { if (!skb_make_writable(skb, sizeof(struct iphdr)))
The mask indicates the bits one wants to zero out, so it needs to be inverted before applying to the original TOS field. Signed-off-by: Fernando Luis Vazquez Cao <fernando@oss.ntt.co.jp> --- -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html