Patchwork Allow more PowerPC sibling calls

login
register
mail settings
Submitter Alan Modra
Date April 22, 2011, 4:20 a.m.
Message ID <20110422042027.GO19947@bubble.grove.modra.org>
Download mbox | patch
Permalink /patch/92499/
State New
Headers show

Comments

Alan Modra - April 22, 2011, 4:20 a.m.
On Fri, Apr 22, 2011 at 01:29:14PM +0930, Alan Modra wrote:
> On Mon, Apr 18, 2011 at 10:29:17AM -0700, Nathan Froyd wrote:
> > Could I request that you use FOREACH_FUNCTION_ARGS in these two cases?
> > The conversion is trivial, and avoiding more exposed TYPE_ARG_TYPES
> > calls is a good thing.
> 
> Committed revision 172855.

Oops, I missed the following hunk, which I talked about here

> I also fixed a minor problem with CALL_LIBCALL in the call
> cookie, which could cause various call insns to match an "n"
> constraint rather than a "0" constraint and so give the wrong insn
> length.

and mentioned in the changelog:

>	* config/rs6000/rs6000.c (rs6000_function_arg): Remove CALL_LIBCALL
>	when returning call_cookie.

but failed to include in my post.  Committed as obvious, revision 172856.

Patch

Index: gcc/config/rs6000/rs6000.c
===================================================================
--- gcc/config/rs6000/rs6000.c	(revision 172855)
+++ gcc/config/rs6000/rs6000.c	(working copy)
@@ -9007,7 +9007,7 @@  rs6000_function_arg (CUMULATIVE_ARGS *cu
 			       : CALL_V4_CLEAR_FP_ARGS));
 	}
 
-      return GEN_INT (cum->call_cookie);
+      return GEN_INT (cum->call_cookie & ~CALL_LIBCALL);
     }
 
   if (TARGET_MACHO && rs6000_darwin64_struct_check_p (mode, type))