| Message ID | 20180604070306epcas1p1818d82cea7d63b04880e36b3fca11e93~04wWB-T6F1784217842epcas1p1l@epcas1p1.samsung.com |
|---|---|
| State | Accepted |
| Commit | 5c890b1bc85af5cfb05916e360dc2919ec18ac12 |
| Delegated to: | Tom Rini |
| Headers | show |
| Series | [U-Boot,1/3] gadget: f_thor: fix hang-up with ctrl-c | expand |
Hi, 2018년 6월 4일 (월) 16:03, Seung-Woo Kim <sw0312.kim@samsung.com>님이 작성: > After the commit 9b643e312d52 ("treewide: replace with error() with > pr_err()"), there are some pr_err() with no line break. Add missing > line breaks. > > Signed-off-by: Seung-Woo Kim <sw0312.kim@samsung.com> > --- > board/samsung/common/exynos5-dt.c | 2 +- > board/samsung/common/misc.c | 2 +- > board/samsung/odroid/odroid.c | 12 ++++++------ > 3 files changed, 8 insertions(+), 8 deletions(-) > > diff --git a/board/samsung/common/exynos5-dt.c > b/board/samsung/common/exynos5-dt.c > index 9f6f654..8c3a9ea 100644 > --- a/board/samsung/common/exynos5-dt.c > +++ b/board/samsung/common/exynos5-dt.c > @@ -164,7 +164,7 @@ int board_usb_init(int index, enum usb_init_type init) > samsung_get_base_usb3_phy(); > > if (!phy) { > - pr_err("usb3 phy not supported"); > + pr_err("usb3 phy not supported\n"); > return -ENODEV; > } > > diff --git a/board/samsung/common/misc.c b/board/samsung/common/misc.c > index c9df7e6..05243fc 100644 > --- a/board/samsung/common/misc.c > +++ b/board/samsung/common/misc.c > @@ -456,7 +456,7 @@ void draw_logo(void) > > addr = panel_info.logo_addr; > if (!addr) { > - pr_err("There is no logo data."); > + pr_err("There is no logo data.\n"); > return; > } > > diff --git a/board/samsung/odroid/odroid.c b/board/samsung/odroid/odroid.c > index 1c2bd01..552333f 100644 > --- a/board/samsung/odroid/odroid.c > +++ b/board/samsung/odroid/odroid.c > @@ -428,7 +428,7 @@ int exynos_power_init(void) > }; > > if (regulator_list_autoset(mmc_regulators, NULL, true)) > - pr_err("Unable to init all mmc regulators"); > + pr_err("Unable to init all mmc regulators\n"); > > return 0; > } > @@ -441,7 +441,7 @@ static int s5pc210_phy_control(int on) > > ret = regulator_get_by_platname("VDD_UOTG_3.0V", &dev); > if (ret) { > - pr_err("Regulator get error: %d", ret); > + pr_err("Regulator get error: %d\n", ret); > return ret; > } > > @@ -486,25 +486,25 @@ int board_usb_init(int index, enum usb_init_type > init) > > ret = regulator_get_by_platname("VCC_P3V3_2.85V", &dev); > if (ret) { > - pr_err("Regulator get error: %d", ret); > + pr_err("Regulator get error: %d\n", ret); > return ret; > } > > ret = regulator_set_enable(dev, true); > if (ret) { > - pr_err("Regulator %s enable setting error: %d", dev->name, > ret); > + pr_err("Regulator %s enable setting error: %d\n", > dev->name, ret); > return ret; > } > > ret = regulator_set_value(dev, 750000); > if (ret) { > - pr_err("Regulator %s value setting error: %d", dev->name, > ret); > + pr_err("Regulator %s value setting error: %d\n", > dev->name, ret); > return ret; > } > > ret = regulator_set_value(dev, 3300000); > if (ret) { > - pr_err("Regulator %s value setting error: %d", dev->name, > ret); > + pr_err("Regulator %s value setting error: %d\n", > dev->name, ret); > return ret; > } > #endif > -- > 1.7.9.5 > > _______________________________________________ > U-Boot mailing list > U-Boot@lists.denx.de > https://lists.denx.de/listinfo/u-boot Reviewed-by: Minkyu Kang <mk7.kang@samsung.com> Thanks, Minkyu Kang.
On Mon, Jun 04, 2018 at 04:03:05PM +0900, Seung-Woo Kim wrote: > After the commit 9b643e312d52 ("treewide: replace with error() with > pr_err()"), there are some pr_err() with no line break. Add missing > line breaks. > > Signed-off-by: Seung-Woo Kim <sw0312.kim@samsung.com> > Reviewed-by: Minkyu Kang <mk7.kang@samsung.com> Applied to u-boot/master, thanks!
diff --git a/board/samsung/common/exynos5-dt.c b/board/samsung/common/exynos5-dt.c index 9f6f654..8c3a9ea 100644 --- a/board/samsung/common/exynos5-dt.c +++ b/board/samsung/common/exynos5-dt.c @@ -164,7 +164,7 @@ int board_usb_init(int index, enum usb_init_type init) samsung_get_base_usb3_phy(); if (!phy) { - pr_err("usb3 phy not supported"); + pr_err("usb3 phy not supported\n"); return -ENODEV; } diff --git a/board/samsung/common/misc.c b/board/samsung/common/misc.c index c9df7e6..05243fc 100644 --- a/board/samsung/common/misc.c +++ b/board/samsung/common/misc.c @@ -456,7 +456,7 @@ void draw_logo(void) addr = panel_info.logo_addr; if (!addr) { - pr_err("There is no logo data."); + pr_err("There is no logo data.\n"); return; } diff --git a/board/samsung/odroid/odroid.c b/board/samsung/odroid/odroid.c index 1c2bd01..552333f 100644 --- a/board/samsung/odroid/odroid.c +++ b/board/samsung/odroid/odroid.c @@ -428,7 +428,7 @@ int exynos_power_init(void) }; if (regulator_list_autoset(mmc_regulators, NULL, true)) - pr_err("Unable to init all mmc regulators"); + pr_err("Unable to init all mmc regulators\n"); return 0; } @@ -441,7 +441,7 @@ static int s5pc210_phy_control(int on) ret = regulator_get_by_platname("VDD_UOTG_3.0V", &dev); if (ret) { - pr_err("Regulator get error: %d", ret); + pr_err("Regulator get error: %d\n", ret); return ret; } @@ -486,25 +486,25 @@ int board_usb_init(int index, enum usb_init_type init) ret = regulator_get_by_platname("VCC_P3V3_2.85V", &dev); if (ret) { - pr_err("Regulator get error: %d", ret); + pr_err("Regulator get error: %d\n", ret); return ret; } ret = regulator_set_enable(dev, true); if (ret) { - pr_err("Regulator %s enable setting error: %d", dev->name, ret); + pr_err("Regulator %s enable setting error: %d\n", dev->name, ret); return ret; } ret = regulator_set_value(dev, 750000); if (ret) { - pr_err("Regulator %s value setting error: %d", dev->name, ret); + pr_err("Regulator %s value setting error: %d\n", dev->name, ret); return ret; } ret = regulator_set_value(dev, 3300000); if (ret) { - pr_err("Regulator %s value setting error: %d", dev->name, ret); + pr_err("Regulator %s value setting error: %d\n", dev->name, ret); return ret; } #endif
After the commit 9b643e312d52 ("treewide: replace with error() with pr_err()"), there are some pr_err() with no line break. Add missing line breaks. Signed-off-by: Seung-Woo Kim <sw0312.kim@samsung.com> --- board/samsung/common/exynos5-dt.c | 2 +- board/samsung/common/misc.c | 2 +- board/samsung/odroid/odroid.c | 12 ++++++------ 3 files changed, 8 insertions(+), 8 deletions(-)