diff mbox series

[U-Boot,04/13] x86: cougarcanyon2: Remove CONFIG_HAVE_INTEL_ME

Message ID 1528077866-2850-5-git-send-email-bmeng.cn@gmail.com
State Accepted
Commit fb05f0b02b01aed48db48f02a15e52c6de2d0dac
Delegated to: Bin Meng
Headers show
Series x86: ivybridge: cougarcanyon2: Various enhancements | expand

Commit Message

Bin Meng June 4, 2018, 2:04 a.m. UTC
As README.x86 already mentions, there are two SPI flashes mounted
on Intel Cougar Canyon 2 board, called SPI-0 and SPI-1 respectively.
SPI-0 stores the flash descriptor and the ME firmware. SPI-1 stores
the actual BIOS image which is U-Boot. Building a single image with
both ME firmware and U-Boot does not make sense.

This also describes the exact flash location where the u-boot.rom
should be programmed in the documentation.

Signed-off-by: Bin Meng <bmeng.cn@gmail.com>
---

 configs/cougarcanyon2_defconfig | 1 +
 doc/README.x86                  | 4 +++-
 2 files changed, 4 insertions(+), 1 deletion(-)

Comments

Simon Glass June 7, 2018, 8:31 p.m. UTC | #1
On 3 June 2018 at 18:04, Bin Meng <bmeng.cn@gmail.com> wrote:
> As README.x86 already mentions, there are two SPI flashes mounted
> on Intel Cougar Canyon 2 board, called SPI-0 and SPI-1 respectively.
> SPI-0 stores the flash descriptor and the ME firmware. SPI-1 stores
> the actual BIOS image which is U-Boot. Building a single image with
> both ME firmware and U-Boot does not make sense.
>
> This also describes the exact flash location where the u-boot.rom
> should be programmed in the documentation.
>
> Signed-off-by: Bin Meng <bmeng.cn@gmail.com>
> ---
>
>  configs/cougarcanyon2_defconfig | 1 +
>  doc/README.x86                  | 4 +++-
>  2 files changed, 4 insertions(+), 1 deletion(-)

Reviewed-by: Simon Glass <sjg@chromium.org>
Bin Meng June 12, 2018, 1:53 a.m. UTC | #2
On Fri, Jun 8, 2018 at 4:31 AM, Simon Glass <sjg@chromium.org> wrote:
> On 3 June 2018 at 18:04, Bin Meng <bmeng.cn@gmail.com> wrote:
>> As README.x86 already mentions, there are two SPI flashes mounted
>> on Intel Cougar Canyon 2 board, called SPI-0 and SPI-1 respectively.
>> SPI-0 stores the flash descriptor and the ME firmware. SPI-1 stores
>> the actual BIOS image which is U-Boot. Building a single image with
>> both ME firmware and U-Boot does not make sense.
>>
>> This also describes the exact flash location where the u-boot.rom
>> should be programmed in the documentation.
>>
>> Signed-off-by: Bin Meng <bmeng.cn@gmail.com>
>> ---
>>
>>  configs/cougarcanyon2_defconfig | 1 +
>>  doc/README.x86                  | 4 +++-
>>  2 files changed, 4 insertions(+), 1 deletion(-)
>
> Reviewed-by: Simon Glass <sjg@chromium.org>

applied to u-boot-x86, thanks!
diff mbox series

Patch

diff --git a/configs/cougarcanyon2_defconfig b/configs/cougarcanyon2_defconfig
index 6c79b77..04ad232 100644
--- a/configs/cougarcanyon2_defconfig
+++ b/configs/cougarcanyon2_defconfig
@@ -3,6 +3,7 @@  CONFIG_SYS_TEXT_BASE=0xFFE00000
 CONFIG_VENDOR_INTEL=y
 CONFIG_DEFAULT_DEVICE_TREE="cougarcanyon2"
 CONFIG_TARGET_COUGARCANYON2=y
+# CONFIG_HAVE_INTEL_ME is not set
 # CONFIG_ENABLE_MRC_CACHE is not set
 CONFIG_USE_BOOTARGS=y
 CONFIG_BOOTARGS="root=/dev/sdb3 init=/sbin/init rootwait ro"
diff --git a/doc/README.x86 b/doc/README.x86
index 04f0220..78664c3 100644
--- a/doc/README.x86
+++ b/doc/README.x86
@@ -256,7 +256,9 @@  the board manual. The SPI-0 flash should have flash descriptor plus ME firmware
 and SPI-1 flash is used to store U-Boot. For convenience, the complete 8MB SPI-0
 flash image is included in the FSP package (named Rom00_8M_MB_PPT.bin). Program
 this image to the SPI-0 flash according to the board manual just once and we are
-all set. For programming U-Boot we just need to program SPI-1 flash.
+all set. For programming U-Boot we just need to program SPI-1 flash. Since the
+default u-boot.rom image for this board is set to 2MB, it should be programmed
+to the last 2MB of the 8MB chip, address range [600000, 7FFFFF].
 
 ---