| Message ID | 1528009574-63306-2-git-send-email-paulb@mellanox.com |
|---|---|
| State | Accepted, archived |
| Delegated to: | David Miller |
| Headers | show |
| Series | None | expand |
On Sun, Jun 03, 2018 at 10:06:14AM +0300, Paul Blakey wrote: > We incorrectly compare the mask and the result is that we can't modify > an already existing rule. > > Fix that by comparing correctly. > > Fixes: 05cd271fd61a ("cls_flower: Support multiple masks per priority") > Reported-by: Vlad Buslov <vladbu@mellanox.com> > Reviewed-by: Roi Dayan <roid@mellanox.com> > Reviewed-by: Jiri Pirko <jiri@mellanox.com> > Signed-off-by: Paul Blakey <paulb@mellanox.com> Reviewed-by: Simon Horman <simon.horman@netronome.com>
From: Paul Blakey <paulb@mellanox.com> Date: Sun, 3 Jun 2018 10:06:14 +0300 > We incorrectly compare the mask and the result is that we can't modify > an already existing rule. > > Fix that by comparing correctly. > > Fixes: 05cd271fd61a ("cls_flower: Support multiple masks per priority") > Reported-by: Vlad Buslov <vladbu@mellanox.com> > Reviewed-by: Roi Dayan <roid@mellanox.com> > Reviewed-by: Jiri Pirko <jiri@mellanox.com> > Signed-off-by: Paul Blakey <paulb@mellanox.com> Applied.
diff --git a/net/sched/cls_flower.c b/net/sched/cls_flower.c index 159efd9..2b5be42 100644 --- a/net/sched/cls_flower.c +++ b/net/sched/cls_flower.c @@ -877,7 +877,7 @@ static int fl_check_assign_mask(struct cls_fl_head *head, return PTR_ERR(newmask); fnew->mask = newmask; - } else if (fold && fold->mask == fnew->mask) { + } else if (fold && fold->mask != fnew->mask) { return -EINVAL; }
We incorrectly compare the mask and the result is that we can't modify an already existing rule. Fix that by comparing correctly. Fixes: 05cd271fd61a ("cls_flower: Support multiple masks per priority") Reported-by: Vlad Buslov <vladbu@mellanox.com> Reviewed-by: Roi Dayan <roid@mellanox.com> Reviewed-by: Jiri Pirko <jiri@mellanox.com> Signed-off-by: Paul Blakey <paulb@mellanox.com> --- Changelog: v0 -> v2: rebased. net/sched/cls_flower.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)