Patchwork [revised,v2] sparc32: avoid build warning at mm/percpu.c:1647

login
register
mail settings
Submitter Sam Ravnborg
Date April 21, 2011, 6:35 p.m.
Message ID <20110421183556.GA27199@merkur.ravnborg.org>
Download mbox | patch
Permalink /patch/92435/
State Accepted
Delegated to: David Miller
Headers show

Comments

Sam Ravnborg - April 21, 2011, 6:35 p.m.
Fix following warning:

mm/percpu.c: In function 'pcpu_embed_first_chunk':
mm/percpu.c:1647:3: warning: format '%lx' expects type 'long unsigned int', but argument 3 has type 'unsigned int'

Signed-off-by: Daniel Hellstrom <daniel@gaisler.com>
[sam: added warning message to changelog, use _AC()]
Signed-off-by: Sam Ravnborg <sam@ravnborg.org>
---

Use _AC() as pointed out.
Build tested. 

	Sam

--
To unsubscribe from this list: send the line "unsubscribe sparclinux" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
David Miller - April 21, 2011, 10:48 p.m.
From: Sam Ravnborg <sam@ravnborg.org>
Date: Thu, 21 Apr 2011 20:35:56 +0200

> Fix following warning:
> 
> mm/percpu.c: In function 'pcpu_embed_first_chunk':
> mm/percpu.c:1647:3: warning: format '%lx' expects type 'long unsigned int', but argument 3 has type 'unsigned int'
> 
> Signed-off-by: Daniel Hellstrom <daniel@gaisler.com>
> [sam: added warning message to changelog, use _AC()]
> Signed-off-by: Sam Ravnborg <sam@ravnborg.org>

Applied to sparc-next-2.6, thanks.
--
To unsubscribe from this list: send the line "unsubscribe sparclinux" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Sam Ravnborg - April 22, 2011, 7:41 a.m.
On Thu, Apr 21, 2011 at 03:48:49PM -0700, David Miller wrote:
> From: Sam Ravnborg <sam@ravnborg.org>
> Date: Thu, 21 Apr 2011 20:35:56 +0200
> 
> > Fix following warning:
> > 
> > mm/percpu.c: In function 'pcpu_embed_first_chunk':
> > mm/percpu.c:1647:3: warning: format '%lx' expects type 'long unsigned int', but argument 3 has type 'unsigned int'
> > 
> > Signed-off-by: Daniel Hellstrom <daniel@gaisler.com>
> > [sam: added warning message to changelog, use _AC()]
> > Signed-off-by: Sam Ravnborg <sam@ravnborg.org>
> 
> Applied to sparc-next-2.6, thanks.

I screwed up author-ship on this one - Daniel was the original author.
But I guess Daniel and I can fix this over a beer if we meet someday.
Will try to be more carefull in the future!

	Sam
--
To unsubscribe from this list: send the line "unsubscribe sparclinux" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Daniel Hellstrom - April 22, 2011, 8:17 a.m.
Sam Ravnborg wrote:

>On Thu, Apr 21, 2011 at 03:48:49PM -0700, David Miller wrote:
>  
>
>>From: Sam Ravnborg <sam@ravnborg.org>
>>Date: Thu, 21 Apr 2011 20:35:56 +0200
>>
>>    
>>
>>>Fix following warning:
>>>
>>>mm/percpu.c: In function 'pcpu_embed_first_chunk':
>>>mm/percpu.c:1647:3: warning: format '%lx' expects type 'long unsigned int', but argument 3 has type 'unsigned int'
>>>
>>>Signed-off-by: Daniel Hellstrom <daniel@gaisler.com>
>>>[sam: added warning message to changelog, use _AC()]
>>>Signed-off-by: Sam Ravnborg <sam@ravnborg.org>
>>>      
>>>
>>Applied to sparc-next-2.6, thanks.
>>    
>>
>
>I screwed up author-ship on this one - Daniel was the original author.
>But I guess Daniel and I can fix this over a beer if we meet someday.
>Will try to be more carefull in the future!
>  
>
I think we have to meet in Germany in order to get a big beer enough to 
compensate for that... :) by the way thanks for cleaning up the patch 
for me.

Daniel
--
To unsubscribe from this list: send the line "unsubscribe sparclinux" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Patch

diff --git a/arch/sparc/include/asm/pgtable_32.h b/arch/sparc/include/asm/pgtable_32.h
index 303bd4d..5b31a8e 100644
--- a/arch/sparc/include/asm/pgtable_32.h
+++ b/arch/sparc/include/asm/pgtable_32.h
@@ -8,6 +8,8 @@ 
  *  Copyright (C) 1998 Jakub Jelinek (jj@sunsite.mff.cuni.cz)
  */
 
+#include <linux/const.h>
+
 #ifndef __ASSEMBLY__
 #include <asm-generic/4level-fixup.h>
 
@@ -456,9 +458,9 @@  extern int io_remap_pfn_range(struct vm_area_struct *vma,
 
 #endif /* !(__ASSEMBLY__) */
 
-#define VMALLOC_START           0xfe600000
+#define VMALLOC_START           _AC(0xfe600000,UL)
 /* XXX Alter this when I get around to fixing sun4c - Anton */
-#define VMALLOC_END             0xffc00000
+#define VMALLOC_END             _AC(0xffc00000,UL)
 
 
 /* We provide our own get_unmapped_area to cope with VA holes for userland */