| Message ID | 4DB03586.3040702@absence.it |
|---|---|
| State | Not Applicable, archived |
| Delegated to: | David Miller |
| Headers | show |
On Thu, 2011-04-21 at 15:47 +0200, Marco Chiappero wrote: > Il 21/04/2011 10:28, Marco Chiappero ha scritto: > > Please remove that code as soon as possible, rfkill input events should > > be handled by user space tools. > > About this topic, I've created a patch right now, you can find it here: > http://www.absence.it/vaio-acpi/source/patches/rfkill-input.patch > Does it look fine? You'll want to follow the patch submission guidelines: http://linux.yyz.us/patch-format.html before people will look at the patch, because many of the people who would look at it are quite busy. That means: 1) use a subject like "[PATCH] rfkill-input: remove deprecated module" 2) Add your Signed-off-by: Your Name <your email> 3) paste your patch *inline*, not as an attachment, and make *sure* to use the "preformat" or whatever option when you do, so that your mailer doesn't wrap long lines Dan > Moreover, using checkpatch.pl I've found 3 coding style errors, I'm > attaching a patch to fix them (apply this one first). > > And just one last thing: as there is no configuration option inside the > menu, shouldn't we change the "menuconfig RFKILL" line to "config > RFKILL" inside net/rfkill/Kconfig? -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Signed-off-by: Marco Chiappero <marco@absence.it> --- a/net/rfkill/core.c 2011-04-19 06:26:00.000000000 +0200 +++ b/net/rfkill/core.c 2011-04-21 15:33:21.970094489 +0200 @@ -621,7 +621,7 @@ static ssize_t rfkill_hard_show(struct d { struct rfkill *rfkill = to_rfkill(dev); - return sprintf(buf, "%d\n", (rfkill->state & RFKILL_BLOCK_HW) ? 1 : 0 ); + return sprintf(buf, "%d\n", (rfkill->state & RFKILL_BLOCK_HW) ? 1 : 0); } static ssize_t rfkill_soft_show(struct device *dev, @@ -630,7 +630,7 @@ static ssize_t rfkill_soft_show(struct d { struct rfkill *rfkill = to_rfkill(dev); - return sprintf(buf, "%d\n", (rfkill->state & RFKILL_BLOCK_SW) ? 1 : 0 ); + return sprintf(buf, "%d\n", (rfkill->state & RFKILL_BLOCK_SW) ? 1 : 0); } static ssize_t rfkill_soft_store(struct device *dev, @@ -648,7 +648,7 @@ static ssize_t rfkill_soft_store(struct if (err) return err; - if (state > 1 ) + if (state > 1) return -EINVAL; mutex_lock(&rfkill_global_mutex);