diff mbox series

[nft,5/7] JSON: Fix replace command parser

Message ID 20180601153212.26614-6-phil@nwl.cc
State Accepted
Delegated to: Pablo Neira
Headers show
Series Review wildcard expression parsing and some more | expand

Commit Message

Phil Sutter June 1, 2018, 3:32 p.m. UTC 
This was completely broken. Yet another indicator the JSON API part of
testsuite is insufficient.

Signed-off-by: Phil Sutter <phil@nwl.cc>
---
 src/parser_json.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
diff mbox series

Patch

diff --git a/src/parser_json.c b/src/parser_json.c
index 7971553651f27..9b7aef4b498cc 100644
--- a/src/parser_json.c
+++ b/src/parser_json.c
@@ -2711,8 +2711,9 @@  static struct cmd *json_parse_cmd_replace(struct json_ctx *ctx,
 	struct rule *rule;
 	size_t index;
 
-	if (json_unpack_err(ctx, root, "{s:o}", "rule", &rule))
+	if (json_unpack_err(ctx, root, "{s:o}", "rule", &tmp))
 		return NULL;
+	root = tmp;
 
 	if (json_unpack_err(ctx, root, "{s:s, s:s, s:s, s:o}",
 			    "family", &family,