Patchwork [3/3] UBIFS: use ro_mount instead of MS_RDONLY

login
register
mail settings
Submitter Artem Bityutskiy
Date April 21, 2011, 12:23 p.m.
Message ID <1303388635-28296-3-git-send-email-dedekind1@gmail.com>
Download mbox | patch
Permalink /patch/92404/
State New
Headers show

Comments

Artem Bityutskiy - April 21, 2011, 12:23 p.m.
From: Artem Bityutskiy <Artem.Bityutskiy@nokia.com>

We have our own flags indicating R/O mode, and c->ro_mode is equivalent
to MS_RDONLY. Let's be consistent and use UBIFS flags everywhere.
This patch is just a minor cleanup.

Additionally, add a comment that we are surprised with VFS behavior -
as a reminder to look at this some day.

Signed-off-by: Artem Bityutskiy <Artem.Bityutskiy@nokia.com>
---
 fs/ubifs/file.c |    6 +++++-
 1 files changed, 5 insertions(+), 1 deletions(-)

Patch

diff --git a/fs/ubifs/file.c b/fs/ubifs/file.c
index 3594aae..adce3b7 100644
--- a/fs/ubifs/file.c
+++ b/fs/ubifs/file.c
@@ -1312,7 +1312,11 @@  int ubifs_fsync(struct file *file, int datasync)
 
 	dbg_gen("syncing inode %lu", inode->i_ino);
 
-	if (inode->i_sb->s_flags & MS_RDONLY)
+	if (c->ro_mount)
+		/*
+		 * For some really strange reasons VFS does not filter out
+		 * 'fsync()' for R/O mounted file-systems as per 2.6.39.
+		 */
 		return 0;
 
 	/*