[v2,8/8] i2c: designware: Add debug print for bus speed

Message ID 20180601134725.1375-9-jarkko.nikula@linux.intel.com
State Superseded
Headers show
Series
  • i2c: designware: Improve debug prints
Related show

Commit Message

Jarkko Nikula June 1, 2018, 1:47 p.m.
Trivial added debug print for dev->clk_freq doesn't necessarily tell the
actual bus speed or mode the controller is operating. For instance it
may indicate 1 MHz Fast Mode Plus or 3.4 MHz High Speed but driver ends up
using 400 kHz Fast Mode due missing timing parameters or missing support
from HW.

Add a debug print that prints the bus speed based on the validated speed
that gets programmed into a HW.

Signed-off-by: Jarkko Nikula <jarkko.nikula@linux.intel.com>
---
 drivers/i2c/busses/i2c-designware-master.c | 14 +++++++++++++-
 1 file changed, 13 insertions(+), 1 deletion(-)

Comments

Andy Shevchenko June 4, 2018, 12:51 p.m. | #1
On Fri, 2018-06-01 at 16:47 +0300, Jarkko Nikula wrote:
> Trivial added debug print for dev->clk_freq doesn't necessarily tell
> the
> actual bus speed or mode the controller is operating. For instance it
> may indicate 1 MHz Fast Mode Plus or 3.4 MHz High Speed but driver
> ends up
> using 400 kHz Fast Mode due missing timing parameters or missing
> support
> from HW.
> 
> Add a debug print that prints the bus speed based on the validated
> speed
> that gets programmed into a HW.
> 

Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>

> Signed-off-by: Jarkko Nikula <jarkko.nikula@linux.intel.com>
> ---
>  drivers/i2c/busses/i2c-designware-master.c | 14 +++++++++++++-
>  1 file changed, 13 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/i2c/busses/i2c-designware-master.c
> b/drivers/i2c/busses/i2c-designware-master.c
> index e3a56c8e33c7..cd6360e51060 100644
> --- a/drivers/i2c/busses/i2c-designware-master.c
> +++ b/drivers/i2c/busses/i2c-designware-master.c
> @@ -48,7 +48,7 @@ static void i2c_dw_configure_fifo_master(struct
> dw_i2c_dev *dev)
>  static void i2c_dw_set_timings_master(struct dw_i2c_dev *dev)
>  {
>  	u32 ic_clk = i2c_dw_clk_rate(dev);
> -	const char *fp_str = "";
> +	const char *mode_str, *fp_str = "";
>  	u32 comp_param1;
>  	u32 sda_falling_time, scl_falling_time;
>  	int ret;
> @@ -133,6 +133,18 @@ static void i2c_dw_set_timings_master(struct
> dw_i2c_dev *dev)
>  	}
>  
>  	i2c_dw_set_sda_hold(dev);
> +
> +	switch (dev->master_cfg & DW_IC_CON_SPEED_MASK) {
> +	case DW_IC_CON_SPEED_STD:
> +		mode_str = "Standard Mode";
> +		break;
> +	case DW_IC_CON_SPEED_HIGH:
> +		mode_str = "High Speed Mode";
> +		break;
> +	default:
> +		mode_str = "Fast Mode";
> +	}
> +	dev_dbg(dev->dev, "Bus speed: %s%s\n", mode_str, fp_str);
>  }
>  
>  /**

Patch

diff --git a/drivers/i2c/busses/i2c-designware-master.c b/drivers/i2c/busses/i2c-designware-master.c
index e3a56c8e33c7..cd6360e51060 100644
--- a/drivers/i2c/busses/i2c-designware-master.c
+++ b/drivers/i2c/busses/i2c-designware-master.c
@@ -48,7 +48,7 @@  static void i2c_dw_configure_fifo_master(struct dw_i2c_dev *dev)
 static void i2c_dw_set_timings_master(struct dw_i2c_dev *dev)
 {
 	u32 ic_clk = i2c_dw_clk_rate(dev);
-	const char *fp_str = "";
+	const char *mode_str, *fp_str = "";
 	u32 comp_param1;
 	u32 sda_falling_time, scl_falling_time;
 	int ret;
@@ -133,6 +133,18 @@  static void i2c_dw_set_timings_master(struct dw_i2c_dev *dev)
 	}
 
 	i2c_dw_set_sda_hold(dev);
+
+	switch (dev->master_cfg & DW_IC_CON_SPEED_MASK) {
+	case DW_IC_CON_SPEED_STD:
+		mode_str = "Standard Mode";
+		break;
+	case DW_IC_CON_SPEED_HIGH:
+		mode_str = "High Speed Mode";
+		break;
+	default:
+		mode_str = "Fast Mode";
+	}
+	dev_dbg(dev->dev, "Bus speed: %s%s\n", mode_str, fp_str);
 }
 
 /**