staging: mt7621-gpio: move out of staging

Message ID 1527854570-17200-1-git-send-email-sergio.paracuellos@gmail.com
State New
Headers show
Series
  • staging: mt7621-gpio: move out of staging
Related show

Commit Message

Sergio Paracuellos June 1, 2018, 12:02 p.m.
Move the mt7621-gpio driver out of staging and into mainline

Signed-off-by: Sergio Paracuellos <sergio.paracuellos@gmail.com>
---
 .../devicetree/bindings/gpio}/mediatek,mt7621-gpio.txt             | 0
 drivers/gpio/Kconfig                                               | 7 +++++++
 drivers/gpio/Makefile                                              | 1 +
 drivers/{staging/mt7621-gpio => gpio}/gpio-mt7621.c                | 0
 drivers/staging/Kconfig                                            | 2 --
 drivers/staging/Makefile                                           | 1 -
 drivers/staging/mt7621-gpio/Kconfig                                | 6 ------
 drivers/staging/mt7621-gpio/Makefile                               | 3 ---
 drivers/staging/mt7621-gpio/TODO                                   | 3 ---
 9 files changed, 8 insertions(+), 15 deletions(-)
 rename {drivers/staging/mt7621-gpio => Documentation/devicetree/bindings/gpio}/mediatek,mt7621-gpio.txt (100%)
 rename drivers/{staging/mt7621-gpio => gpio}/gpio-mt7621.c (100%)
 delete mode 100644 drivers/staging/mt7621-gpio/Kconfig
 delete mode 100644 drivers/staging/mt7621-gpio/Makefile
 delete mode 100644 drivers/staging/mt7621-gpio/TODO

Comments

Greg Kroah-Hartman June 1, 2018, 6:13 p.m. | #1
On Fri, Jun 01, 2018 at 02:02:50PM +0200, Sergio Paracuellos wrote:
> Move the mt7621-gpio driver out of staging and into mainline
> 
> Signed-off-by: Sergio Paracuellos <sergio.paracuellos@gmail.com>
> ---
>  .../devicetree/bindings/gpio}/mediatek,mt7621-gpio.txt             | 0
>  drivers/gpio/Kconfig                                               | 7 +++++++
>  drivers/gpio/Makefile                                              | 1 +
>  drivers/{staging/mt7621-gpio => gpio}/gpio-mt7621.c                | 0
>  drivers/staging/Kconfig                                            | 2 --
>  drivers/staging/Makefile                                           | 1 -
>  drivers/staging/mt7621-gpio/Kconfig                                | 6 ------
>  drivers/staging/mt7621-gpio/Makefile                               | 3 ---
>  drivers/staging/mt7621-gpio/TODO                                   | 3 ---

I suggest you submit this as a new driver to the gpio maintainer and
developers and then if/when it is merged into that tree, we can then
delete the staging tree version.  That makes it easier for the gpio
developers to review it and makes any cross-tree merge issues go away.

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-gpio" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Sergio Paracuellos June 1, 2018, 7:02 p.m. | #2
> I suggest you submit this as a new driver to the gpio maintainer and
> developers and then if/when it is merged into that tree, we can then
> delete the staging tree version.  That makes it easier for the gpio
> developers to review it and makes any cross-tree merge issues go away.

I see. Ok, I'll send this in the way you are pointing out here
hopefully tomorrow morning :-)

Thanks, Greg,

>
> thanks,
>
> greg k-h

Best regards,
    Sergio Paracuellos
--
To unsubscribe from this list: send the line "unsubscribe linux-gpio" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
NeilBrown June 1, 2018, 11:30 p.m. | #3
On Fri, Jun 01 2018, Sergio Paracuellos wrote:

>> I suggest you submit this as a new driver to the gpio maintainer and
>> developers and then if/when it is merged into that tree, we can then
>> delete the staging tree version.  That makes it easier for the gpio
>> developers to review it and makes any cross-tree merge issues go away.
>
> I see. Ok, I'll send this in the way you are pointing out here
> hopefully tomorrow morning :-)

When you do, please also Cc maintainers for
  OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS
to get review for the new .dts file, though get-maintainers will
probably recommend that once you have a proper patch.
Also it would be good to highlight any uncertainties we might have
to get review comments specifically on those.
Specifically we should mention that

  The functionality is presented as a single irq-chip but 3 separate
  gpio-chips, as this seemed simplest.  Is this acceptable, or does it
  need to be changed?

Please add my Reviewed-by: NeilBrown <neil@brown.name> to the patch when
you send it.

Thanks,
NeilBrown
Sergio Paracuellos June 2, 2018, 7:33 a.m. | #4
On Sat, Jun 2, 2018 at 1:30 AM, NeilBrown <neil@brown.name> wrote:
> On Fri, Jun 01 2018, Sergio Paracuellos wrote:
>
>>> I suggest you submit this as a new driver to the gpio maintainer and
>>> developers and then if/when it is merged into that tree, we can then
>>> delete the staging tree version.  That makes it easier for the gpio
>>> developers to review it and makes any cross-tree merge issues go away.
>>
>> I see. Ok, I'll send this in the way you are pointing out here
>> hopefully tomorrow morning :-)
>
> When you do, please also Cc maintainers for
>   OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS
> to get review for the new .dts file, though get-maintainers will
> probably recommend that once you have a proper patch.
> Also it would be good to highlight any uncertainties we might have
> to get review comments specifically on those.
> Specifically we should mention that
>
>   The functionality is presented as a single irq-chip but 3 separate
>   gpio-chips, as this seemed simplest.  Is this acceptable, or does it
>   need to be changed?
>
> Please add my Reviewed-by: NeilBrown <neil@brown.name> to the patch when
> you send it.

Thanks for advices.

I have just sent it as you were pointing out here.

>
> Thanks,
> NeilBrown
>

Best regards,
    Sergio Paracuellos
--
To unsubscribe from this list: send the line "unsubscribe linux-gpio" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Dan Carpenter June 4, 2018, 9:09 a.m. | #5
Looks like a nice driver to me now.  Thanks!

regards,
dan carpenter

--
To unsubscribe from this list: send the line "unsubscribe linux-gpio" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Sergio Paracuellos June 5, 2018, 11:19 a.m. | #6
On Mon, Jun 04, 2018 at 12:09:38PM +0300, Dan Carpenter wrote:
> Looks like a nice driver to me now.  Thanks!

Thanks, Dan. Let's wait for feedback from gpio and device tree guys.
> 
> regards,
> dan carpenter
> 
Best regards,
    Sergio Paracuellos
--
To unsubscribe from this list: send the line "unsubscribe linux-gpio" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Patch

diff --git a/drivers/staging/mt7621-gpio/mediatek,mt7621-gpio.txt b/Documentation/devicetree/bindings/gpio/mediatek,mt7621-gpio.txt
similarity index 100%
rename from drivers/staging/mt7621-gpio/mediatek,mt7621-gpio.txt
rename to Documentation/devicetree/bindings/gpio/mediatek,mt7621-gpio.txt
diff --git a/drivers/gpio/Kconfig b/drivers/gpio/Kconfig
index b960f6f..280c0a0 100644
--- a/drivers/gpio/Kconfig
+++ b/drivers/gpio/Kconfig
@@ -347,6 +347,13 @@  config GPIO_MPC8XXX
 	  Say Y here if you're going to use hardware that connects to the
 	  MPC512x/831x/834x/837x/8572/8610/QorIQ GPIOs.
 
+config GPIO_MT7621
+	bool "Mediatek GPIO Support"
+	depends on SOC_MT7620 || SOC_MT7621
+	select GPIOLIB_IRQCHIP
+	help
+	  Say yes here to support the Mediatek SoC GPIO device
+
 config GPIO_MVEBU
 	def_bool y
 	depends on PLAT_ORION || ARCH_MVEBU
diff --git a/drivers/gpio/Makefile b/drivers/gpio/Makefile
index 1324c8f..03647ae 100644
--- a/drivers/gpio/Makefile
+++ b/drivers/gpio/Makefile
@@ -88,6 +88,7 @@  obj-$(CONFIG_GPIO_MOCKUP)      += gpio-mockup.o
 obj-$(CONFIG_GPIO_MPC5200)	+= gpio-mpc5200.o
 obj-$(CONFIG_GPIO_MPC8XXX)	+= gpio-mpc8xxx.o
 obj-$(CONFIG_GPIO_MSIC)		+= gpio-msic.o
+obj-$(CONFIG_GPIO_MT7621)	+= gpio-mt7621.o
 obj-$(CONFIG_GPIO_MVEBU)        += gpio-mvebu.o
 obj-$(CONFIG_GPIO_MXC)		+= gpio-mxc.o
 obj-$(CONFIG_GPIO_MXS)		+= gpio-mxs.o
diff --git a/drivers/staging/mt7621-gpio/gpio-mt7621.c b/drivers/gpio/gpio-mt7621.c
similarity index 100%
rename from drivers/staging/mt7621-gpio/gpio-mt7621.c
rename to drivers/gpio/gpio-mt7621.c
diff --git a/drivers/staging/Kconfig b/drivers/staging/Kconfig
index d5926f0..3f0cbbd 100644
--- a/drivers/staging/Kconfig
+++ b/drivers/staging/Kconfig
@@ -120,8 +120,6 @@  source "drivers/staging/pi433/Kconfig"
 
 source "drivers/staging/mt7621-pinctrl/Kconfig"
 
-source "drivers/staging/mt7621-gpio/Kconfig"
-
 source "drivers/staging/mt7621-spi/Kconfig"
 
 source "drivers/staging/mt7621-dma/Kconfig"
diff --git a/drivers/staging/Makefile b/drivers/staging/Makefile
index 919753c..42a1268 100644
--- a/drivers/staging/Makefile
+++ b/drivers/staging/Makefile
@@ -51,7 +51,6 @@  obj-$(CONFIG_DRM_VBOXVIDEO)	+= vboxvideo/
 obj-$(CONFIG_PI433)		+= pi433/
 obj-$(CONFIG_SOC_MT7621)	+= mt7621-pci/
 obj-$(CONFIG_SOC_MT7621)	+= mt7621-pinctrl/
-obj-$(CONFIG_SOC_MT7621)	+= mt7621-gpio/
 obj-$(CONFIG_SOC_MT7621)	+= mt7621-spi/
 obj-$(CONFIG_SOC_MT7621)	+= mt7621-dma/
 obj-$(CONFIG_SOC_MT7621)	+= mt7621-mmc/
diff --git a/drivers/staging/mt7621-gpio/Kconfig b/drivers/staging/mt7621-gpio/Kconfig
deleted file mode 100644
index c741ec3..0000000
--- a/drivers/staging/mt7621-gpio/Kconfig
+++ /dev/null
@@ -1,6 +0,0 @@ 
-config GPIO_MT7621
-	bool "Mediatek GPIO Support"
-	depends on SOC_MT7620 || SOC_MT7621
-	select ARCH_REQUIRE_GPIOLIB
-	help
-	  Say yes here to support the Mediatek SoC GPIO device
diff --git a/drivers/staging/mt7621-gpio/Makefile b/drivers/staging/mt7621-gpio/Makefile
deleted file mode 100644
index e269ab1..0000000
--- a/drivers/staging/mt7621-gpio/Makefile
+++ /dev/null
@@ -1,3 +0,0 @@ 
-obj-$(CONFIG_GPIO_MT7621)	+= gpio-mt7621.o
-
-ccflags-y += -I$(srctree)/$(src)/include
diff --git a/drivers/staging/mt7621-gpio/TODO b/drivers/staging/mt7621-gpio/TODO
deleted file mode 100644
index 674930a..0000000
--- a/drivers/staging/mt7621-gpio/TODO
+++ /dev/null
@@ -1,3 +0,0 @@ 
-- general code review and clean up
-
-Cc:  NeilBrown <neil@brown.name>