[1/2] mtd: m25p80: Remove unneeded m25p->command field

Message ID 20180601100325.11165-1-boris.brezillon@bootlin.com
State Accepted
Delegated to: Boris Brezillon
Headers show
Series
  • [1/2] mtd: m25p80: Remove unneeded m25p->command field
Related show

Commit Message

Boris Brezillon June 1, 2018, 10:03 a.m.
The ->command field is no longer used, remove it.

Signed-off-by: Boris Brezillon <boris.brezillon@bootlin.com>
---
 drivers/mtd/devices/m25p80.c | 2 --
 1 file changed, 2 deletions(-)

Comments

Boris Brezillon June 18, 2018, 9:04 a.m. | #1
Hi Marek,

Can you add your Acked-by or Reviewed-by if you're okay with these
changes?

Thanks,

Boris

On Fri,  1 Jun 2018 12:03:24 +0200
Boris Brezillon <boris.brezillon@bootlin.com> wrote:

> The ->command field is no longer used, remove it.
> 
> Signed-off-by: Boris Brezillon <boris.brezillon@bootlin.com>
> ---
>  drivers/mtd/devices/m25p80.c | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/drivers/mtd/devices/m25p80.c b/drivers/mtd/devices/m25p80.c
> index 3dc022d3b53e..73dd74330227 100644
> --- a/drivers/mtd/devices/m25p80.c
> +++ b/drivers/mtd/devices/m25p80.c
> @@ -28,11 +28,9 @@
>  #include <linux/spi/flash.h>
>  #include <linux/mtd/spi-nor.h>
>  
> -#define	MAX_CMD_SIZE		6
>  struct m25p {
>  	struct spi_mem		*spimem;
>  	struct spi_nor		spi_nor;
> -	u8			command[MAX_CMD_SIZE];
>  };
>  
>  static int m25p80_read_reg(struct spi_nor *nor, u8 code, u8 *val, int len)
Marek Vasut June 18, 2018, 9:40 a.m. | #2
On 06/01/2018 12:03 PM, Boris Brezillon wrote:
> The ->command field is no longer used, remove it.
> 
> Signed-off-by: Boris Brezillon <boris.brezillon@bootlin.com>

Acked-by: Marek Vasut <marek.vasut@gmail.com>

> ---
>  drivers/mtd/devices/m25p80.c | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/drivers/mtd/devices/m25p80.c b/drivers/mtd/devices/m25p80.c
> index 3dc022d3b53e..73dd74330227 100644
> --- a/drivers/mtd/devices/m25p80.c
> +++ b/drivers/mtd/devices/m25p80.c
> @@ -28,11 +28,9 @@
>  #include <linux/spi/flash.h>
>  #include <linux/mtd/spi-nor.h>
>  
> -#define	MAX_CMD_SIZE		6
>  struct m25p {
>  	struct spi_mem		*spimem;
>  	struct spi_nor		spi_nor;
> -	u8			command[MAX_CMD_SIZE];
>  };
>  
>  static int m25p80_read_reg(struct spi_nor *nor, u8 code, u8 *val, int len)
>
Boris Brezillon June 19, 2018, 5:45 a.m. | #3
On Fri,  1 Jun 2018 12:03:24 +0200
Boris Brezillon <boris.brezillon@bootlin.com> wrote:

> The ->command field is no longer used, remove it.
> 
> Signed-off-by: Boris Brezillon <boris.brezillon@bootlin.com>

Applied both patches to spi-nor/next.

> ---
>  drivers/mtd/devices/m25p80.c | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/drivers/mtd/devices/m25p80.c b/drivers/mtd/devices/m25p80.c
> index 3dc022d3b53e..73dd74330227 100644
> --- a/drivers/mtd/devices/m25p80.c
> +++ b/drivers/mtd/devices/m25p80.c
> @@ -28,11 +28,9 @@
>  #include <linux/spi/flash.h>
>  #include <linux/mtd/spi-nor.h>
>  
> -#define	MAX_CMD_SIZE		6
>  struct m25p {
>  	struct spi_mem		*spimem;
>  	struct spi_nor		spi_nor;
> -	u8			command[MAX_CMD_SIZE];
>  };
>  
>  static int m25p80_read_reg(struct spi_nor *nor, u8 code, u8 *val, int len)

Patch

diff --git a/drivers/mtd/devices/m25p80.c b/drivers/mtd/devices/m25p80.c
index 3dc022d3b53e..73dd74330227 100644
--- a/drivers/mtd/devices/m25p80.c
+++ b/drivers/mtd/devices/m25p80.c
@@ -28,11 +28,9 @@ 
 #include <linux/spi/flash.h>
 #include <linux/mtd/spi-nor.h>
 
-#define	MAX_CMD_SIZE		6
 struct m25p {
 	struct spi_mem		*spimem;
 	struct spi_nor		spi_nor;
-	u8			command[MAX_CMD_SIZE];
 };
 
 static int m25p80_read_reg(struct spi_nor *nor, u8 code, u8 *val, int len)