mbox

[PULL,0/9] slirp updates

Message ID 20180531192237.3994-1-samuel.thibault@ens-lyon.org
State New
Headers show

Pull-request

http://people.debian.org/~sthibault/qemu.git tags/samuel-thibault

Message

Samuel Thibault May 31, 2018, 7:22 p.m. UTC 
The following changes since commit c181ddaa176856b3cd2dfd12bbcf25fa9c884a97:

  Merge remote-tracking branch 'remotes/pmaydell/tags/pull-target-arm-20180531-1' into staging (2018-05-31 17:00:55 +0100)

are available in the Git repository at:

  http://people.debian.org/~sthibault/qemu.git tags/samuel-thibault

for you to fetch changes up to 528e913612bf22661b169018780d8a6fc678c655:

  slirp/ncsi: add checksum support (2018-05-31 20:45:02 +0200)

----------------------------------------------------------------
slirp updates

Alexey Kardashevskiy
  slirp: Improve debugging messages

Andreas Gustafsson, Samuel Thibault, James Clarke
  slirp: Improve bandwidth in GDB remote debugging and FreeBSD guests

Benjamin Drung:
  slirp/dhcp: Add domainname option

Cédric Le Goater (3):
  slirp/ncsi: fix "Get Version ID" payload length
  slirp/ncsi: add a "Get Parameters" response
  slirp/ncsi: add checksum support

Nia Alarie:
  net/slirp: Convert atoi to qemu_strtoi to allow error checking

----------------------------------------------------------------
Alexey Kardashevskiy (1):
      slirp/debug: Print IP addresses in human readable form

Andreas Gustafsson (1):
      slirp: disable Nagle in outgoing connections

Benjamin Drung (1):
      slirp: Add domainname option to slirp's DHCP server

Cédric Le Goater (3):
      slirp/ncsi: fix "Get Version ID" payload length
      slirp/ncsi: add a "Get Parameters" response
      slirp/ncsi: add checksum support

James Clarke (1):
      slirp: Send window updates to guest after window was closed

Nia Alarie (1):
      net/slirp: Convert atoi to qemu_strtoi to allow error checking

Samuel Thibault (1):
      slirp: disable Nagle in ingoing connections

 net/slirp.c       | 16 ++++++++++++----
 qapi/net.json     |  4 ++++
 qemu-options.hx   |  7 +++++--
 slirp/arp_table.c |  4 ++--
 slirp/bootp.c     |  8 ++++++++
 slirp/libslirp.h  |  2 +-
 slirp/ncsi.c      | 51 ++++++++++++++++++++++++++++++++++++++++++++-------
 slirp/slirp.c     | 16 +++++++++-------
 slirp/slirp.h     |  1 +
 slirp/socket.c    |  6 ++++--
 slirp/tcp_subr.c  |  2 ++
 11 files changed, 92 insertions(+), 25 deletions(-)

Comments

no-reply@patchew.org May 31, 2018, 7:40 p.m. UTC | #1 
Hi,

This series seems to have some coding style problems. See output below for
more information:

Type: series
Message-id: 20180531192237.3994-1-samuel.thibault@ens-lyon.org
Subject: [Qemu-devel] [PULL 0/9] slirp updates

=== TEST SCRIPT BEGIN ===
#!/bin/bash

BASE=base
n=1
total=$(git log --oneline $BASE.. | wc -l)
failed=0

git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram

commits="$(git log --format=%H --reverse $BASE..)"
for c in $commits; do
    echo "Checking PATCH $n/$total: $(git log -n 1 --format=%s $c)..."
    if ! git show $c --format=email | ./scripts/checkpatch.pl --mailback -; then
        failed=1
        echo
    fi
    n=$((n+1))
done

exit $failed
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
 * [new tag]               patchew/20180531192237.3994-1-samuel.thibault@ens-lyon.org -> patchew/20180531192237.3994-1-samuel.thibault@ens-lyon.org
Switched to a new branch 'test'
100c703503 slirp/ncsi: add checksum support
41dba64dbb slirp/ncsi: add a "Get Parameters" response
b0eef29e1d slirp/ncsi: fix "Get Version ID" payload length
9704af1c8c slirp: Send window updates to guest after window was closed
0829b29dd1 net/slirp: Convert atoi to qemu_strtoi to allow error checking
b25abd1163 slirp/debug: Print IP addresses in human readable form
b333e33553 slirp: disable Nagle in ingoing connections
b5523b84a3 slirp: disable Nagle in outgoing connections
9ecad88828 slirp: Add domainname option to slirp's DHCP server

=== OUTPUT BEGIN ===
Checking PATCH 1/9: slirp: Add domainname option to slirp's DHCP server...
Checking PATCH 2/9: slirp: disable Nagle in outgoing connections...
Checking PATCH 3/9: slirp: disable Nagle in ingoing connections...
ERROR: code indent should never use tabs
#24: FILE: slirp/socket.c:757:
+^Iopt = 1;$

ERROR: code indent should never use tabs
#25: FILE: slirp/socket.c:758:
+^Iqemu_setsockopt(s, IPPROTO_TCP, TCP_NODELAY, &opt, sizeof(int));$

total: 2 errors, 0 warnings, 8 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

Checking PATCH 4/9: slirp/debug: Print IP addresses in human readable form...
ERROR: code indent should never use tabs
#41: FILE: slirp/socket.c:704:
+^IDEBUG_ARG("haddr = %s", inet_ntoa((struct in_addr){.s_addr = haddr}));$

ERROR: code indent should never use tabs
#44: FILE: slirp/socket.c:706:
+^IDEBUG_ARG("laddr = %s", inet_ntoa((struct in_addr){.s_addr = laddr}));$

total: 2 errors, 0 warnings, 27 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

Checking PATCH 5/9: net/slirp: Convert atoi to qemu_strtoi to allow error checking...
Checking PATCH 6/9: slirp: Send window updates to guest after window was closed...
Checking PATCH 7/9: slirp/ncsi: fix "Get Version ID" payload length...
Checking PATCH 8/9: slirp/ncsi: add a "Get Parameters" response...
Checking PATCH 9/9: slirp/ncsi: add checksum support...
=== OUTPUT END ===

Test command exited with code: 1


---
Email generated automatically by Patchew [http://patchew.org/].
Please send your feedback to patchew-devel@redhat.com
Peter Maydell June 1, 2018, 1:50 p.m. UTC | #2 
On 31 May 2018 at 20:22, Samuel Thibault <samuel.thibault@ens-lyon.org> wrote:
> The following changes since commit c181ddaa176856b3cd2dfd12bbcf25fa9c884a97:
>
>   Merge remote-tracking branch 'remotes/pmaydell/tags/pull-target-arm-20180531-1' into staging (2018-05-31 17:00:55 +0100)
>
> are available in the Git repository at:
>
>   http://people.debian.org/~sthibault/qemu.git tags/samuel-thibault
>
> for you to fetch changes up to 528e913612bf22661b169018780d8a6fc678c655:
>
>   slirp/ncsi: add checksum support (2018-05-31 20:45:02 +0200)
>
> ----------------------------------------------------------------
> slirp updates
>
> Alexey Kardashevskiy
>   slirp: Improve debugging messages
>
> Andreas Gustafsson, Samuel Thibault, James Clarke
>   slirp: Improve bandwidth in GDB remote debugging and FreeBSD guests
>
> Benjamin Drung:
>   slirp/dhcp: Add domainname option

Hi; it looks like you forgot to add your signed-off-by to this
patch from Benjamin. Could you add it and respin, please?
(You can just send the pullreq cover letter, no need to re-email
the individual patches.)

thanks
-- PMM
Samuel Thibault June 1, 2018, 1:57 p.m. UTC | #3 
Peter Maydell, le ven. 01 juin 2018 14:50:29 +0100, a ecrit:
> Hi; it looks like you forgot to add your signed-off-by to this
> patch from Benjamin.

Oh?  I did have noticed it and rebased, but I guess I forgot to update
the tag.

> Could you add it and respin, please?

I have now fixed the tag and the PR.

Samuel