| Message ID | 152775720805.24817.1149926292475954272.stgit@firesoul |
|---|---|
| State | Accepted, archived |
| Delegated to: | BPF Maintainers |
| Headers | show |
| Series | bpf/xdp: add flags argument to ndo_xdp_xmit and flag flush operation | expand |
On Thu, May 31, 2018 at 2:00 AM, Jesper Dangaard Brouer <brouer@redhat.com> wrote: > When passed the XDP_XMIT_FLUSH flag virtnet_xdp_xmit now performs the > same virtqueue_kick as virtnet_xdp_flush. > > Signed-off-by: Jesper Dangaard Brouer <brouer@redhat.com> Acked-by: Song Liu <songliubraving@fb.com> > --- > drivers/net/virtio_net.c | 6 +++++- > 1 file changed, 5 insertions(+), 1 deletion(-) > > diff --git a/drivers/net/virtio_net.c b/drivers/net/virtio_net.c > index 4ed823625953..62ba8aadd8e6 100644 > --- a/drivers/net/virtio_net.c > +++ b/drivers/net/virtio_net.c > @@ -481,7 +481,7 @@ static int virtnet_xdp_xmit(struct net_device *dev, > int err; > int i; > > - if (unlikely(flags & ~XDP_XMIT_FLAGS_NONE)) > + if (unlikely(flags & ~XDP_XMIT_FLAGS_MASK)) > return -EINVAL; > > qp = vi->curr_queue_pairs - vi->xdp_queue_pairs + smp_processor_id(); > @@ -507,6 +507,10 @@ static int virtnet_xdp_xmit(struct net_device *dev, > drops++; > } > } > + > + if (flags & XDP_XMIT_FLUSH) > + virtqueue_kick(sq->vq); > + > return n - drops; > } > >
diff --git a/drivers/net/virtio_net.c b/drivers/net/virtio_net.c index 4ed823625953..62ba8aadd8e6 100644 --- a/drivers/net/virtio_net.c +++ b/drivers/net/virtio_net.c @@ -481,7 +481,7 @@ static int virtnet_xdp_xmit(struct net_device *dev, int err; int i; - if (unlikely(flags & ~XDP_XMIT_FLAGS_NONE)) + if (unlikely(flags & ~XDP_XMIT_FLAGS_MASK)) return -EINVAL; qp = vi->curr_queue_pairs - vi->xdp_queue_pairs + smp_processor_id(); @@ -507,6 +507,10 @@ static int virtnet_xdp_xmit(struct net_device *dev, drops++; } } + + if (flags & XDP_XMIT_FLUSH) + virtqueue_kick(sq->vq); + return n - drops; }
When passed the XDP_XMIT_FLUSH flag virtnet_xdp_xmit now performs the same virtqueue_kick as virtnet_xdp_flush. Signed-off-by: Jesper Dangaard Brouer <brouer@redhat.com> --- drivers/net/virtio_net.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-)