[v3] common/rc: skip atime related tests on CIFS

Message ID 1527739814-30451-1-git-send-email-xifeng@redhat.com
State New
Headers show
Series
  • [v3] common/rc: skip atime related tests on CIFS
Related show

Commit Message

XiaoLi Feng May 31, 2018, 4:10 a.m.
From: xiaoli feng <xifeng@redhat.com>

From the feedback of cifs developer, the behaviour of atime/noatime
for cifs is basically noatime always. So the atime related mount
options have no effect on cifs mounts. And Skip these tests on CIFS.

Signed-off-by: xiaoli feng <xifeng@redhat.com>
---
 common/rc | 13 ++++++++++---
 1 file changed, 10 insertions(+), 3 deletions(-)

Patch

diff --git a/common/rc b/common/rc
index ffe5323..0295b30 100644
--- a/common/rc
+++ b/common/rc
@@ -3242,9 +3242,16 @@  _exclude_scratch_mount_option()
 _require_atime()
 {
 	_exclude_scratch_mount_option "noatime"
-	if [ "$FSTYP" == "nfs" ]; then
-		_notrun "atime related mount options have no effect on NFS"
-	fi
+	case $FSTYP
+	in
+		nfs)
+			_notrun "atime related mount options have no effect on NFS"
+		;;
+		cifs)
+			_notrun "atime related mount options have no effect on CIFS"
+		;;
+	esac
+
 }
 
 _require_relatime()