diff mbox series

[net-next] net: netcp: ethss: remove unnecessary pointer set to NULL

Message ID 20180531034848.23080-1-yuehaibing@huawei.com
State Accepted, archived
Delegated to: David Miller
Headers show
Series [net-next] net: netcp: ethss: remove unnecessary pointer set to NULL | expand

Commit Message

Yue Haibing May 31, 2018, 3:48 a.m. UTC
If statement has make sure the 'slave->phy' is NULL

Signed-off-by: YueHaibing <yuehaibing@huawei.com>
---
 drivers/net/ethernet/ti/netcp_ethss.c | 1 -
 1 file changed, 1 deletion(-)

Comments

David Miller June 3, 2018, 2:40 p.m. UTC | #1
From: YueHaibing <yuehaibing@huawei.com>
Date: Thu, 31 May 2018 11:48:48 +0800

> If statement has make sure the 'slave->phy' is NULL
> 
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>

Looks good, applied.
diff mbox series

Patch

diff --git a/drivers/net/ethernet/ti/netcp_ethss.c b/drivers/net/ethernet/ti/netcp_ethss.c
index 6a728d3..6e455a2 100644
--- a/drivers/net/ethernet/ti/netcp_ethss.c
+++ b/drivers/net/ethernet/ti/netcp_ethss.c
@@ -3206,7 +3206,6 @@  static void init_secondary_ports(struct gbe_priv *gbe_dev,
 		if (!slave->phy) {
 			dev_err(dev, "phy not found for slave %d\n",
 				slave->slave_num);
-			slave->phy = NULL;
 		} else {
 			dev_dbg(dev, "phy found: id is: 0x%s\n",
 				phydev_name(slave->phy));