| Message ID | 1527732283-145530-1-git-send-email-weiyongjun1@huawei.com |
|---|---|
| State | Accepted, archived |
| Delegated to: | David Miller |
| Headers | show |
| Series | [net-next] hv_netvsc: fix error return code in netvsc_probe() | expand |
From: Wei Yongjun <weiyongjun1@huawei.com> Date: Thu, 31 May 2018 02:04:43 +0000 > Fix to return a negative error code from the failover register fail > error handling case instead of 0, as done elsewhere in this function. > > Fixes: 1ff78076d8dd ("netvsc: refactor notifier/event handling code to use the failover framework") > Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com> Applied, thank you.
diff --git a/drivers/net/hyperv/netvsc_drv.c b/drivers/net/hyperv/netvsc_drv.c index ebe9642..bef4d55 100644 --- a/drivers/net/hyperv/netvsc_drv.c +++ b/drivers/net/hyperv/netvsc_drv.c @@ -2031,8 +2031,10 @@ static int netvsc_probe(struct hv_device *dev, } net_device_ctx->failover = failover_register(net, &netvsc_failover_ops); - if (IS_ERR(net_device_ctx->failover)) + if (IS_ERR(net_device_ctx->failover)) { + ret = PTR_ERR(net_device_ctx->failover); goto err_failover; + } return ret;
Fix to return a negative error code from the failover register fail error handling case instead of 0, as done elsewhere in this function. Fixes: 1ff78076d8dd ("netvsc: refactor notifier/event handling code to use the failover framework") Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com> --- drivers/net/hyperv/netvsc_drv.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)