diff mbox series

[uclibc-ng-devel] Antwort: Re: thumb_swp/thumb_swpb

Message ID OF1D4B3F0E.6AFAC454-ONC125829D.00475314-C125829D.004888D3@local-dmz.de
State Changes Requested
Headers show
Series [uclibc-ng-devel] Antwort: Re: thumb_swp/thumb_swpb | expand

Commit Message

Florian La Roche May 30, 2018, 1:12 p.m. UTC
Hello Waldemar Brodkorb,

seems this is triggered if gcc (also with older versions) compiles for 
coretex-a53
if thumb-mode is enabled. (So this would trigger if e.g. 
raspberrypi3_defconfig
gets thumb mode enabled or if you change vexpress_defconfig to compile for 
a53.)

The error output from gcc is:
AS ldso/ldso/arm/thumb_atomics.oS
ldso/ldso/arm/thumb_atomics.S: Assembler messages:
ldso/ldso/arm/thumb_atomics.S:49: Error: swp{b} use is obsoleted for ARMv8 
and later
ldso/ldso/arm/thumb_atomics.S:55: Error: swp{b} use is obsoleted for ARMv8 
and later
Makerules:373: recipe for target 'ldso/ldso/arm/thumb_atomics.oS' failed


How to reproduce this:
git clone https://github.com/buildroot/buildroot.git
pushd buildroot
patch -s -p1 < ../buildroot.patch
make qemu_arm_vexpress_defconfig
make
popd

with buildroot.patch:


Do you know which software depends on this spcial function to exist in 
uclibc-ng?


best regards,

Florian La Roche




Geschäftsführung: Susanne Kunschert, Thomas Pilz
Pilz GmbH & Co. KG, Sitz: Ostfildern, HRA 210 893, Amtsgericht Stuttgart
Kompl. Ges. Peter Pilz GmbH, Sitz: Ostfildern, HRB 210 612, Amtsgericht Stuttgart
Umsatzsteuer: ID-Nr. DE 145 355 773, WEEE-Reg.-Nr. DE 71636849
This email is intended solely for the use of the named address(es). Any unauthorised disclosure, copying or distribution of these confidential information contained therein, or the taking of any action based on it, is prohibited. The sender disclaims any liability for the integrity of this email. Legally binding declarations must be in written form.
Umweltschutz liegt uns am Herzen! - Bitte denken Sie an unsere Umwelt, bevor Sie diese E-Mail drucken.
We do care about the environment! - Please consider the environment before printing this e-mail.

Comments

Florian La Roche June 4, 2018, 8:44 p.m. UTC | #1
<font face="Default Sans Serif,Verdana,Arial,Helvetica,sans-serif" size="2">Hello Waldemar,<div><br></div><div>seems the third assembler function in this file, thumb_cmpxchg, is then also completely</div><div>unused. I've done some more searches and also current llvm does not seem to depend</div><div>on these, so I'll send in a removal request for the complete file if nobody else objects.</div><div><br></div><div>best regards,</div><div><br></div><div>Florian La Roche</div><div><br></div><div><div><br><br><font color="#990099">-----Waldemar Brodkorb &lt;wbx@openasdk.org&gt; schrieb: -----</font><div class="iNotesHistory" style="padding-left:5px;"><div style="padding-right:0px;padding-left:5px;border-left:solid black 2px;">An: Florian La Roche &lt;F.LaRoche@pilz.de&gt;<br>Von: Waldemar Brodkorb &lt;wbx@openasdk.org&gt;<br>Datum: 02.06.2018 07:59<br>Kopie: Waldemar Brodkorb &lt;wbx@uclibc-ng.org&gt;, buildroot@busybox.net, devel@uclibc-ng.org<br>Betreff: Re: [uclibc-ng-devel] thumb_swp/thumb_swpb<br><br><div><font face="Courier New,Courier,monospace" size="3">Hi Florian,<br>Florian La Roche wrote,<br><br>&gt; Hello Waldemar Brodkorb,<br>&gt; <br>&gt; seems this is triggered if gcc (also with older versions) compiles for<br>&gt; coretex-a53<br>&gt; if thumb-mode is enabled. (So this would trigger if e.g. raspberrypi3_defconfig<br>&gt; gets thumb mode enabled or if you change vexpress_defconfig to compile for<br>&gt; a53.)<br>&gt; <br>&gt; The error output from gcc is:<br>&gt; AS ldso/ldso/arm/thumb_atomics.oS<br>&gt; ldso/ldso/arm/thumb_atomics.S: Assembler messages:<br>&gt; ldso/ldso/arm/thumb_atomics.S:49: Error: swp{b} use is obsoleted for ARMv8 and<br>&gt; later<br>&gt; ldso/ldso/arm/thumb_atomics.S:55: Error: swp{b} use is obsoleted for ARMv8 and<br>&gt; later<br>&gt; Makerules:373: recipe for target 'ldso/ldso/arm/thumb_atomics.oS' failed<br>&gt; <br>&gt; Do you know which software depends on this spcial function to exist in<br>&gt; uclibc-ng?<br><br>I got some time to search through the git history log and I believe<br>the two functions where just imported when TLS support for ARM was<br>added from glibc to uClibc in 2009. <br>The functions are not used internally in ld.so and I furthermore<br>think they are not used at all.<br>As both functions marked hidden and uses double underscore as<br>prefix, they can't be used in a public API by someone else.<br><br>Can you sent a patch including the removal of the comment in front<br>off.<br><br>Thanks in advance<br>&nbsp;Waldemar<br><br></font></div></div></div></div></div></font><BR>
<BR>
Geschäftsführung: Susanne Kunschert, Thomas Pilz<br>Pilz GmbH &amp; Co. KG, Sitz: Ostfildern, HRA 210 893, Amtsgericht Stuttgart<br>Kompl. Ges. Peter Pilz GmbH, Sitz: Ostfildern, HRB 210 612, Amtsgericht Stuttgart<br>Umsatzsteuer: ID-Nr. DE 145 355 773, WEEE-Reg.-Nr. DE 71636849<br>This email is intended solely for the use of the named address(es). Any unauthorised disclosure, copying or distribution of these confidential information contained therein, or the taking of any action based on it, is prohibited. The sender disclaims any liability for the integrity of this email. Legally binding declarations must be in written form.<br>Umweltschutz liegt uns am Herzen! - Bitte denken Sie an unsere Umwelt, bevor Sie diese E-Mail drucken.<br>We do care about the environment! - Please consider the environment before printing this e-mail.
diff mbox series

Patch

diff --git a/configs/qemu_arm_vexpress_defconfig 
b/configs/qemu_arm_vexpress_defconfig
index 34a50aa8d5..2f3e8a7c54 100644
--- a/configs/qemu_arm_vexpress_defconfig
+++ b/configs/qemu_arm_vexpress_defconfig
@@ -1,9 +1,11 @@ 
 # Architecture
 BR2_arm=y
-BR2_cortex_a9=y
+BR2_cortex_a53=y
 BR2_ARM_ENABLE_NEON=y
 BR2_ARM_ENABLE_VFP=y
-BR2_ARM_FPU_VFPV3D16=y
+BR2_ARM_FPU_VFPV4=y
+
+BR2_ARM_INSTRUCTIONS_THUMB2=y
 
 # System
 BR2_SYSTEM_DHCP="eth0"