Patchwork [Fortran,committed] PR 48692 - Fix gfortran.dg/module_write_1.f90 failure

login
register
mail settings
Submitter Tobias Burnus
Date April 20, 2011, 6:12 p.m.
Message ID <4DAF21F0.9010705@net-b.de>
Download mbox | patch
Permalink /patch/92265/
State New
Headers show

Comments

Tobias Burnus - April 20, 2011, 6:12 p.m.
The committal of the patch for PR 48588 caused that 
gfortran.dg/module_write_1.f90 was now failing (ICE).

After some debugging (cf. PR 48692) it turned out that it only worked by 
chance before. The attached patch fixes the issue more properly. (The 
ICE occurred as a check whether all symbols were committed failed.)

The patch was build, tested and regtested on x86-64-linux; it is rather 
obvious and has also been approved by Steve in a private email.

Tobias

Patch

Index: gcc/fortran/ChangeLog
===================================================================
--- gcc/fortran/ChangeLog	(Revision 172781)
+++ gcc/fortran/ChangeLog	(Arbeitskopie)
@@ -1,3 +1,10 @@ 
+2011-04-19  Tobias Burnus  <burnus@net-b.de>
+
+	PR fortran/48588
+	PR fortran/48692
+
+	* module.c (fix_mio_expr): Commit created symbol.
+
 2011-04-19  Janne Blomqvist  <jb@gcc.gnu.org>
 
 	* scanner.c (load_file): Use XCNEWVAR instead of xcalloc.
Index: gcc/fortran/module.c
===================================================================
--- gcc/fortran/module.c	(Revision 172781)
+++ gcc/fortran/module.c	(Arbeitskopie)
@@ -3013,6 +3013,7 @@  fix_mio_expr (gfc_expr *e)
       sym->attr.flavor = FL_PROCEDURE;
       sym->attr.generic = 1;
       e->symtree = gfc_find_symtree (gfc_current_ns->sym_root, fname);
+      gfc_commit_symbol (sym);
     }
 }