diff mbox series

Replace dead store with early return

Message ID 20180530081750.GA13257@redhat.com
State New
Headers show
Series Replace dead store with early return | expand

Commit Message

Jonathan Wakely May 30, 2018, 8:17 a.m. UTC 
Coverity noticed a dead store to 'value', and Jason approved this
change off-list.

	* typeck.c (cxx_sizeof_or_alignof_type): Return size_one_node instead
	of using it in dead store.

Tested powerpc64le-linux, committed to trunk.
commit 14edce5a9e82c8747a5511339ab563f92269efc8
Author: Jonathan Wakely <jwakely@redhat.com>
Date:   Tue May 29 23:15:37 2018 +0100

    Replace dead store with early return
    
            * typeck.c (cxx_sizeof_or_alignof_type): Return size_one_node instead
            of using it in dead store.
diff mbox series

Patch

diff --git a/gcc/cp/typeck.c b/gcc/cp/typeck.c
index 25d11f5c7b6..9febdb908ae 100644
--- a/gcc/cp/typeck.c
+++ b/gcc/cp/typeck.c
@@ -1597,9 +1597,6 @@  tree
 cxx_sizeof_or_alignof_type (tree type, enum tree_code op, bool std_alignof,
 			    bool complain)
 {
-  tree value;
-  bool dependent_p;
-
   gcc_assert (op == SIZEOF_EXPR || op == ALIGNOF_EXPR);
   if (type == error_mark_node)
     return error_mark_node;
@@ -1608,15 +1605,17 @@  cxx_sizeof_or_alignof_type (tree type, enum tree_code op, bool std_alignof,
   if (TREE_CODE (type) == METHOD_TYPE)
     {
       if (complain)
-	pedwarn (input_location, OPT_Wpointer_arith, 
-		 "invalid application of %qs to a member function", 
-		 OVL_OP_INFO (false, op)->name);
+	{
+	  pedwarn (input_location, OPT_Wpointer_arith,
+		   "invalid application of %qs to a member function",
+		   OVL_OP_INFO (false, op)->name);
+	  return size_one_node;
+	}
       else
 	return error_mark_node;
-      value = size_one_node;
     }
 
-  dependent_p = dependent_type_p (type);
+  bool dependent_p = dependent_type_p (type);
   if (!dependent_p)
     complete_type (type);
   if (dependent_p
@@ -1630,7 +1629,7 @@  cxx_sizeof_or_alignof_type (tree type, enum tree_code op, bool std_alignof,
 	  && COMPLETE_TYPE_P (type)
 	  && TREE_CODE (TYPE_SIZE (type)) != INTEGER_CST))
     {
-      value = build_min (op, size_type_node, type);
+      tree value = build_min (op, size_type_node, type);
       TREE_READONLY (value) = 1;
       if (op == ALIGNOF_EXPR && std_alignof)
 	ALIGNOF_EXPR_STD_P (value) = true;