Patchwork [V14,13/17] pci: Use of qemu_put_ram_ptr in pci_add_option_rom.

login
register
mail settings
Submitter Anthony PERARD
Date April 20, 2011, 4:42 p.m.
Message ID <1303317726-31855-14-git-send-email-anthony.perard@citrix.com>
Download mbox | patch
Permalink /patch/92248/
State New
Headers show

Comments

Anthony PERARD - April 20, 2011, 4:42 p.m.
From: John Baboval <john.baboval@virtualcomputer.com>

Prevent a deadlock caused by leaving a map cache bucket locked by the
preceding qemu_get_ram_ptr() call.

Signed-off-By: John Baboval <john.baboval@virtualcomputer.com>
Signed-off-by: Anthony PERARD <anthony.perard@citrix.com>
---
 hw/pci.c |    2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)

Patch

diff --git a/hw/pci.c b/hw/pci.c
index 6b577e1..2b24dd4 100644
--- a/hw/pci.c
+++ b/hw/pci.c
@@ -1897,6 +1897,8 @@  static int pci_add_option_rom(PCIDevice *pdev, bool is_default_rom)
         pci_patch_ids(pdev, ptr, size);
     }
 
+    qemu_put_ram_ptr(ptr);
+
     pci_register_bar(pdev, PCI_ROM_SLOT, size,
                      0, pci_map_option_rom);