[v3,4/4] configs: add linux boot logo to raspberrypi3 defconfig

Message ID 1527628939-7389-5-git-send-email-angelo@amarulasolutions.com
State Changes Requested
Headers show
Series
  • Linux custom logo
Related show

Commit Message

Angelo Compagnucci May 29, 2018, 9:22 p.m.
From: Angelo Compagnucci <angelo.compagnucci@gmail.com>

This patch adds a custom boot up logo to the raspberrypi3
defconfig.

Signed-off-by: Angelo Compagnucci <angelo@amarulasolutions.com>
---
 configs/raspberrypi3_defconfig | 1 +
 1 file changed, 1 insertion(+)

Comments

Yann E. MORIN June 30, 2018, 9 p.m. | #1
Angelo, All,

On 2018-05-29 23:22 +0200, Angelo Compagnucci spake thusly:
> From: Angelo Compagnucci <angelo.compagnucci@gmail.com>
> 
> This patch adds a custom boot up logo to the raspberrypi3
> defconfig.

Why the rpi3, and not the otehr configs?

Note that I don't mind much, but I'd like we be a bit consistent in all
our defconfigs. Either all the defconfigs use the BR logo, or none of
them do.

Regards,
Yann E. MORIN.

> Signed-off-by: Angelo Compagnucci <angelo@amarulasolutions.com>
> ---
>  configs/raspberrypi3_defconfig | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/configs/raspberrypi3_defconfig b/configs/raspberrypi3_defconfig
> index 45a76be..ed3d28d 100644
> --- a/configs/raspberrypi3_defconfig
> +++ b/configs/raspberrypi3_defconfig
> @@ -13,6 +13,7 @@ BR2_LINUX_KERNEL=y
>  BR2_LINUX_KERNEL_CUSTOM_TARBALL=y
>  BR2_LINUX_KERNEL_CUSTOM_TARBALL_LOCATION="$(call github,raspberrypi,linux,c117a8bccf37bfba323065b566cf999ed4629a4a)/linux-c117a8bccf37bfba323065b566cf999ed4629a4a.tar.gz"
>  BR2_LINUX_KERNEL_DEFCONFIG="bcm2709"
> +BR2_LINUX_KERNEL_CUSTOMLOGO_PATH="docs/images/logo_linux_clut224.png"
>  
>  # Build the DTB from the kernel sources
>  BR2_LINUX_KERNEL_DTS_SUPPORT=y
> -- 
> 2.7.4
> 
> _______________________________________________
> buildroot mailing list
> buildroot@busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot
Arnout Vandecappelle July 2, 2018, 11:13 p.m. | #2
On 30-06-18 23:00, Yann E. MORIN wrote:
> Angelo, All,
> 
> On 2018-05-29 23:22 +0200, Angelo Compagnucci spake thusly:
>> From: Angelo Compagnucci <angelo.compagnucci@gmail.com>
>>
>> This patch adds a custom boot up logo to the raspberrypi3
>> defconfig.
> 
> Why the rpi3, and not the otehr configs?
> 
> Note that I don't mind much, but I'd like we be a bit consistent in all
> our defconfigs. Either all the defconfigs use the BR logo, or none of
> them do.

 There just aren't many configs that have a framebuffer console. But indeed, it
would be good to add this to at least the pc and the qemu defconfigs.

 Regards,
 Arnout

Patch

diff --git a/configs/raspberrypi3_defconfig b/configs/raspberrypi3_defconfig
index 45a76be..ed3d28d 100644
--- a/configs/raspberrypi3_defconfig
+++ b/configs/raspberrypi3_defconfig
@@ -13,6 +13,7 @@  BR2_LINUX_KERNEL=y
 BR2_LINUX_KERNEL_CUSTOM_TARBALL=y
 BR2_LINUX_KERNEL_CUSTOM_TARBALL_LOCATION="$(call github,raspberrypi,linux,c117a8bccf37bfba323065b566cf999ed4629a4a)/linux-c117a8bccf37bfba323065b566cf999ed4629a4a.tar.gz"
 BR2_LINUX_KERNEL_DEFCONFIG="bcm2709"
+BR2_LINUX_KERNEL_CUSTOMLOGO_PATH="docs/images/logo_linux_clut224.png"
 
 # Build the DTB from the kernel sources
 BR2_LINUX_KERNEL_DTS_SUPPORT=y