From patchwork Tue May 29 11:45:16 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Wang Shilong X-Patchwork-Id: 922018 Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=vger.kernel.org (client-ip=209.132.180.67; helo=vger.kernel.org; envelope-from=linux-ext4-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="TiYldbpg"; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 40wBk56Qnxz9s0q for ; Tue, 29 May 2018 21:45:33 +1000 (AEST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933362AbeE2Lpd (ORCPT ); Tue, 29 May 2018 07:45:33 -0400 Received: from mail-pg0-f68.google.com ([74.125.83.68]:41705 "EHLO mail-pg0-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933363AbeE2Lpb (ORCPT ); Tue, 29 May 2018 07:45:31 -0400 Received: by mail-pg0-f68.google.com with SMTP id d14-v6so6479571pgv.8 for ; Tue, 29 May 2018 04:45:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=7zDmcRcjTUQU+mL8pkRTkthvGoViR16CsGOg+3fYxxY=; b=TiYldbpgZsW7zvLU9MG9dH2wBfUB219WR4gICuFaQgT32sV58ipt5W/UXYhMlm7bvv UNBnUO2jqUqXb5vfzS+igNVcoKhENbRiqzUXbNZmjogZ/WeZP/zFkh88VUDNxykR6NOT IO194OW/6yu+zUUa6OUichLFmP3KNresP6uCf2i3s6xCVxjLzswo/a9pgLw67NLwu7U2 jA6T2Cs0EWYo8uEo58ySdGsR3M4lADm1+r/Int3aiyOzpMkuCzWWKSpyqBumHi/SetMo qRVlt4xcU8PnR+0jiLiE1dIUVfcVVhcAHgFhARG8E2GhIoPM0XBJlPG4Y4Otbry0lf5T KUdA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=7zDmcRcjTUQU+mL8pkRTkthvGoViR16CsGOg+3fYxxY=; b=BspVNWXKzGI62dz7eyFQm3/sAmexD5pRiU0hjU7BgM8S/CYMfGNDmJ2fRY0PcBc6WK aFYOI9KRcW8QKFKMggI/cRw2hIMSPZ7YHuAxZ4ycoVdne7M/GvzfaX/zMqdyR4GwI6Cf G6+IrXAD3aXl64mwB5DJ004HT+qcPG2+OlqfmGJYyS6UANgU2wCJSayHky/krKpmI1cb qJA+stuPBL7uF5T24hXCj3bMPMmQ4VsYWQG0wtRWy+7DLv0k7tUwGx8pfKdYVv15i4WX ePe14w/4D6RWNsu7BR+Ih/XnlJx5sufNnMCuWnCJGiNPjnjQQ03gI2ck3aKr4xEIKjgc zuyw== X-Gm-Message-State: ALKqPwdNsxx76eUJlPubGEjWpnsbpSfZ1AqE+4VUJgE65asijVAd8eZ/ k7TsZMzvwd0INQdGlN4adKdMNA== X-Google-Smtp-Source: ADUXVKIwJOScCYY4uiPDIGonTBYpzgN6Y1pT4eeQBM8P8dD6mJjWjXOmayE3ciHqm8ua4FEpzYGuLA== X-Received: by 2002:a62:c45a:: with SMTP id y87-v6mr8481546pff.190.1527594330696; Tue, 29 May 2018 04:45:30 -0700 (PDT) Received: from localhost.localdomain (fs276ec80e.tkyc203.ap.nuro.jp. [39.110.200.14]) by smtp.gmail.com with ESMTPSA id s16-v6sm51226151pfm.114.2018.05.29.04.45.28 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 29 May 2018 04:45:29 -0700 (PDT) From: Wang Shilong X-Google-Original-From: Wang Shilong To: linux-ext4@vger.kernel.org Cc: andreas.dilger@intel.com, sihara@ddn.com, wshilong@ddn.com Subject: [PATCH 4/5] ext4: use ext4_warning() for sb_getblk failure Date: Tue, 29 May 2018 20:45:16 +0900 Message-Id: <1527594317-9214-4-git-send-email-wshilong1991@gmail.com> X-Mailer: git-send-email 1.7.1 In-Reply-To: <1527594317-9214-1-git-send-email-wshilong1991@gmail.com> References: <1527594317-9214-1-git-send-email-wshilong1991@gmail.com> Sender: linux-ext4-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-ext4@vger.kernel.org From: Wang Shilong out of memory should not be considered as critical errors, replace ext4_warnig() instead of ext4_error() for it. Signed-off-by: Wang Shilong Reviewed-by: Andreas Dilger --- fs/ext4/balloc.c | 6 +++--- fs/ext4/ialloc.c | 6 +++--- 2 files changed, 6 insertions(+), 6 deletions(-) diff --git a/fs/ext4/balloc.c b/fs/ext4/balloc.c index e3feeae..5fe63ff 100644 --- a/fs/ext4/balloc.c +++ b/fs/ext4/balloc.c @@ -428,9 +428,9 @@ struct buffer_head * } bh = sb_getblk(sb, bitmap_blk); if (unlikely(!bh)) { - ext4_error(sb, "Cannot get buffer for block bitmap - " - "block_group = %u, block_bitmap = %llu", - block_group, bitmap_blk); + ext4_warning(sb, "Cannot get buffer for block bitmap - " + "block_group = %u, block_bitmap = %llu", + block_group, bitmap_blk); return ERR_PTR(-ENOMEM); } diff --git a/fs/ext4/ialloc.c b/fs/ext4/ialloc.c index b7f7299..787b613 100644 --- a/fs/ext4/ialloc.c +++ b/fs/ext4/ialloc.c @@ -135,9 +135,9 @@ static int ext4_validate_inode_bitmap(struct super_block *sb, } bh = sb_getblk(sb, bitmap_blk); if (unlikely(!bh)) { - ext4_error(sb, "Cannot read inode bitmap - " - "block_group = %u, inode_bitmap = %llu", - block_group, bitmap_blk); + ext4_warning(sb, "Cannot read inode bitmap - " + "block_group = %u, inode_bitmap = %llu", + block_group, bitmap_blk); return ERR_PTR(-ENOMEM); } if (bitmap_uptodate(bh))