From patchwork Tue May 29 11:27:54 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jarkko Nikula X-Patchwork-Id: 922011 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=vger.kernel.org (client-ip=209.132.180.67; helo=vger.kernel.org; envelope-from=linux-i2c-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dmarc=none (p=none dis=none) header.from=linux.intel.com Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 40wBKS6kwvz9s08 for ; Tue, 29 May 2018 21:27:40 +1000 (AEST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933347AbeE2L1k (ORCPT ); Tue, 29 May 2018 07:27:40 -0400 Received: from mga11.intel.com ([192.55.52.93]:4098 "EHLO mga11.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932972AbeE2L1j (ORCPT ); Tue, 29 May 2018 07:27:39 -0400 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga003.jf.intel.com ([10.7.209.27]) by fmsmga102.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 29 May 2018 04:27:39 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.49,456,1520924400"; d="scan'208";a="54803720" Received: from mylly.fi.intel.com (HELO mylly.fi.intel.com.) ([10.237.72.76]) by orsmga003.jf.intel.com with ESMTP; 29 May 2018 04:27:38 -0700 From: Jarkko Nikula To: linux-i2c@vger.kernel.org Cc: Wolfram Sang , Andy Shevchenko , Mika Westerberg , Jarkko Nikula Subject: [PATCH 5/5] i2c: designware: Add debug print for bus speed Date: Tue, 29 May 2018 14:27:54 +0300 Message-Id: <20180529112754.13477-6-jarkko.nikula@linux.intel.com> X-Mailer: git-send-email 2.17.0 In-Reply-To: <20180529112754.13477-1-jarkko.nikula@linux.intel.com> References: <20180529112754.13477-1-jarkko.nikula@linux.intel.com> Sender: linux-i2c-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-i2c@vger.kernel.org Trivial added debug print for dev->clk_freq doesn't necessarily tell the actual bus speed or mode the controller is operating. For instance it may indicate 1 MHz Fast Mode Plus or 3.4 MHz High Speed but driver ends up using 400 kHz Fast Mode due missing timing parameters or missing support from HW. Add a debug print that prints the bus speed based on the validated speed that gets programmed into a HW. Signed-off-by: Jarkko Nikula --- drivers/i2c/busses/i2c-designware-master.c | 16 ++++++++++++++++ 1 file changed, 16 insertions(+) diff --git a/drivers/i2c/busses/i2c-designware-master.c b/drivers/i2c/busses/i2c-designware-master.c index b47aa919b377..af8dd4017a2d 100644 --- a/drivers/i2c/busses/i2c-designware-master.c +++ b/drivers/i2c/busses/i2c-designware-master.c @@ -49,6 +49,7 @@ static void i2c_dw_set_timings_master(struct dw_i2c_dev *dev) { u32 comp_param1; u32 sda_falling_time, scl_falling_time; + const char *mode_str; int ret = 0; ret = i2c_dw_acquire_lock(dev); @@ -133,6 +134,21 @@ static void i2c_dw_set_timings_master(struct dw_i2c_dev *dev) } i2c_dw_set_sda_hold(dev); + + switch (dev->master_cfg & DW_IC_CON_SPEED_MASK) { + case DW_IC_CON_SPEED_STD: + mode_str = "Standard Mode"; + break; + case DW_IC_CON_SPEED_HIGH: + mode_str = "High Speed Mode"; + break; + default: + if (dev->clk_freq == 1000000) + mode_str = "Fast Mode Plus"; + else + mode_str = "Fast Mode"; + } + dev_dbg(dev->dev, "Bus speed: %s\n", mode_str); } /**