| Message ID | 1527504600-26655-1-git-send-email-siva8118@gmail.com |
|---|---|
| State | New |
| Headers | show |
| Series | [SRU,Xenial,v2,1/2] UBUNTU: SAUCE: Redpine: fix for Soft-AP restart issue | expand |
Hi Siva, Well, the status has changed since my previous email on this thread.Because, the test kernel built with these patches still doesn't fix the issue, I'm not sure if these patches should be merged at all. /Shrirang On Thu, 2018-05-31 at 08:35 +0530, Siva Rebbagondla wrote: > Hi Shrirang, > > Just to cross check, As i able to see acknowledgment for my submitted patches in "https://lists.ubuntu.com/archives/kernel-team/2018-May/". > Do i need to resend the patches one again?. Please confirm this. > > Snippet from above URL, which shows ACK for submitted patches. > > ACK/cmnt: [SRU Xenial][v2][PATCH 1/2] UBUNTU: SAUCE: Redpine: fix for Soft-AP restart issue > > Shrirang Bagul > > > ACK/cmnt: [SRU Xenial][v2][PATCH 1/2] UBUNTU: SAUCE: Redpine: fix for Soft-AP restart issue > > Siva Rebbagondla > > > Thank you, > Siva Rebbagondla. > > On Tue, May 29, 2018 at 12:55 PM, Siva Rebbagondla <siva8118@gmail.com> wrote: > > Hi Shrirang, > > > > I just sent a subscription request to ubuntu kernel team. > > > > Thanks, > > Siva Rebbagondla > > > > On Tue, May 29, 2018 at 12:08 PM, Shrirang Bagul <shrirang.bagul@canonical.com> wrote: > > > Hi Siva, > > > > > > Looks like the email address you are using to send patches was not registered in the kernel-team@lists.ubuntu.com mailing list. > > > The patches submitted in this series are under moderation and won't get picked-up. > > > > > > Please subscribe to the list by following the registration process here: https://lists.ubuntu.com/mailman/listinfo/kernel-team and resend the > > > patches. > > > > > > /Shrirang > > > On Mon, 2018-05-28 at 18:34 +0530, Siva Rebbagondla wrote: > > > > On Mon, May 28, 2018 at 6:02 PM, Shrirang Bagul <shrirang.bagul@canonical.com> wrote: > > > > > On Mon, 2018-05-28 at 16:19 +0530, Siva Rebbagondla wrote: > > > > > > > > > > > From: Sanjay Kumar Konduri <sanjay.konduri@redpinesignals.com> > > > > > > > > > > > > > > > > > > > > > > BugLink: https://bugs.launchpad.net/ubuntu/+source/linux/+bug/1773400 > > > > > > > > > > > > > > > > > > > > > > Observed third party station is unable to scan redpine AP, when Soft-AP > > > > > > > > > > > restart command invoked. This is because power save is not disabled for > > > > > > > > > > > rsi Soft-AP mode in rsi_mac80211_tx(). > > > > > > > > > > > > > > > > > > > > > > Signed-off-by: Sanjay Kumar Konduri <sanjay.konduri@redpinesignals.com> > > > > > > > > > > > Signed-off-by: Siva Rebbagondla <siva.rebbagondla@redpinesignals.com> > > > > > > > > > > When you have multiple patches addressing different bugs, it's advisable to > > > > > > > > > > include a cover letter with a short explanation. Otherwise, everything looks > > > > > > > > > > okay. > > > > Sure Shrirang. I will follow cover letter format, in case of multiple patches submission. Thanks > > > > > > > > > > Acked-by: Shrirang Bagul <shrirang.bagul@canonical.com> > > > > > > > > > > > --- > > > > > > > > > > > v2: Changed the subject as per stable patch format [Shrirang]. > > > > > > > > > > > --- > > > > > > > > > > > ubuntu/rsi/rsi_91x_mac80211.c | 3 +-- > > > > > > > > > > > 1 file changed, 1 insertion(+), 2 deletions(-) > > > > > > > > > > > > > > > > > > > > > > diff --git a/ubuntu/rsi/rsi_91x_mac80211.c b/ubuntu/rsi/rsi_91x_mac80211.c > > > > > > > > > > > index 129859a..244ef27 100644 > > > > > > > > > > > --- a/ubuntu/rsi/rsi_91x_mac80211.c > > > > > > > > > > > +++ b/ubuntu/rsi/rsi_91x_mac80211.c > > > > > > > > > > > @@ -564,8 +564,7 @@ static void rsi_mac80211_tx(struct ieee80211_hw *hw, > > > > > > > > > > > return; > > > > > > > > > > > } > > > > > > > > > > > if ((!bss->assoc) && > > > > > > > > > > > - (adapter->ps_state == PS_ENABLED) && > > > > > > > > > > > - (vif->type == NL80211_IFTYPE_STATION)) > > > > > > > > > > > + (adapter->ps_state == PS_ENABLED)) > > > > > > > > > > > rsi_disable_ps(adapter); > > > > > > > > > > > if (ieee80211_is_auth(wlh->frame_control)) > > > > > > > > > > > common->mac_ops_resumed = false; <html><head></head><body><div>Hi Siva,</div><div><br></div><div>Well, the status has changed since my previous email on this thread.</div><div>Because, the test kernel built with these patches still doesn't fix the issue, I'm not sure if these patches should be merged at all.</div><div><br></div><div>/Shrirang</div><div><br></div><div>On Thu, 2018-05-31 at 08:35 +0530, Siva Rebbagondla wrote:</div><blockquote type="cite" style="margin:0 0 0 .8ex; border-left:2px #729fcf solid;padding-left:1ex"><div dir="ltr"><div class="gmail_default" style="color:rgb(7,55,99)">Hi Shrirang,<br><br></div><div class="gmail_default" style="color:rgb(7,55,99)">Just to cross check, As i able to see <span>acknowledgment for my </span>submitted patches in "<a href="https://lists.ubuntu.com/archives/kernel-team/2018-May/">https://lists.ubuntu.com/archives/kernel-team/2018-May/</a>".<br></div><div class="gmail_default" style="color:rgb(7,55,99)">Do i need to resend the patches one again?. Please confirm this.<br><br></div><div class="gmail_default" style="color:rgb(7,55,99)">Snippet from above URL, which shows ACK for submitted patches.<br></div><div class="gmail_default" style="color:rgb(7,55,99)"><br><a href="https://lists.ubuntu.com/archives/kernel-team/2018-May/092780.html">ACK/cmnt: [SRU Xenial][v2][PATCH 1/2] UBUNTU: SAUCE: Redpine: fix for Soft-AP restart issue </a><a name="92780"> </a> <i>Shrirang Bagul </i> <ul><li><a href="https://lists.ubuntu.com/archives/kernel-team/2018-May/092808.html">ACK/cmnt: [SRU Xenial][v2][PATCH 1/2] UBUNTU: SAUCE: Redpine: fix for Soft-AP restart issue </a><a name="92808"> </a> <i>Siva Rebbagondla</i><br></li></ul></div><div class="gmail_default" style="color:rgb(7,55,99)"><br></div><div class="gmail_default" style="color:rgb(7,55,99)">Thank you,<br></div><div class="gmail_default" style="color:rgb(7,55,99)">Siva Rebbagondla.<br></div></div><div class="gmail_extra"><br><div class="gmail_quote">On Tue, May 29, 2018 at 12:55 PM, Siva Rebbagondla <span dir="ltr"><<a href="mailto:siva8118@gmail.com" target="_blank">siva8118@gmail.com</a>></span> wrote:<br><blockquote type="cite" style="margin:0 0 0 .8ex; border-left:2px #729fcf solid;padding-left:1ex"><div dir="ltr"><div class="gmail_default" style="color:rgb(7,55,99)"><div class="gmail_default" style="color:rgb(7,55,99)">Hi Shrirang,<br><br></div><div class="gmail_default" style="color:rgb(7,55,99)">I just sent a subscription request to ubuntu kernel team.<br><br></div><div class="gmail_default" style="color:rgb(7,55,99)">Thanks,<br></div>Siva Rebbagondla</div></div><div class="HOEnZb"><div class="h5"><div class="gmail_extra"><br><div class="gmail_quote">On Tue, May 29, 2018 at 12:08 PM, Shrirang Bagul <span dir="ltr"><<a href="mailto:shrirang.bagul@canonical.com" target="_blank">shrirang.bagul@canonical.com</a>></span> wrote:<br><blockquote type="cite" style="margin:0 0 0 .8ex; border-left:2px #729fcf solid;padding-left:1ex"><div><div>Hi Siva,</div><div><br></div><div>Looks like the email address you are using to send patches was not registered in the <a style="white-space:nowrap"></a><a href="mailto:kernel-team@lists.ubuntu.com" target="_blank">kernel-team@lists.ubuntu.c<wbr>om</a> mailing list.</div><div>The patches submitted in this series are under moderation and won't get picked-up.</div><div><br></div><div>Please subscribe to the list by following the registration process here: <a href="https://lists.ubuntu.com/mailman/listinfo/kernel-team" target="_blank">https://lists.ubuntu.com/mailm<wbr>an/listinfo/kernel-team</a> and resend the patches.</div><span class="m_2659347294044964468HOEnZb"><font color="#888888"><div><br></div><div>/Shrirang</div></font></span><div><div class="m_2659347294044964468h5"><div><br></div><div>On Mon, 2018-05-28 at 18:34 +0530, Siva Rebbagondla wrote:</div><blockquote type="cite" style="margin:0 0 0 .8ex; border-left:2px #729fcf solid;padding-left:1ex"><div dir="ltr"><div class="gmail_extra"><div class="gmail_quote"><div style="color:rgb(7,55,99);display:inline" class="gmail_default"></div>On Mon, May 28, 2018 at 6:02 PM, Shrirang Bagul <span dir="ltr"><<a href="mailto:shrirang.bagul@canonical.com" target="_blank">shrirang.bagul@canonical.com</a>></span> wrote:<br><blockquote type="cite" style="margin:0 0 0 .8ex; border-left:2px #729fcf solid;padding-left:1ex">On Mon, 2018-05-28 at 16:19 +0530, Siva Rebbagondla wrote:<br> > From: Sanjay Kumar Konduri <<a href="mailto:sanjay.konduri@redpinesignals.com" target="_blank">sanjay.konduri@redpinesignals<wbr>.com</a>><br> > <br> > BugLink: <a href="https://bugs.launchpad.net/ubuntu/+source/linux/+bug/1773400" rel="noreferrer" target="_blank">https://bugs.launchpad.net/ubu<wbr>ntu/+source/linux/+bug/1773400</a><br> > <br> > Observed third party station is unable to scan redpine AP, when Soft-AP<br> > restart command invoked. This is because power save is not disabled for<br> > rsi Soft-AP mode in rsi_mac80211_tx().<br> > <br> > Signed-off-by: Sanjay Kumar Konduri <<a href="mailto:sanjay.konduri@redpinesignals.com" target="_blank">sanjay.konduri@redpinesignals<wbr>.com</a>><br> > Signed-off-by: Siva Rebbagondla <<a href="mailto:siva.rebbagondla@redpinesignals.com" target="_blank">siva.rebbagondla@redpinesigna<wbr>ls.com</a>><br> When you have multiple patches addressing different bugs, it's advisable to <br> include a cover letter with a short explanation. Otherwise, everything looks<br> okay.<br></blockquote><div><div style="color:rgb(7,55,99);display:inline" class="gmail_default"> Sure Shrirang. I will follow cover letter format, in case of multiple patches submission. Thanks </div> </div><blockquote type="cite" style="margin:0 0 0 .8ex; border-left:2px #729fcf solid;padding-left:1ex"> <br> Acked-by: Shrirang Bagul <<a href="mailto:shrirang.bagul@canonical.com" target="_blank">shrirang.bagul@canonical.com</a>><br> > ---<br> > v2: Changed the subject as per stable patch format [Shrirang].<br> > ---<br> > ubuntu/rsi/rsi_91x_mac80211.c | 3 +--<br> > 1 file changed, 1 insertion(+), 2 deletions(-)<br> > <br> > diff --git a/ubuntu/rsi/rsi_91x_mac80211.<wbr>c b/ubuntu/rsi/rsi_91x_mac80211.<wbr>c<br> > index 129859a..244ef27 100644<br> > --- a/ubuntu/rsi/rsi_91x_mac80211.<wbr>c<br> > +++ b/ubuntu/rsi/rsi_91x_mac80211.<wbr>c<br> > @@ -564,8 +564,7 @@ static void rsi_mac80211_tx(struct ieee80211_hw *hw,<br> > return;<br> > }<br> > if ((!bss->assoc) &&<br> > - (adapter->ps_state == PS_ENABLED) &&<br> > - (vif->type == NL80211_IFTYPE_STATION))<br> > + (adapter->ps_state == PS_ENABLED))<br> > rsi_disable_ps(adapter);<br> > if (ieee80211_is_auth(wlh->frame_<wbr>control))<br> > common->mac_ops_resumed = false;</blockquote></div><br></div></div> </blockquote></div></div></div></blockquote></div><br></div> </div></div></blockquote></div><br></div> </blockquote></body></html>
Thanks for the update. And you are confirming that soft-ap is not fixed in ubuntu-xenial , after reboot. Is that correct?. Can you please share us the xenial os image which contain latest 2 patches?. This helps us to debug more deep into the issue. Best regards, Siva Rebbagondla On Thu 31 May, 2018, 9:03 AM Shrirang Bagul, <shrirang.bagul@canonical.com> wrote: > Hi Siva, > > Well, the status has changed since my previous email on this thread. > Because, the test kernel built with these patches still doesn't fix the > issue, I'm not sure if these patches should be merged at all. > > /Shrirang > > On Thu, 2018-05-31 at 08:35 +0530, Siva Rebbagondla wrote: > > Hi Shrirang, > > Just to cross check, As i able to see acknowledgment for my submitted > patches in "https://lists.ubuntu.com/archives/kernel-team/2018-May/". > Do i need to resend the patches one again?. Please confirm this. > > Snippet from above URL, which shows ACK for submitted patches. > > ACK/cmnt: [SRU Xenial][v2][PATCH 1/2] UBUNTU: SAUCE: Redpine: fix for > Soft-AP restart issue > <https://lists.ubuntu.com/archives/kernel-team/2018-May/092780.html> *Shrirang > Bagul * > > - ACK/cmnt: [SRU Xenial][v2][PATCH 1/2] UBUNTU: SAUCE: Redpine: fix > for Soft-AP restart issue > <https://lists.ubuntu.com/archives/kernel-team/2018-May/092808.html> *Siva > Rebbagondla* > > > Thank you, > Siva Rebbagondla. > > On Tue, May 29, 2018 at 12:55 PM, Siva Rebbagondla <siva8118@gmail.com> > wrote: > > Hi Shrirang, > > I just sent a subscription request to ubuntu kernel team. > > Thanks, > Siva Rebbagondla > > On Tue, May 29, 2018 at 12:08 PM, Shrirang Bagul < > shrirang.bagul@canonical.com> wrote: > > Hi Siva, > > Looks like the email address you are using to send patches was not > registered in the kernel-team@lists.ubuntu.com mailing list. > The patches submitted in this series are under moderation and won't get > picked-up. > > Please subscribe to the list by following the registration process here: > https://lists.ubuntu.com/mailman/listinfo/kernel-team and resend the > patches. > > /Shrirang > > On Mon, 2018-05-28 at 18:34 +0530, Siva Rebbagondla wrote: > > On Mon, May 28, 2018 at 6:02 PM, Shrirang Bagul < > shrirang.bagul@canonical.com> wrote: > > On Mon, 2018-05-28 at 16:19 +0530, Siva Rebbagondla wrote: > > From: Sanjay Kumar Konduri <sanjay.konduri@redpinesignals.com> > > > > BugLink: https://bugs.launchpad.net/ubuntu/+source/linux/+bug/1773400 > > > > Observed third party station is unable to scan redpine AP, when Soft-AP > > restart command invoked. This is because power save is not disabled for > > rsi Soft-AP mode in rsi_mac80211_tx(). > > > > Signed-off-by: Sanjay Kumar Konduri <sanjay.konduri@redpinesignals.com> > > Signed-off-by: Siva Rebbagondla <siva.rebbagondla@redpinesignals.com> > When you have multiple patches addressing different bugs, it's advisable > to > include a cover letter with a short explanation. Otherwise, everything > looks > okay. > > Sure Shrirang. I will follow cover letter format, in case of multiple > patches submission. Thanks > > > > Acked-by: Shrirang Bagul <shrirang.bagul@canonical.com> > > --- > > v2: Changed the subject as per stable patch format [Shrirang]. > > --- > > ubuntu/rsi/rsi_91x_mac80211.c | 3 +-- > > 1 file changed, 1 insertion(+), 2 deletions(-) > > > > diff --git a/ubuntu/rsi/rsi_91x_mac80211.c > b/ubuntu/rsi/rsi_91x_mac80211.c > > index 129859a..244ef27 100644 > > --- a/ubuntu/rsi/rsi_91x_mac80211.c > > +++ b/ubuntu/rsi/rsi_91x_mac80211.c > > @@ -564,8 +564,7 @@ static void rsi_mac80211_tx(struct ieee80211_hw *hw, > > return; > > } > > if ((!bss->assoc) && > > - (adapter->ps_state == PS_ENABLED) && > > - (vif->type == NL80211_IFTYPE_STATION)) > > + (adapter->ps_state == PS_ENABLED)) > > rsi_disable_ps(adapter); > > if (ieee80211_is_auth(wlh->frame_control)) > > common->mac_ops_resumed = false; > > > > > <div dir="auto">Thanks for the update. <div dir="auto">And you are confirming that soft-ap is not fixed in ubuntu-xenial , after reboot. Is that correct?.</div><div dir="auto"><br></div><div dir="auto">Can you please share us the xenial os image which contain latest 2 patches?. This helps us to debug more deep into the issue.</div><div dir="auto"><br></div><div dir="auto">Best regards,</div><div dir="auto">Siva Rebbagondla</div></div><br><div class="gmail_quote"><div dir="ltr">On Thu 31 May, 2018, 9:03 AM Shrirang Bagul, <<a href="mailto:shrirang.bagul@canonical.com">shrirang.bagul@canonical.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div><div>Hi Siva,</div><div><br></div><div>Well, the status has changed since my previous email on this thread.</div><div>Because, the test kernel built with these patches still doesn't fix the issue, I'm not sure if these patches should be merged at all.</div><div><br></div><div>/Shrirang</div><div><br></div><div>On Thu, 2018-05-31 at 08:35 +0530, Siva Rebbagondla wrote:</div><blockquote type="cite" style="margin:0 0 0 .8ex;border-left:2px #729fcf solid;padding-left:1ex"><div dir="ltr"><div class="gmail_default" style="color:rgb(7,55,99)">Hi Shrirang,<br><br></div><div class="gmail_default" style="color:rgb(7,55,99)">Just to cross check, As i able to see <span>acknowledgment for my </span>submitted patches in "<a href="https://lists.ubuntu.com/archives/kernel-team/2018-May/" target="_blank" rel="noreferrer">https://lists.ubuntu.com/archives/kernel-team/2018-May/</a>".<br></div><div class="gmail_default" style="color:rgb(7,55,99)">Do i need to resend the patches one again?. Please confirm this.<br><br></div><div class="gmail_default" style="color:rgb(7,55,99)">Snippet from above URL, which shows ACK for submitted patches.<br></div><div class="gmail_default" style="color:rgb(7,55,99)"><br><a href="https://lists.ubuntu.com/archives/kernel-team/2018-May/092780.html" target="_blank" rel="noreferrer">ACK/cmnt: [SRU Xenial][v2][PATCH 1/2] UBUNTU: SAUCE: Redpine: fix for Soft-AP restart issue </a><a name="m_-5328489051022161205_92780" rel="noreferrer"> </a> <i>Shrirang Bagul </i> <ul><li><a href="https://lists.ubuntu.com/archives/kernel-team/2018-May/092808.html" target="_blank" rel="noreferrer">ACK/cmnt: [SRU Xenial][v2][PATCH 1/2] UBUNTU: SAUCE: Redpine: fix for Soft-AP restart issue </a><a name="m_-5328489051022161205_92808" rel="noreferrer"> </a> <i>Siva Rebbagondla</i><br></li></ul></div><div class="gmail_default" style="color:rgb(7,55,99)"><br></div><div class="gmail_default" style="color:rgb(7,55,99)">Thank you,<br></div><div class="gmail_default" style="color:rgb(7,55,99)">Siva Rebbagondla.<br></div></div><div class="gmail_extra"><br><div class="gmail_quote">On Tue, May 29, 2018 at 12:55 PM, Siva Rebbagondla <span dir="ltr"><<a href="mailto:siva8118@gmail.com" target="_blank" rel="noreferrer">siva8118@gmail.com</a>></span> wrote:<br><blockquote type="cite" style="margin:0 0 0 .8ex;border-left:2px #729fcf solid;padding-left:1ex"><div dir="ltr"><div class="gmail_default" style="color:rgb(7,55,99)"><div class="gmail_default" style="color:rgb(7,55,99)">Hi Shrirang,<br><br></div><div class="gmail_default" style="color:rgb(7,55,99)">I just sent a subscription request to ubuntu kernel team.<br><br></div><div class="gmail_default" style="color:rgb(7,55,99)">Thanks,<br></div>Siva Rebbagondla</div></div><div class="m_-5328489051022161205HOEnZb"><div class="m_-5328489051022161205h5"><div class="gmail_extra"><br><div class="gmail_quote">On Tue, May 29, 2018 at 12:08 PM, Shrirang Bagul <span dir="ltr"><<a href="mailto:shrirang.bagul@canonical.com" target="_blank" rel="noreferrer">shrirang.bagul@canonical.com</a>></span> wrote:<br><blockquote type="cite" style="margin:0 0 0 .8ex;border-left:2px #729fcf solid;padding-left:1ex"><div><div>Hi Siva,</div><div><br></div><div>Looks like the email address you are using to send patches was not registered in the <a style="white-space:nowrap" rel="noreferrer"></a><a href="mailto:kernel-team@lists.ubuntu.com" target="_blank" rel="noreferrer">kernel-team@lists.ubuntu.com</a> mailing list.</div><div>The patches submitted in this series are under moderation and won't get picked-up.</div><div><br></div><div>Please subscribe to the list by following the registration process here: <a href="https://lists.ubuntu.com/mailman/listinfo/kernel-team" target="_blank" rel="noreferrer">https://lists.ubuntu.com/mailman/listinfo/kernel-team</a> and resend the patches.</div><span class="m_-5328489051022161205m_2659347294044964468HOEnZb"><font color="#888888"><div><br></div><div>/Shrirang</div></font></span><div><div class="m_-5328489051022161205m_2659347294044964468h5"><div><br></div><div>On Mon, 2018-05-28 at 18:34 +0530, Siva Rebbagondla wrote:</div><blockquote type="cite" style="margin:0 0 0 .8ex;border-left:2px #729fcf solid;padding-left:1ex"><div dir="ltr"><div class="gmail_extra"><div class="gmail_quote"><div style="color:rgb(7,55,99);display:inline" class="gmail_default"></div>On Mon, May 28, 2018 at 6:02 PM, Shrirang Bagul <span dir="ltr"><<a href="mailto:shrirang.bagul@canonical.com" target="_blank" rel="noreferrer">shrirang.bagul@canonical.com</a>></span> wrote:<br><blockquote type="cite" style="margin:0 0 0 .8ex;border-left:2px #729fcf solid;padding-left:1ex">On Mon, 2018-05-28 at 16:19 +0530, Siva Rebbagondla wrote:<br> > From: Sanjay Kumar Konduri <<a href="mailto:sanjay.konduri@redpinesignals.com" target="_blank" rel="noreferrer">sanjay.konduri@redpinesignals.com</a>><br> > <br> > BugLink: <a href="https://bugs.launchpad.net/ubuntu/+source/linux/+bug/1773400" rel="noreferrer noreferrer" target="_blank">https://bugs.launchpad.net/ubuntu/+source/linux/+bug/1773400</a><br> > <br> > Observed third party station is unable to scan redpine AP, when Soft-AP<br> > restart command invoked. This is because power save is not disabled for<br> > rsi Soft-AP mode in rsi_mac80211_tx().<br> > <br> > Signed-off-by: Sanjay Kumar Konduri <<a href="mailto:sanjay.konduri@redpinesignals.com" target="_blank" rel="noreferrer">sanjay.konduri@redpinesignals.com</a>><br> > Signed-off-by: Siva Rebbagondla <<a href="mailto:siva.rebbagondla@redpinesignals.com" target="_blank" rel="noreferrer">siva.rebbagondla@redpinesignals.com</a>><br> When you have multiple patches addressing different bugs, it's advisable to <br> include a cover letter with a short explanation. Otherwise, everything looks<br> okay.<br></blockquote><div><div style="color:rgb(7,55,99);display:inline" class="gmail_default"> Sure Shrirang. I will follow cover letter format, in case of multiple patches submission. Thanks </div> </div><blockquote type="cite" style="margin:0 0 0 .8ex;border-left:2px #729fcf solid;padding-left:1ex"> <br> Acked-by: Shrirang Bagul <<a href="mailto:shrirang.bagul@canonical.com" target="_blank" rel="noreferrer">shrirang.bagul@canonical.com</a>><br> > ---<br> > v2: Changed the subject as per stable patch format [Shrirang].<br> > ---<br> > ubuntu/rsi/rsi_91x_mac80211.c | 3 +--<br> > 1 file changed, 1 insertion(+), 2 deletions(-)<br> > <br> > diff --git a/ubuntu/rsi/rsi_91x_mac80211.c b/ubuntu/rsi/rsi_91x_mac80211.c<br> > index 129859a..244ef27 100644<br> > --- a/ubuntu/rsi/rsi_91x_mac80211.c<br> > +++ b/ubuntu/rsi/rsi_91x_mac80211.c<br> > @@ -564,8 +564,7 @@ static void rsi_mac80211_tx(struct ieee80211_hw *hw,<br> > return;<br> > }<br> > if ((!bss->assoc) &&<br> > - (adapter->ps_state == PS_ENABLED) &&<br> > - (vif->type == NL80211_IFTYPE_STATION))<br> > + (adapter->ps_state == PS_ENABLED))<br> > rsi_disable_ps(adapter);<br> > if (ieee80211_is_auth(wlh->frame_control))<br> > common->mac_ops_resumed = false;</blockquote></div><br></div></div> </blockquote></div></div></div></blockquote></div><br></div> </div></div></blockquote></div><br></div> </blockquote></div></blockquote></div>
Hi Siva, Let's continue the discussion on the bug: https://bugs.launchpad.net/plano/+bug/1769225 and not on the mailing list.See my comment. https://bugs.launc hpad.net/plano/+bug/1769225/comments/66 /ShrirangOn Thu, 2018-05-31 at 09:09 +0530, Siva Rebbagondla wrote: > Thanks for the update. And you are confirming that soft-ap is not fixed in ubuntu-xenial , after reboot. Is that correct?. > > Can you please share us the xenial os image which contain latest 2 patches?. This helps us to debug more deep into the issue. > > Best regards, > Siva Rebbagondla > On Thu 31 May, 2018, 9:03 AM Shrirang Bagul, <shrirang.bagul@canonical.com> wrote: > > Hi Siva, > > Well, the status has changed since my previous email on this thread.Because, the test kernel built with these patches still doesn't fix the issue, > > I'm not sure if these patches should be merged at all. > > /Shrirang > > On Thu, 2018-05-31 at 08:35 +0530, Siva Rebbagondla wrote: > > > Hi Shrirang, > > > > > > Just to cross check, As i able to see acknowledgment for my submitted patches in "https://lists.ubuntu.com/archives/kernel-team/2018-May/". > > > Do i need to resend the patches one again?. Please confirm this. > > > > > > Snippet from above URL, which shows ACK for submitted patches. > > > > > > ACK/cmnt: [SRU Xenial][v2][PATCH 1/2] UBUNTU: SAUCE: Redpine: fix for Soft-AP restart issue > > > > > > Shrirang Bagul > > > > > > > > > ACK/cmnt: [SRU Xenial][v2][PATCH 1/2] UBUNTU: SAUCE: Redpine: fix for Soft-AP restart issue > > > > > > Siva Rebbagondla > > > > > > > > > Thank you, > > > Siva Rebbagondla. > > > > > > On Tue, May 29, 2018 at 12:55 PM, Siva Rebbagondla <siva8118@gmail.com> wrote: > > > > Hi Shrirang, > > > > > > > > I just sent a subscription request to ubuntu kernel team. > > > > > > > > Thanks, > > > > Siva Rebbagondla > > > > > > > > On Tue, May 29, 2018 at 12:08 PM, Shrirang Bagul <shrirang.bagul@canonical.com> wrote: > > > > > Hi Siva, > > > > > > > > > > Looks like the email address you are using to send patches was not registered in the kernel-team@lists.ubuntu.com mailing list. > > > > > The patches submitted in this series are under moderation and won't get picked-up. > > > > > > > > > > Please subscribe to the list by following the registration process here: https://lists.ubuntu.com/mailman/listinfo/kernel-team and resend > > > > > the patches. > > > > > > > > > > /Shrirang > > > > > On Mon, 2018-05-28 at 18:34 +0530, Siva Rebbagondla wrote: > > > > > > On Mon, May 28, 2018 at 6:02 PM, Shrirang Bagul <shrirang.bagul@canonical.com> wrote: > > > > > > > On Mon, 2018-05-28 at 16:19 +0530, Siva Rebbagondla wrote: > > > > > > > > > > > > > > > From: Sanjay Kumar Konduri <sanjay.konduri@redpinesignals.com> > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > BugLink: https://bugs.launchpad.net/ubuntu/+source/linux/+bug/1773400 > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > Observed third party station is unable to scan redpine AP, when Soft-AP > > > > > > > > > > > > > > > restart command invoked. This is because power save is not disabled for > > > > > > > > > > > > > > > rsi Soft-AP mode in rsi_mac80211_tx(). > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > Signed-off-by: Sanjay Kumar Konduri <sanjay.konduri@redpinesignals.com> > > > > > > > > > > > > > > > Signed-off-by: Siva Rebbagondla <siva.rebbagondla@redpinesignals.com> > > > > > > > > > > > > > > When you have multiple patches addressing different bugs, it's advisable to > > > > > > > > > > > > > > include a cover letter with a short explanation. Otherwise, everything looks > > > > > > > > > > > > > > okay. > > > > > > Sure Shrirang. I will follow cover letter format, in case of multiple patches submission. Thanks > > > > > > > > > > > > > > Acked-by: Shrirang Bagul <shrirang.bagul@canonical.com> > > > > > > > > > > > > > > > --- > > > > > > > > > > > > > > > v2: Changed the subject as per stable patch format [Shrirang]. > > > > > > > > > > > > > > > --- > > > > > > > > > > > > > > > ubuntu/rsi/rsi_91x_mac80211.c | 3 +-- > > > > > > > > > > > > > > > 1 file changed, 1 insertion(+), 2 deletions(-) > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > diff --git a/ubuntu/rsi/rsi_91x_mac80211.c b/ubuntu/rsi/rsi_91x_mac80211.c > > > > > > > > > > > > > > > index 129859a..244ef27 100644 > > > > > > > > > > > > > > > --- a/ubuntu/rsi/rsi_91x_mac80211.c > > > > > > > > > > > > > > > +++ b/ubuntu/rsi/rsi_91x_mac80211.c > > > > > > > > > > > > > > > @@ -564,8 +564,7 @@ static void rsi_mac80211_tx(struct ieee80211_hw *hw, > > > > > > > > > > > > > > > return; > > > > > > > > > > > > > > > } > > > > > > > > > > > > > > > if ((!bss->assoc) && > > > > > > > > > > > > > > > - (adapter->ps_state == PS_ENABLED) && > > > > > > > > > > > > > > > - (vif->type == NL80211_IFTYPE_STATION)) > > > > > > > > > > > > > > > + (adapter->ps_state == PS_ENABLED)) > > > > > > > > > > > > > > > rsi_disable_ps(adapter); > > > > > > > > > > > > > > > if (ieee80211_is_auth(wlh->frame_control)) > > > > > > > > > > > > > > > common->mac_ops_resumed = false; <html><head></head><body><div>Hi Siva,</div><div><br></div><div>Let's continue the discussion on the bug: <a href="https://bugs.launchpad.net/plano/+bug/1769225">https://bugs.launchpad.net/plano/+bug/1769225</a> and not on the mailing list.</div><div>See my comment. <a href="https://bugs.launchpad.net/plano/+bug/1769225/comments/66">https://bugs.launchpad.net/plano/+bug/1769225/comments/66</a></div><div><br></div><div>/Shrirang</div><div>On Thu, 2018-05-31 at 09:09 +0530, Siva Rebbagondla wrote:</div><blockquote type="cite" style="margin:0 0 0 .8ex; border-left:2px #729fcf solid;padding-left:1ex"><div dir="auto">Thanks for the update. <div dir="auto">And you are confirming that soft-ap is not fixed in ubuntu-xenial , after reboot. Is that correct?.</div><div dir="auto"><br></div><div dir="auto">Can you please share us the xenial os image which contain latest 2 patches?. This helps us to debug more deep into the issue.</div><div dir="auto"><br></div><div dir="auto">Best regards,</div><div dir="auto">Siva Rebbagondla</div></div><br><div class="gmail_quote"><div dir="ltr">On Thu 31 May, 2018, 9:03 AM Shrirang Bagul, <<a href="mailto:shrirang.bagul@canonical.com">shrirang.bagul@canonical.com</a>> wrote:<br></div><blockquote type="cite" style="margin:0 0 0 .8ex; border-left:2px #729fcf solid;padding-left:1ex"><div><div>Hi Siva,</div><div><br></div><div>Well, the status has changed since my previous email on this thread.</div><div>Because, the test kernel built with these patches still doesn't fix the issue, I'm not sure if these patches should be merged at all.</div><div><br></div><div>/Shrirang</div><div><br></div><div>On Thu, 2018-05-31 at 08:35 +0530, Siva Rebbagondla wrote:</div><blockquote type="cite" style="margin:0 0 0 .8ex; border-left:2px #729fcf solid;padding-left:1ex"><div dir="ltr"><div class="gmail_default" style="color:rgb(7,55,99)">Hi Shrirang,<br><br></div><div class="gmail_default" style="color:rgb(7,55,99)">Just to cross check, As i able to see <span>acknowledgment for my </span>submitted patches in "<a href="https://lists.ubuntu.com/archives/kernel-team/2018-May/" target="_blank" rel="noreferrer">https://lists.ubuntu.com/archives/kernel-team/2018-May/</a>".<br></div><div class="gmail_default" style="color:rgb(7,55,99)">Do i need to resend the patches one again?. Please confirm this.<br><br></div><div class="gmail_default" style="color:rgb(7,55,99)">Snippet from above URL, which shows ACK for submitted patches.<br></div><div class="gmail_default" style="color:rgb(7,55,99)"><br><a href="https://lists.ubuntu.com/archives/kernel-team/2018-May/092780.html" target="_blank" rel="noreferrer">ACK/cmnt: [SRU Xenial][v2][PATCH 1/2] UBUNTU: SAUCE: Redpine: fix for Soft-AP restart issue </a><a name="m_-5328489051022161205_92780" rel="noreferrer"> </a> <i>Shrirang Bagul </i> <ul><li><a href="https://lists.ubuntu.com/archives/kernel-team/2018-May/092808.html" target="_blank" rel="noreferrer">ACK/cmnt: [SRU Xenial][v2][PATCH 1/2] UBUNTU: SAUCE: Redpine: fix for Soft-AP restart issue </a><a name="m_-5328489051022161205_92808" rel="noreferrer"> </a> <i>Siva Rebbagondla</i><br></li></ul></div><div class="gmail_default" style="color:rgb(7,55,99)"><br></div><div class="gmail_default" style="color:rgb(7,55,99)">Thank you,<br></div><div class="gmail_default" style="color:rgb(7,55,99)">Siva Rebbagondla.<br></div></div><div class="gmail_extra"><br><div class="gmail_quote">On Tue, May 29, 2018 at 12:55 PM, Siva Rebbagondla <span dir="ltr"><<a href="mailto:siva8118@gmail.com" target="_blank" rel="noreferrer">siva8118@gmail.com</a>></span> wrote:<br><blockquote type="cite" style="margin:0 0 0 .8ex; border-left:2px #729fcf solid;padding-left:1ex"><div dir="ltr"><div class="gmail_default" style="color:rgb(7,55,99)"><div class="gmail_default" style="color:rgb(7,55,99)">Hi Shrirang,<br><br></div><div class="gmail_default" style="color:rgb(7,55,99)">I just sent a subscription request to ubuntu kernel team.<br><br></div><div class="gmail_default" style="color:rgb(7,55,99)">Thanks,<br></div>Siva Rebbagondla</div></div><div class="m_-5328489051022161205HOEnZb"><div class="m_-5328489051022161205h5"><div class="gmail_extra"><br><div class="gmail_quote">On Tue, May 29, 2018 at 12:08 PM, Shrirang Bagul <span dir="ltr"><<a href="mailto:shrirang.bagul@canonical.com" target="_blank" rel="noreferrer">shrirang.bagul@canonical.com</a>></span> wrote:<br><blockquote type="cite" style="margin:0 0 0 .8ex; border-left:2px #729fcf solid;padding-left:1ex"><div><div>Hi Siva,</div><div><br></div><div>Looks like the email address you are using to send patches was not registered in the <a style="white-space:nowrap" rel="noreferrer"></a><a href="mailto:kernel-team@lists.ubuntu.com" target="_blank" rel="noreferrer">kernel-team@lists.ubuntu.com</a> mailing list.</div><div>The patches submitted in this series are under moderation and won't get picked-up.</div><div><br></div><div>Please subscribe to the list by following the registration process here: <a href="https://lists.ubuntu.com/mailman/listinfo/kernel-team" target="_blank" rel="noreferrer">https://lists.ubuntu.com/mailman/listinfo/kernel-team</a> and resend the patches.</div><span class="m_-5328489051022161205m_2659347294044964468HOEnZb"><font color="#888888"><div><br></div><div>/Shrirang</div></font></span><div><div class="m_-5328489051022161205m_2659347294044964468h5"><div><br></div><div>On Mon, 2018-05-28 at 18:34 +0530, Siva Rebbagondla wrote:</div><blockquote type="cite" style="margin:0 0 0 .8ex; border-left:2px #729fcf solid;padding-left:1ex"><div dir="ltr"><div class="gmail_extra"><div class="gmail_quote"><div style="color:rgb(7,55,99);display:inline" class="gmail_default"></div>On Mon, May 28, 2018 at 6:02 PM, Shrirang Bagul <span dir="ltr"><<a href="mailto:shrirang.bagul@canonical.com" target="_blank" rel="noreferrer">shrirang.bagul@canonical.com</a>></span> wrote:<br><blockquote type="cite" style="margin:0 0 0 .8ex; border-left:2px #729fcf solid;padding-left:1ex">On Mon, 2018-05-28 at 16:19 +0530, Siva Rebbagondla wrote:<br> > From: Sanjay Kumar Konduri <<a href="mailto:sanjay.konduri@redpinesignals.com" target="_blank" rel="noreferrer">sanjay.konduri@redpinesignals.com</a>><br> > <br> > BugLink: <a href="https://bugs.launchpad.net/ubuntu/+source/linux/+bug/1773400" rel="noreferrer noreferrer" target="_blank">https://bugs.launchpad.net/ubuntu/+source/linux/+bug/1773400</a><br> > <br> > Observed third party station is unable to scan redpine AP, when Soft-AP<br> > restart command invoked. This is because power save is not disabled for<br> > rsi Soft-AP mode in rsi_mac80211_tx().<br> > <br> > Signed-off-by: Sanjay Kumar Konduri <<a href="mailto:sanjay.konduri@redpinesignals.com" target="_blank" rel="noreferrer">sanjay.konduri@redpinesignals.com</a>><br> > Signed-off-by: Siva Rebbagondla <<a href="mailto:siva.rebbagondla@redpinesignals.com" target="_blank" rel="noreferrer">siva.rebbagondla@redpinesignals.com</a>><br> When you have multiple patches addressing different bugs, it's advisable to <br> include a cover letter with a short explanation. Otherwise, everything looks<br> okay.<br></blockquote><div><div style="color:rgb(7,55,99);display:inline" class="gmail_default"> Sure Shrirang. I will follow cover letter format, in case of multiple patches submission. Thanks </div> </div><blockquote type="cite" style="margin:0 0 0 .8ex; border-left:2px #729fcf solid;padding-left:1ex"> <br> Acked-by: Shrirang Bagul <<a href="mailto:shrirang.bagul@canonical.com" target="_blank" rel="noreferrer">shrirang.bagul@canonical.com</a>><br> > ---<br> > v2: Changed the subject as per stable patch format [Shrirang].<br> > ---<br> > ubuntu/rsi/rsi_91x_mac80211.c | 3 +--<br> > 1 file changed, 1 insertion(+), 2 deletions(-)<br> > <br> > diff --git a/ubuntu/rsi/rsi_91x_mac80211.c b/ubuntu/rsi/rsi_91x_mac80211.c<br> > index 129859a..244ef27 100644<br> > --- a/ubuntu/rsi/rsi_91x_mac80211.c<br> > +++ b/ubuntu/rsi/rsi_91x_mac80211.c<br> > @@ -564,8 +564,7 @@ static void rsi_mac80211_tx(struct ieee80211_hw *hw,<br> > return;<br> > }<br> > if ((!bss->assoc) &&<br> > - (adapter->ps_state == PS_ENABLED) &&<br> > - (vif->type == NL80211_IFTYPE_STATION))<br> > + (adapter->ps_state == PS_ENABLED))<br> > rsi_disable_ps(adapter);<br> > if (ieee80211_is_auth(wlh->frame_control))<br> > common->mac_ops_resumed = false;</blockquote></div><br></div></div> </blockquote></div></div></div></blockquote></div><br></div> </div></div></blockquote></div><br></div> </blockquote></div></blockquote></div> </blockquote></body></html>
OK Shrirang. Thanks On Thu 31 May, 2018, 9:32 AM Shrirang Bagul, <shrirang.bagul@canonical.com> wrote: > Hi Siva, > > Let's continue the discussion on the bug: > https://bugs.launchpad.net/plano/+bug/1769225 and not on the mailing list. > See my comment. https://bugs.launchpad.net/plano/+bug/1769225/comments/66 > > /Shrirang > On Thu, 2018-05-31 at 09:09 +0530, Siva Rebbagondla wrote: > > Thanks for the update. > And you are confirming that soft-ap is not fixed in ubuntu-xenial , after > reboot. Is that correct?. > > Can you please share us the xenial os image which contain latest 2 > patches?. This helps us to debug more deep into the issue. > > Best regards, > Siva Rebbagondla > > On Thu 31 May, 2018, 9:03 AM Shrirang Bagul, <shrirang.bagul@canonical.com> > wrote: > > Hi Siva, > > Well, the status has changed since my previous email on this thread. > Because, the test kernel built with these patches still doesn't fix the > issue, I'm not sure if these patches should be merged at all. > > /Shrirang > > On Thu, 2018-05-31 at 08:35 +0530, Siva Rebbagondla wrote: > > Hi Shrirang, > > Just to cross check, As i able to see acknowledgment for my submitted > patches in "https://lists.ubuntu.com/archives/kernel-team/2018-May/". > Do i need to resend the patches one again?. Please confirm this. > > Snippet from above URL, which shows ACK for submitted patches. > > ACK/cmnt: [SRU Xenial][v2][PATCH 1/2] UBUNTU: SAUCE: Redpine: fix for > Soft-AP restart issue > <https://lists.ubuntu.com/archives/kernel-team/2018-May/092780.html> *Shrirang > Bagul * > > - ACK/cmnt: [SRU Xenial][v2][PATCH 1/2] UBUNTU: SAUCE: Redpine: fix > for Soft-AP restart issue > <https://lists.ubuntu.com/archives/kernel-team/2018-May/092808.html> *Siva > Rebbagondla* > > > Thank you, > Siva Rebbagondla. > > On Tue, May 29, 2018 at 12:55 PM, Siva Rebbagondla <siva8118@gmail.com> > wrote: > > Hi Shrirang, > > I just sent a subscription request to ubuntu kernel team. > > Thanks, > Siva Rebbagondla > > On Tue, May 29, 2018 at 12:08 PM, Shrirang Bagul < > shrirang.bagul@canonical.com> wrote: > > Hi Siva, > > Looks like the email address you are using to send patches was not > registered in the kernel-team@lists.ubuntu.com mailing list. > The patches submitted in this series are under moderation and won't get > picked-up. > > Please subscribe to the list by following the registration process here: > https://lists.ubuntu.com/mailman/listinfo/kernel-team and resend the > patches. > > /Shrirang > > On Mon, 2018-05-28 at 18:34 +0530, Siva Rebbagondla wrote: > > On Mon, May 28, 2018 at 6:02 PM, Shrirang Bagul < > shrirang.bagul@canonical.com> wrote: > > On Mon, 2018-05-28 at 16:19 +0530, Siva Rebbagondla wrote: > > From: Sanjay Kumar Konduri <sanjay.konduri@redpinesignals.com> > > > > BugLink: https://bugs.launchpad.net/ubuntu/+source/linux/+bug/1773400 > > > > Observed third party station is unable to scan redpine AP, when Soft-AP > > restart command invoked. This is because power save is not disabled for > > rsi Soft-AP mode in rsi_mac80211_tx(). > > > > Signed-off-by: Sanjay Kumar Konduri <sanjay.konduri@redpinesignals.com> > > Signed-off-by: Siva Rebbagondla <siva.rebbagondla@redpinesignals.com> > When you have multiple patches addressing different bugs, it's advisable > to > include a cover letter with a short explanation. Otherwise, everything > looks > okay. > > Sure Shrirang. I will follow cover letter format, in case of multiple > patches submission. Thanks > > > > Acked-by: Shrirang Bagul <shrirang.bagul@canonical.com> > > --- > > v2: Changed the subject as per stable patch format [Shrirang]. > > --- > > ubuntu/rsi/rsi_91x_mac80211.c | 3 +-- > > 1 file changed, 1 insertion(+), 2 deletions(-) > > > > diff --git a/ubuntu/rsi/rsi_91x_mac80211.c > b/ubuntu/rsi/rsi_91x_mac80211.c > > index 129859a..244ef27 100644 > > --- a/ubuntu/rsi/rsi_91x_mac80211.c > > +++ b/ubuntu/rsi/rsi_91x_mac80211.c > > @@ -564,8 +564,7 @@ static void rsi_mac80211_tx(struct ieee80211_hw *hw, > > return; > > } > > if ((!bss->assoc) && > > - (adapter->ps_state == PS_ENABLED) && > > - (vif->type == NL80211_IFTYPE_STATION)) > > + (adapter->ps_state == PS_ENABLED)) > > rsi_disable_ps(adapter); > > if (ieee80211_is_auth(wlh->frame_control)) > > common->mac_ops_resumed = false; > > > > > <div dir="auto">OK Shrirang. <div dir="auto"><br></div><div dir="auto">Thanks</div></div><br><div class="gmail_quote"><div dir="ltr">On Thu 31 May, 2018, 9:32 AM Shrirang Bagul, <<a href="mailto:shrirang.bagul@canonical.com">shrirang.bagul@canonical.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div><div>Hi Siva,</div><div><br></div><div>Let's continue the discussion on the bug: <a href="https://bugs.launchpad.net/plano/+bug/1769225" target="_blank" rel="noreferrer">https://bugs.launchpad.net/plano/+bug/1769225</a> and not on the mailing list.</div><div>See my comment. <a href="https://bugs.launchpad.net/plano/+bug/1769225/comments/66" target="_blank" rel="noreferrer">https://bugs.launchpad.net/plano/+bug/1769225/comments/66</a></div><div><br></div><div>/Shrirang</div><div>On Thu, 2018-05-31 at 09:09 +0530, Siva Rebbagondla wrote:</div><blockquote type="cite" style="margin:0 0 0 .8ex;border-left:2px #729fcf solid;padding-left:1ex"><div dir="auto">Thanks for the update. <div dir="auto">And you are confirming that soft-ap is not fixed in ubuntu-xenial , after reboot. Is that correct?.</div><div dir="auto"><br></div><div dir="auto">Can you please share us the xenial os image which contain latest 2 patches?. This helps us to debug more deep into the issue.</div><div dir="auto"><br></div><div dir="auto">Best regards,</div><div dir="auto">Siva Rebbagondla</div></div><br><div class="gmail_quote"><div dir="ltr">On Thu 31 May, 2018, 9:03 AM Shrirang Bagul, <<a href="mailto:shrirang.bagul@canonical.com" target="_blank" rel="noreferrer">shrirang.bagul@canonical.com</a>> wrote:<br></div><blockquote type="cite" style="margin:0 0 0 .8ex;border-left:2px #729fcf solid;padding-left:1ex"><div><div>Hi Siva,</div><div><br></div><div>Well, the status has changed since my previous email on this thread.</div><div>Because, the test kernel built with these patches still doesn't fix the issue, I'm not sure if these patches should be merged at all.</div><div><br></div><div>/Shrirang</div><div><br></div><div>On Thu, 2018-05-31 at 08:35 +0530, Siva Rebbagondla wrote:</div><blockquote type="cite" style="margin:0 0 0 .8ex;border-left:2px #729fcf solid;padding-left:1ex"><div dir="ltr"><div class="gmail_default" style="color:rgb(7,55,99)">Hi Shrirang,<br><br></div><div class="gmail_default" style="color:rgb(7,55,99)">Just to cross check, As i able to see <span>acknowledgment for my </span>submitted patches in "<a href="https://lists.ubuntu.com/archives/kernel-team/2018-May/" rel="noreferrer noreferrer" target="_blank">https://lists.ubuntu.com/archives/kernel-team/2018-May/</a>".<br></div><div class="gmail_default" style="color:rgb(7,55,99)">Do i need to resend the patches one again?. Please confirm this.<br><br></div><div class="gmail_default" style="color:rgb(7,55,99)">Snippet from above URL, which shows ACK for submitted patches.<br></div><div class="gmail_default" style="color:rgb(7,55,99)"><br><a href="https://lists.ubuntu.com/archives/kernel-team/2018-May/092780.html" rel="noreferrer noreferrer" target="_blank">ACK/cmnt: [SRU Xenial][v2][PATCH 1/2] UBUNTU: SAUCE: Redpine: fix for Soft-AP restart issue </a><a name="m_1504673266723810644_m_-5328489051022161205_92780" rel="noreferrer noreferrer"> </a> <i>Shrirang Bagul </i> <ul><li><a href="https://lists.ubuntu.com/archives/kernel-team/2018-May/092808.html" rel="noreferrer noreferrer" target="_blank">ACK/cmnt: [SRU Xenial][v2][PATCH 1/2] UBUNTU: SAUCE: Redpine: fix for Soft-AP restart issue </a><a name="m_1504673266723810644_m_-5328489051022161205_92808" rel="noreferrer noreferrer"> </a> <i>Siva Rebbagondla</i><br></li></ul></div><div class="gmail_default" style="color:rgb(7,55,99)"><br></div><div class="gmail_default" style="color:rgb(7,55,99)">Thank you,<br></div><div class="gmail_default" style="color:rgb(7,55,99)">Siva Rebbagondla.<br></div></div><div class="gmail_extra"><br><div class="gmail_quote">On Tue, May 29, 2018 at 12:55 PM, Siva Rebbagondla <span dir="ltr"><<a href="mailto:siva8118@gmail.com" rel="noreferrer noreferrer" target="_blank">siva8118@gmail.com</a>></span> wrote:<br><blockquote type="cite" style="margin:0 0 0 .8ex;border-left:2px #729fcf solid;padding-left:1ex"><div dir="ltr"><div class="gmail_default" style="color:rgb(7,55,99)"><div class="gmail_default" style="color:rgb(7,55,99)">Hi Shrirang,<br><br></div><div class="gmail_default" style="color:rgb(7,55,99)">I just sent a subscription request to ubuntu kernel team.<br><br></div><div class="gmail_default" style="color:rgb(7,55,99)">Thanks,<br></div>Siva Rebbagondla</div></div><div class="m_1504673266723810644m_-5328489051022161205HOEnZb"><div class="m_1504673266723810644m_-5328489051022161205h5"><div class="gmail_extra"><br><div class="gmail_quote">On Tue, May 29, 2018 at 12:08 PM, Shrirang Bagul <span dir="ltr"><<a href="mailto:shrirang.bagul@canonical.com" rel="noreferrer noreferrer" target="_blank">shrirang.bagul@canonical.com</a>></span> wrote:<br><blockquote type="cite" style="margin:0 0 0 .8ex;border-left:2px #729fcf solid;padding-left:1ex"><div><div>Hi Siva,</div><div><br></div><div>Looks like the email address you are using to send patches was not registered in the <a style="white-space:nowrap" rel="noreferrer noreferrer"></a><a href="mailto:kernel-team@lists.ubuntu.com" rel="noreferrer noreferrer" target="_blank">kernel-team@lists.ubuntu.com</a> mailing list.</div><div>The patches submitted in this series are under moderation and won't get picked-up.</div><div><br></div><div>Please subscribe to the list by following the registration process here: <a href="https://lists.ubuntu.com/mailman/listinfo/kernel-team" rel="noreferrer noreferrer" target="_blank">https://lists.ubuntu.com/mailman/listinfo/kernel-team</a> and resend the patches.</div><span class="m_1504673266723810644m_-5328489051022161205m_2659347294044964468HOEnZb"><font color="#888888"><div><br></div><div>/Shrirang</div></font></span><div><div class="m_1504673266723810644m_-5328489051022161205m_2659347294044964468h5"><div><br></div><div>On Mon, 2018-05-28 at 18:34 +0530, Siva Rebbagondla wrote:</div><blockquote type="cite" style="margin:0 0 0 .8ex;border-left:2px #729fcf solid;padding-left:1ex"><div dir="ltr"><div class="gmail_extra"><div class="gmail_quote"><div style="color:rgb(7,55,99);display:inline" class="gmail_default"></div>On Mon, May 28, 2018 at 6:02 PM, Shrirang Bagul <span dir="ltr"><<a href="mailto:shrirang.bagul@canonical.com" rel="noreferrer noreferrer" target="_blank">shrirang.bagul@canonical.com</a>></span> wrote:<br><blockquote type="cite" style="margin:0 0 0 .8ex;border-left:2px #729fcf solid;padding-left:1ex">On Mon, 2018-05-28 at 16:19 +0530, Siva Rebbagondla wrote:<br> > From: Sanjay Kumar Konduri <<a href="mailto:sanjay.konduri@redpinesignals.com" rel="noreferrer noreferrer" target="_blank">sanjay.konduri@redpinesignals.com</a>><br> > <br> > BugLink: <a href="https://bugs.launchpad.net/ubuntu/+source/linux/+bug/1773400" rel="noreferrer noreferrer noreferrer" target="_blank">https://bugs.launchpad.net/ubuntu/+source/linux/+bug/1773400</a><br> > <br> > Observed third party station is unable to scan redpine AP, when Soft-AP<br> > restart command invoked. This is because power save is not disabled for<br> > rsi Soft-AP mode in rsi_mac80211_tx().<br> > <br> > Signed-off-by: Sanjay Kumar Konduri <<a href="mailto:sanjay.konduri@redpinesignals.com" rel="noreferrer noreferrer" target="_blank">sanjay.konduri@redpinesignals.com</a>><br> > Signed-off-by: Siva Rebbagondla <<a href="mailto:siva.rebbagondla@redpinesignals.com" rel="noreferrer noreferrer" target="_blank">siva.rebbagondla@redpinesignals.com</a>><br> When you have multiple patches addressing different bugs, it's advisable to <br> include a cover letter with a short explanation. Otherwise, everything looks<br> okay.<br></blockquote><div><div style="color:rgb(7,55,99);display:inline" class="gmail_default"> Sure Shrirang. I will follow cover letter format, in case of multiple patches submission. Thanks </div> </div><blockquote type="cite" style="margin:0 0 0 .8ex;border-left:2px #729fcf solid;padding-left:1ex"> <br> Acked-by: Shrirang Bagul <<a href="mailto:shrirang.bagul@canonical.com" rel="noreferrer noreferrer" target="_blank">shrirang.bagul@canonical.com</a>><br> > ---<br> > v2: Changed the subject as per stable patch format [Shrirang].<br> > ---<br> > ubuntu/rsi/rsi_91x_mac80211.c | 3 +--<br> > 1 file changed, 1 insertion(+), 2 deletions(-)<br> > <br> > diff --git a/ubuntu/rsi/rsi_91x_mac80211.c b/ubuntu/rsi/rsi_91x_mac80211.c<br> > index 129859a..244ef27 100644<br> > --- a/ubuntu/rsi/rsi_91x_mac80211.c<br> > +++ b/ubuntu/rsi/rsi_91x_mac80211.c<br> > @@ -564,8 +564,7 @@ static void rsi_mac80211_tx(struct ieee80211_hw *hw,<br> > return;<br> > }<br> > if ((!bss->assoc) &&<br> > - (adapter->ps_state == PS_ENABLED) &&<br> > - (vif->type == NL80211_IFTYPE_STATION))<br> > + (adapter->ps_state == PS_ENABLED))<br> > rsi_disable_ps(adapter);<br> > if (ieee80211_is_auth(wlh->frame_control))<br> > common->mac_ops_resumed = false;</blockquote></div><br></div></div> </blockquote></div></div></div></blockquote></div><br></div> </div></div></blockquote></div><br></div> </blockquote></div></blockquote></div> </blockquote></div></blockquote></div>
On 28.05.2018 03:49, Siva Rebbagondla wrote: > From: Sanjay Kumar Konduri <sanjay.konduri@redpinesignals.com> > > BugLink: https://bugs.launchpad.net/ubuntu/+source/linux/+bug/1773400 > > Observed third party station is unable to scan redpine AP, when Soft-AP > restart command invoked. This is because power save is not disabled for > rsi Soft-AP mode in rsi_mac80211_tx(). > > Signed-off-by: Sanjay Kumar Konduri <sanjay.konduri@redpinesignals.com> > Signed-off-by: Siva Rebbagondla <siva.rebbagondla@redpinesignals.com> > --- > v2: Changed the subject as per stable patch format [Shrirang]. > --- Based on the further replies it sounds like this patch set should not be considered for now. If things got resolved, please re-submit. Thanks, Stefan > ubuntu/rsi/rsi_91x_mac80211.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/ubuntu/rsi/rsi_91x_mac80211.c b/ubuntu/rsi/rsi_91x_mac80211.c > index 129859a..244ef27 100644 > --- a/ubuntu/rsi/rsi_91x_mac80211.c > +++ b/ubuntu/rsi/rsi_91x_mac80211.c > @@ -564,8 +564,7 @@ static void rsi_mac80211_tx(struct ieee80211_hw *hw, > return; > } > if ((!bss->assoc) && > - (adapter->ps_state == PS_ENABLED) && > - (vif->type == NL80211_IFTYPE_STATION)) > + (adapter->ps_state == PS_ENABLED)) > rsi_disable_ps(adapter); > if (ieee80211_is_auth(wlh->frame_control)) > common->mac_ops_resumed = false; >
diff --git a/ubuntu/rsi/rsi_91x_mac80211.c b/ubuntu/rsi/rsi_91x_mac80211.c index 129859a..244ef27 100644 --- a/ubuntu/rsi/rsi_91x_mac80211.c +++ b/ubuntu/rsi/rsi_91x_mac80211.c @@ -564,8 +564,7 @@ static void rsi_mac80211_tx(struct ieee80211_hw *hw, return; } if ((!bss->assoc) && - (adapter->ps_state == PS_ENABLED) && - (vif->type == NL80211_IFTYPE_STATION)) + (adapter->ps_state == PS_ENABLED)) rsi_disable_ps(adapter); if (ieee80211_is_auth(wlh->frame_control)) common->mac_ops_resumed = false;