| Message ID | 20180529020214.GA79563@ivb43 |
|---|---|
| State | Accepted |
| Delegated to: | Pablo Neira |
| Headers | show |
| Series | [RFC] netfilter: nft: nft_socket_type can be static | expand |
On Tue, May 29, 2018 at 10:02:14AM +0800, kbuild test robot wrote: > > Fixes: 809f719f9b3f ("netfilter: nft: add support for native socket matching") > Signed-off-by: kbuild test robot <fengguang.wu@intel.com> > --- > nft_socket.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/net/netfilter/nft_socket.c b/net/netfilter/nft_socket.c > index 5eb1069..3429a2e 100644 > --- a/net/netfilter/nft_socket.c > +++ b/net/netfilter/nft_socket.c > @@ -108,7 +108,7 @@ static int nft_socket_dump(struct sk_buff *skb, > return 0; > } > > -struct nft_expr_type nft_socket_type; > +static struct nft_expr_type nft_socket_type; @Máté: Same thing here, please collapse this small patch to you nft socket extension and send v2. Thanks! -- To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Wed, May 30, 2018 at 11:19:55AM +0200, Pablo Neira Ayuso wrote: > On Tue, May 29, 2018 at 10:02:14AM +0800, kbuild test robot wrote: > > > > Fixes: 809f719f9b3f ("netfilter: nft: add support for native socket matching") > > Signed-off-by: kbuild test robot <fengguang.wu@intel.com> > > --- > > nft_socket.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/net/netfilter/nft_socket.c b/net/netfilter/nft_socket.c > > index 5eb1069..3429a2e 100644 > > --- a/net/netfilter/nft_socket.c > > +++ b/net/netfilter/nft_socket.c > > @@ -108,7 +108,7 @@ static int nft_socket_dump(struct sk_buff *skb, > > return 0; > > } > > > > -struct nft_expr_type nft_socket_type; > > +static struct nft_expr_type nft_socket_type; > > @Máté: Same thing here, please collapse this small patch to you nft > socket extension and send v2. > > Thanks! This is not necessary. I built this patch on [1], it was just applied later than kbuild test ran. So [1] already fixes this. [1]: https://git.kernel.org/pub/scm/linux/kernel/git/pablo/nf-next.git/commit/?id=e5a10bb2acf246c13dc164fd37d4c77d9acaf88f -- To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Wed, May 30, 2018 at 12:06:47PM +0200, Máté Eckl wrote: > On Wed, May 30, 2018 at 11:19:55AM +0200, Pablo Neira Ayuso wrote: > > On Tue, May 29, 2018 at 10:02:14AM +0800, kbuild test robot wrote: > > > > > > Fixes: 809f719f9b3f ("netfilter: nft: add support for native socket matching") > > > Signed-off-by: kbuild test robot <fengguang.wu@intel.com> > > > --- > > > nft_socket.c | 2 +- > > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > > > diff --git a/net/netfilter/nft_socket.c b/net/netfilter/nft_socket.c > > > index 5eb1069..3429a2e 100644 > > > --- a/net/netfilter/nft_socket.c > > > +++ b/net/netfilter/nft_socket.c > > > @@ -108,7 +108,7 @@ static int nft_socket_dump(struct sk_buff *skb, > > > return 0; > > > } > > > > > > -struct nft_expr_type nft_socket_type; > > > +static struct nft_expr_type nft_socket_type; > > > > @Máté: Same thing here, please collapse this small patch to you nft > > socket extension and send v2. > > > > Thanks! > > This is not necessary. I built this patch on [1], it was just applied later than > kbuild test ran. > So [1] already fixes this. > > [1]: https://git.kernel.org/pub/scm/linux/kernel/git/pablo/nf-next.git/commit/?id=e5a10bb2acf246c13dc164fd37d4c77d9acaf88f Hm, I think you're getting confused by different kbuild report. This one refers to missing static in nft_socket_type :-). -- To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Wed, May 30, 2018 at 12:18:56PM +0200, Pablo Neira Ayuso wrote: > On Wed, May 30, 2018 at 12:06:47PM +0200, Máté Eckl wrote: > > On Wed, May 30, 2018 at 11:19:55AM +0200, Pablo Neira Ayuso wrote: > > > On Tue, May 29, 2018 at 10:02:14AM +0800, kbuild test robot wrote: > > > > > > > > Fixes: 809f719f9b3f ("netfilter: nft: add support for native socket matching") > > > > Signed-off-by: kbuild test robot <fengguang.wu@intel.com> > > > > --- > > > > nft_socket.c | 2 +- > > > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > > > > > diff --git a/net/netfilter/nft_socket.c b/net/netfilter/nft_socket.c > > > > index 5eb1069..3429a2e 100644 > > > > --- a/net/netfilter/nft_socket.c > > > > +++ b/net/netfilter/nft_socket.c > > > > @@ -108,7 +108,7 @@ static int nft_socket_dump(struct sk_buff *skb, > > > > return 0; > > > > } > > > > > > > > -struct nft_expr_type nft_socket_type; > > > > +static struct nft_expr_type nft_socket_type; > > > > > > @Máté: Same thing here, please collapse this small patch to you nft > > > socket extension and send v2. > > > > > > Thanks! > > > > This is not necessary. I built this patch on [1], it was just applied later than > > kbuild test ran. > > So [1] already fixes this. > > > > [1]: https://git.kernel.org/pub/scm/linux/kernel/git/pablo/nf-next.git/commit/?id=e5a10bb2acf246c13dc164fd37d4c77d9acaf88f > > Hm, I think you're getting confused by different kbuild report. > > This one refers to missing static in nft_socket_type > > :-). Indeend :) I'm on it. I suppose, it should also be static later when I define it. -- To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/net/netfilter/nft_socket.c b/net/netfilter/nft_socket.c index 5eb1069..3429a2e 100644 --- a/net/netfilter/nft_socket.c +++ b/net/netfilter/nft_socket.c @@ -108,7 +108,7 @@ static int nft_socket_dump(struct sk_buff *skb, return 0; } -struct nft_expr_type nft_socket_type; +static struct nft_expr_type nft_socket_type; static const struct nft_expr_ops nft_socket_ops = { .type = &nft_socket_type, .size = NFT_EXPR_SIZE(sizeof(struct nft_socket)),
Fixes: 809f719f9b3f ("netfilter: nft: add support for native socket matching") Signed-off-by: kbuild test robot <fengguang.wu@intel.com> --- nft_socket.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html