[2/2] board: amarula: a64-relic: Add WiFi support

Amarula A64-Relic board has AP6330 WiFi/BT combo, but does
not have ethernet port. So it makes sense to enable wireless
networking by default:
- add broadcom wireless firmware package to image
- add basic wireless tools to image
- add rootfs overlay with proper NVRAM file for on-board AP6330 chip
- add init script to load modules
- update readme.txt to test wifi

Signed-off-by: Jagan Teki <jagan@amarulasolutions.com>
---
 board/amarula/a64-relic/readme.txt                 |  9 +++
 .../rootfs_overlay/etc/init.d/S02-modload          | 12 ++++
 .../rootfs_overlay/etc/modules-load.d/modules.conf |  1 +
 .../lib/firmware/brcm/brcmfmac4330-sdio.txt        | 83 ++++++++++++++++++++++
 configs/amarula_a64_relic_defconfig                | 12 ++++
 5 files changed, 117 insertions(+)
 create mode 100755 board/amarula/a64-relic/rootfs_overlay/etc/init.d/S02-modload
 create mode 100644 board/amarula/a64-relic/rootfs_overlay/etc/modules-load.d/modules.conf
 create mode 100644 board/amarula/a64-relic/rootfs_overlay/lib/firmware/brcm/brcmfmac4330-sdio.txt

On 28-05-18 19:12, Jagan Teki wrote:
> Amarula A64-Relic board has AP6330 WiFi/BT combo, but does
> not have ethernet port. So it makes sense to enable wireless
> networking by default:
> - add broadcom wireless firmware package to image
> - add basic wireless tools to image
> - add rootfs overlay with proper NVRAM file for on-board AP6330 chip
> - add init script to load modules
> - update readme.txt to test wifi
> 
> Signed-off-by: Jagan Teki <jagan@amarulasolutions.com>
> ---
>  board/amarula/a64-relic/readme.txt                 |  9 +++
>  .../rootfs_overlay/etc/init.d/S02-modload          | 12 ++++
>  .../rootfs_overlay/etc/modules-load.d/modules.conf |  1 +
>  .../lib/firmware/brcm/brcmfmac4330-sdio.txt        | 83 ++++++++++++++++++++++
>  configs/amarula_a64_relic_defconfig                | 12 ++++
>  5 files changed, 117 insertions(+)
>  create mode 100755 board/amarula/a64-relic/rootfs_overlay/etc/init.d/S02-modload
>  create mode 100644 board/amarula/a64-relic/rootfs_overlay/etc/modules-load.d/modules.conf
>  create mode 100644 board/amarula/a64-relic/rootfs_overlay/lib/firmware/brcm/brcmfmac4330-sdio.txt
> 
> diff --git a/board/amarula/a64-relic/readme.txt b/board/amarula/a64-relic/readme.txt
> index 534ed32e7b..18824e1669 100644
> --- a/board/amarula/a64-relic/readme.txt
> +++ b/board/amarula/a64-relic/readme.txt
> @@ -57,4 +57,13 @@ GPT:
>    $ fastboot -i 0x1f3a flash esp boot.vfat
>    $ fastboot -i 0x1f3a flash system rootfs.ext2
>  
> +WiFi
> +====
> +

 Maybe add a little bit of text here. "To use the WiFi, you need to configure
your accesspoint first. Log in over the serial port, then type:"

> + # wpa_passphrase ACCESSPOINTNAME >> /etc/wpa_supplicant.conf
> +   (type password and enter)
> + # wpa_supplicant -i wlan0 -c /etc/wpa_supplicant.conf -B
> + # udhcpc -i wlan0

 Could we add the latter two to an init script instead? Should be S40 so it
coincides with S40network from ifupdown-scripts.

 So in the readme, these two lines would then be replaced with

# /etc/init.d/S40wlan start

> + # ping google.com
> +
>  Enjoy!
> diff --git a/board/amarula/a64-relic/rootfs_overlay/etc/init.d/S02-modload b/board/amarula/a64-relic/rootfs_overlay/etc/init.d/S02-modload
> new file mode 100755
> index 0000000000..81d85ce01c
> --- /dev/null
> +++ b/board/amarula/a64-relic/rootfs_overlay/etc/init.d/S02-modload
> @@ -0,0 +1,12 @@
> +#!/bin/sh
> +#
> +
> +load_modules()
> +{
> +	while IFS= read -r line; do
> +		modprobe -a $line
> +	done < "/etc/modules-load.d/modules.conf"
> +}
> +
> +load_modules
> +echo "Loading modules: OK"

 Init scripts should handle the start and stop arguments, otherwise the module
will be loaded again during shutdown.

 Also, I don't think it makes a lot of sense to introduce all this flexibility.
Just include 'modprobe -a brcmfmac' to S40wlan.

> diff --git a/board/amarula/a64-relic/rootfs_overlay/etc/modules-load.d/modules.conf b/board/amarula/a64-relic/rootfs_overlay/etc/modules-load.d/modules.conf
> new file mode 100644
> index 0000000000..a86ef4c668
> --- /dev/null
> +++ b/board/amarula/a64-relic/rootfs_overlay/etc/modules-load.d/modules.conf
> @@ -0,0 +1 @@
> +brcmfmac
> diff --git a/board/amarula/a64-relic/rootfs_overlay/lib/firmware/brcm/brcmfmac4330-sdio.txt b/board/amarula/a64-relic/rootfs_overlay/lib/firmware/brcm/brcmfmac4330-sdio.txt
> new file mode 100644
> index 0000000000..d095f24c26
> --- /dev/null
> +++ b/board/amarula/a64-relic/rootfs_overlay/lib/firmware/brcm/brcmfmac4330-sdio.txt
> @@ -0,0 +1,83 @@
> +#AP6330_NVRAM_V1.0_20121130
> +#Sample variables file for BCM94330 SD FC AGB board

 Arg, these horrible brcm config files...


 Regards,
 Arnout

[snip]

Hello,

On Wed, 30 May 2018 23:40:59 +0200, Arnout Vandecappelle wrote:

> > + # wpa_passphrase ACCESSPOINTNAME >> /etc/wpa_supplicant.conf
> > +   (type password and enter)
> > + # wpa_supplicant -i wlan0 -c /etc/wpa_supplicant.conf -B
> > + # udhcpc -i wlan0  
> 
>  Could we add the latter two to an init script instead? Should be S40 so it
> coincides with S40network from ifupdown-scripts.
> 
>  So in the readme, these two lines would then be replaced with
> 
> # /etc/init.d/S40wlan start

I'm not sure how that would work. You first need to enter the
passphrase for the WiFi chip to associate with the AP, and therefore
before doing the udhcp.

So when you suggest to replace the last two lines by
"/etc/init.d/S40wlan start", how is this going to work considering that
starting the S40wlan script has already been done at boot time ?

> > +load_modules()
> > +{
> > +	while IFS= read -r line; do
> > +		modprobe -a $line
> > +	done < "/etc/modules-load.d/modules.conf"
> > +}
> > +
> > +load_modules
> > +echo "Loading modules: OK"  
> 
>  Init scripts should handle the start and stop arguments, otherwise the module
> will be loaded again during shutdown.
> 
>  Also, I don't think it makes a lot of sense to introduce all this flexibility.
> Just include 'modprobe -a brcmfmac' to S40wlan.

Not directly related to Jagan's submission, but we do have this need to
load modules at startup for a number of platforms. Isn't it time to
have a generic init script that reads /etc/modules for this ? It's also
a question that has been asked a number of times on IRC: "how do I ask
my Buildroot system to load a kernel module at startup". Of course the
answer is simple: add an init script, but since the question has been
asked many times, perhaps it's worth adding some generic script ?

Or maybe in this case mdev support should be enabled to ensure modules
are loaded automatically ?

Best regards,

Thomas

On 31-05-18 08:57, Thomas Petazzoni wrote:
> Hello,
> 
> On Wed, 30 May 2018 23:40:59 +0200, Arnout Vandecappelle wrote:
> 
>>> + # wpa_passphrase ACCESSPOINTNAME >> /etc/wpa_supplicant.conf
>>> +   (type password and enter)
>>> + # wpa_supplicant -i wlan0 -c /etc/wpa_supplicant.conf -B
>>> + # udhcpc -i wlan0

 I notice now that it was just copied from warp7 :-)

>>
>>  Could we add the latter two to an init script instead? Should be S40 so it
>> coincides with S40network from ifupdown-scripts.
>>
>>  So in the readme, these two lines would then be replaced with
>>
>> # /etc/init.d/S40wlan start
> 
> I'm not sure how that would work. You first need to enter the
> passphrase for the WiFi chip to associate with the AP, and therefore
> before doing the udhcp.
> 
> So when you suggest to replace the last two lines by
> "/etc/init.d/S40wlan start", how is this going to work considering that
> starting the S40wlan script has already been done at boot time ?

 If no ssid/password is configured, wpa_supplicant will just not connect, it
will just run as daemon. Same for udhcpc, it will just retry until the interface
is up.

 But you're right: it should be restart instead of start, so that the running
wpa_supplicant and udhcpc are killed before restarting them.


>>> +load_modules()
>>> +{
>>> +	while IFS= read -r line; do
>>> +		modprobe -a $line
>>> +	done < "/etc/modules-load.d/modules.conf"
>>> +}
>>> +
>>> +load_modules
>>> +echo "Loading modules: OK"  
>>
>>  Init scripts should handle the start and stop arguments, otherwise the module
>> will be loaded again during shutdown.
>>
>>  Also, I don't think it makes a lot of sense to introduce all this flexibility.
>> Just include 'modprobe -a brcmfmac' to S40wlan.
> 
> Not directly related to Jagan's submission, but we do have this need to
> load modules at startup for a number of platforms. Isn't it time to
> have a generic init script that reads /etc/modules for this ? It's also
> a question that has been asked a number of times on IRC: "how do I ask
> my Buildroot system to load a kernel module at startup". Of course the
> answer is simple: add an init script, but since the question has been
> asked many times, perhaps it's worth adding some generic script ?

 Yes indeed. Perhaps a separate package like ifupdown-scripts. It should
probably depend on !UDEV.

 This could also be used for arcturus then.

> Or maybe in this case mdev support should be enabled to ensure modules
> are loaded automatically ?

 Probably, yes, since in most cases you need firmware as well. Actually, good
point: isn't mdev needed anyway to load the firmware? Oh, right, the kernel will
autoload since 4.something so all the defconfigs we have that add mdev "For
automatic firmware loading" are actually wrong...

 But yes, mdev is probably the easier way.

 Regards,
 Arnout