| Message ID | 67c3f567cd774cae8935873072c81e5ea62dc521.1527519997.git.petrm@mellanox.com |
|---|---|
| State | Changes Requested, archived |
| Delegated to: | David Miller |
| Headers | show |
| Series | net: bridge: Notify about bridge VLANs | expand |
On Mon, May 28, 2018 at 05:10:40PM +0200, Petr Machata wrote: > Ignore VLAN events where the orig_dev is the bridge device itself. > I don't know this code, and I have not looked at it either... But this changelog just says what you are doing and not why. Is this a bug fix? What are the user visible effects of this patch? Perhaps it is something which will be required in the future but has no effect now? You know how the New York Times is written for people with at least a 10th grade education? I feel like maybe if I knew this code I would know the answers to my question, but kernel commit descriptions should generally be written to Dan Carpenter level of education. Which is pretty darn ignorant... Can you please resend? regards, dan carpenter
diff --git a/drivers/net/ethernet/mellanox/mlxsw/spectrum_switchdev.c b/drivers/net/ethernet/mellanox/mlxsw/spectrum_switchdev.c index 8c9cf8e..cbc8fab 100644 --- a/drivers/net/ethernet/mellanox/mlxsw/spectrum_switchdev.c +++ b/drivers/net/ethernet/mellanox/mlxsw/spectrum_switchdev.c @@ -1144,6 +1144,9 @@ static int mlxsw_sp_port_vlans_add(struct mlxsw_sp_port *mlxsw_sp_port, struct mlxsw_sp_bridge_port *bridge_port; u16 vid; + if (netif_is_bridge_master(orig_dev)) + return -EOPNOTSUPP; + if (switchdev_trans_ph_prepare(trans)) return 0; @@ -1741,6 +1744,9 @@ static int mlxsw_sp_port_vlans_del(struct mlxsw_sp_port *mlxsw_sp_port, struct mlxsw_sp_bridge_port *bridge_port; u16 vid; + if (netif_is_bridge_master(orig_dev)) + return -EOPNOTSUPP; + bridge_port = mlxsw_sp_bridge_port_find(mlxsw_sp->bridge, orig_dev); if (WARN_ON(!bridge_port)) return -EINVAL;