diff mbox series

[U-Boot,38/41] log: include command header file

Message ID 20180528122526.20597-39-peng.fan@nxp.com
State Accepted
Commit aaa05deb1283b6beb7334adfa4094fb6bd4ab750
Delegated to: Stefano Babic
Headers show
Series imx: add i.MX8QXP support | expand

Commit Message

Peng Fan May 28, 2018, 12:25 p.m. UTC 
cmd_tbl_t is defined in command.h, so include it in log.h

Signed-off-by: Peng Fan <peng.fan@nxp.com>
Cc: Simon Glass <sjg@chromium.org>
---
 include/log.h | 1 +
 1 file changed, 1 insertion(+)

Comments

Simon Glass May 30, 2018, 7:18 p.m. UTC | #1 
On 28 May 2018 at 06:25, Peng Fan <peng.fan@nxp.com> wrote:
> cmd_tbl_t is defined in command.h, so include it in log.h
>
> Signed-off-by: Peng Fan <peng.fan@nxp.com>
> Cc: Simon Glass <sjg@chromium.org>
> ---
>  include/log.h | 1 +
>  1 file changed, 1 insertion(+)
>

Reviewed-by: Simon Glass <sjg@chromium.org>

Better I think to get rid of the cmd_tbl_t typedef and forward-declare
the struct in log.h
diff mbox series

Patch

diff --git a/include/log.h b/include/log.h
index a3edd25546..51cfd6fc0b 100644
--- a/include/log.h
+++ b/include/log.h
@@ -9,6 +9,7 @@ 
 #ifndef __LOG_H
 #define __LOG_H
 
+#include <command.h>
 #include <dm/uclass-id.h>
 #include <linux/list.h>