diff mbox series

[v2,1/2] package/nss-mdns: Fix hook from post-install to finalize

Message ID 1527496298-29730-1-git-send-email-vincent.prince.fr@gmail.com
State Superseded
Headers show
Series [v2,1/2] package/nss-mdns: Fix hook from post-install to finalize | expand

Commit Message

Vincent Prince May 28, 2018, 8:31 a.m. UTC 
Signed-off-by: Vincent Prince <vincent.prince.fr@gmail.com>
---
 package/nss-mdns/nss-mdns.mk | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Peter Korsgaard May 28, 2018, 12:41 p.m. UTC | #1 
>>>>> "Vincent" == Vincent Prince <vincent.prince.fr@gmail.com> writes:


Please describe _WHY_ this is done and not just state what the change is
you are making - Thanks.

> Signed-off-by: Vincent Prince <vincent.prince.fr@gmail.com>
 > ---
 >  package/nss-mdns/nss-mdns.mk | 2 +-
 >  1 file changed, 1 insertion(+), 1 deletion(-)

 > diff --git a/package/nss-mdns/nss-mdns.mk b/package/nss-mdns/nss-mdns.mk
 > index 407b942..ee666c7 100644
 > --- a/package/nss-mdns/nss-mdns.mk
 > +++ b/package/nss-mdns/nss-mdns.mk
 > @@ -17,6 +17,6 @@ define NSS_MDNS_INSTALL_CONFIG
 >  		$(TARGET_DIR)/etc/nsswitch.conf
 >  endef
 
 > -NSS_MDNS_POST_INSTALL_TARGET_HOOKS += NSS_MDNS_INSTALL_CONFIG
 > +NSS_MDNS_TARGET_FINALIZE_HOOKS += NSS_MDNS_INSTALL_CONFIG
 
 >  $(eval $(autotools-package))
 > -- 
 > 2.7.4

 > _______________________________________________
 > buildroot mailing list
 > buildroot@busybox.net
 > http://lists.busybox.net/mailman/listinfo/buildroot
Vincent Prince May 28, 2018, 7:08 p.m. UTC | #2 
I though it was obvious without explication :)

I'll send a V3 to explain the _why_.

2018-05-28 14:41 GMT+02:00 Peter Korsgaard <peter@korsgaard.com>:

> >>>>> "Vincent" == Vincent Prince <vincent.prince.fr@gmail.com> writes:
>
>
> Please describe _WHY_ this is done and not just state what the change is
> you are making - Thanks.
>
> > Signed-off-by: Vincent Prince <vincent.prince.fr@gmail.com>
>  > ---
>  >  package/nss-mdns/nss-mdns.mk | 2 +-
>  >  1 file changed, 1 insertion(+), 1 deletion(-)
>
>  > diff --git a/package/nss-mdns/nss-mdns.mk b/package/nss-mdns/
> nss-mdns.mk
>  > index 407b942..ee666c7 100644
>  > --- a/package/nss-mdns/nss-mdns.mk
>  > +++ b/package/nss-mdns/nss-mdns.mk
>  > @@ -17,6 +17,6 @@ define NSS_MDNS_INSTALL_CONFIG
>  >              $(TARGET_DIR)/etc/nsswitch.conf
>  >  endef
>
>  > -NSS_MDNS_POST_INSTALL_TARGET_HOOKS += NSS_MDNS_INSTALL_CONFIG
>  > +NSS_MDNS_TARGET_FINALIZE_HOOKS += NSS_MDNS_INSTALL_CONFIG
>
>  >  $(eval $(autotools-package))
>  > --
>  > 2.7.4
>
>  > _______________________________________________
>  > buildroot mailing list
>  > buildroot@busybox.net
>  > http://lists.busybox.net/mailman/listinfo/buildroot
>
> --
> Bye, Peter Korsgaard
>
<div dir="ltr">I though it was obvious without explication :) <div><br><div>I&#39;ll send a V3 to explain the _why_.</div></div></div><div class="gmail_extra"><br><div class="gmail_quote">2018-05-28 14:41 GMT+02:00 Peter Korsgaard <span dir="ltr">&lt;<a href="mailto:peter@korsgaard.com" target="_blank">peter@korsgaard.com</a>&gt;</span>:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">&gt;&gt;&gt;&gt;&gt; &quot;Vincent&quot; == Vincent Prince &lt;<a href="mailto:vincent.prince.fr@gmail.com">vincent.prince.fr@gmail.com</a>&gt; writes:<br>
<br>
<br>
Please describe _WHY_ this is done and not just state what the change is<br>
you are making - Thanks.<br>
<div><div class="h5"><br>
&gt; Signed-off-by: Vincent Prince &lt;<a href="mailto:vincent.prince.fr@gmail.com">vincent.prince.fr@gmail.com</a>&gt;<br>
 &gt; ---<br>
 &gt;  package/nss-mdns/<a href="http://nss-mdns.mk" rel="noreferrer" target="_blank">nss-mdns.mk</a> | 2 +-<br>
 &gt;  1 file changed, 1 insertion(+), 1 deletion(-)<br>
<br>
 &gt; diff --git a/package/nss-mdns/<a href="http://nss-mdns.mk" rel="noreferrer" target="_blank">nss-mdns.mk</a> b/package/nss-mdns/<a href="http://nss-mdns.mk" rel="noreferrer" target="_blank">nss-mdns.mk</a><br>
 &gt; index 407b942..ee666c7 100644<br>
 &gt; --- a/package/nss-mdns/<a href="http://nss-mdns.mk" rel="noreferrer" target="_blank">nss-mdns.mk</a><br>
 &gt; +++ b/package/nss-mdns/<a href="http://nss-mdns.mk" rel="noreferrer" target="_blank">nss-mdns.mk</a><br>
 &gt; @@ -17,6 +17,6 @@ define NSS_MDNS_INSTALL_CONFIG<br>
 &gt;              $(TARGET_DIR)/etc/nsswitch.<wbr>conf<br>
 &gt;  endef<br>
<br>
 &gt; -NSS_MDNS_POST_INSTALL_TARGET_<wbr>HOOKS += NSS_MDNS_INSTALL_CONFIG<br>
 &gt; +NSS_MDNS_TARGET_FINALIZE_<wbr>HOOKS += NSS_MDNS_INSTALL_CONFIG<br>
<br>
 &gt;  $(eval $(autotools-package))<br>
 &gt; -- <br>
 &gt; 2.7.4<br>
<br>
</div></div> &gt; ______________________________<wbr>_________________<br>
 &gt; buildroot mailing list<br>
 &gt; <a href="mailto:buildroot@busybox.net">buildroot@busybox.net</a><br>
 &gt; <a href="http://lists.busybox.net/mailman/listinfo/buildroot" rel="noreferrer" target="_blank">http://lists.busybox.net/<wbr>mailman/listinfo/buildroot</a><br>
<span class="HOEnZb"><font color="#888888"><br>
-- <br>
Bye, Peter Korsgaard<br>
</font></span></blockquote></div><br></div>
diff mbox series

Patch

diff --git a/package/nss-mdns/nss-mdns.mk b/package/nss-mdns/nss-mdns.mk
index 407b942..ee666c7 100644
--- a/package/nss-mdns/nss-mdns.mk
+++ b/package/nss-mdns/nss-mdns.mk
@@ -17,6 +17,6 @@  define NSS_MDNS_INSTALL_CONFIG
 		$(TARGET_DIR)/etc/nsswitch.conf
 endef
 
-NSS_MDNS_POST_INSTALL_TARGET_HOOKS += NSS_MDNS_INSTALL_CONFIG
+NSS_MDNS_TARGET_FINALIZE_HOOKS += NSS_MDNS_INSTALL_CONFIG
 
 $(eval $(autotools-package))