Patchwork [PATCHv4,3/3] serve_image: adjust classifier and type for printf

login
register
mail settings
Submitter Shevchenko Andriy (EXT-Teleca/Helsinki)
Date April 20, 2011, 9:35 a.m.
Message ID <015098d0d8cd7afd0df9d6f294896e585aa48a85.1303292025.git.ext-andriy.shevchenko@nokia.com>
Download mbox | patch
Permalink /patch/92121/
State Accepted
Commit 9f4e68401ab692a42825233342f7851edec7b8e7
Headers show

Comments

Shevchenko Andriy (EXT-Teleca/Helsinki) - April 20, 2011, 9:35 a.m.
The argument type of printf is __off64_t, meanwhile the classifier is "%ld".
We agreed to use PRIu64 in such case.

Signed-off-by: Andy Shevchenko <ext-andriy.shevchenko@nokia.com>
---
 serve_image.c |    7 ++++---
 1 files changed, 4 insertions(+), 3 deletions(-)

Patch

diff --git a/serve_image.c b/serve_image.c
index f8f28a1..d1037a9 100644
--- a/serve_image.c
+++ b/serve_image.c
@@ -2,7 +2,6 @@ 
 #define _POSIX_C_SOURCE 199309
 
 #include <time.h>
-
 #include <errno.h>  	
 #include <error.h> 	
 #include <netdb.h> 	
@@ -18,6 +17,8 @@ 
 #include <netinet/in.h>
 #include <sys/time.h>
 #include <crc32.h>
+#include <inttypes.h>
+
 #include "mcast_image.h"
 
 int tx_rate = 80000;
@@ -126,8 +127,8 @@  int main(int argc, char **argv)
 	}
 
 	if (st.st_size % erasesize) {
-		fprintf(stderr, "Image size %ld bytes is not a multiple of erasesize %d bytes\n",
-			st.st_size, erasesize);
+		fprintf(stderr, "Image size %" PRIu64 " bytes is not a multiple of erasesize %d bytes\n"
+				st.st_size, erasesize);
 		exit(1);
 	}
 	image = mmap(NULL, st.st_size, PROT_READ, MAP_PRIVATE, rfd, 0);