[4/4] net/macsec0{1, 2}.sh: Use TST_NET_SKIP_PARSE_ARGS=1
diff mbox series

Message ID 20180526111545.20521-4-pvorel@suse.cz
State Changes Requested
Delegated to: Alexey Kodanev
Headers show
Series
  • Untitled series #46815
Related show

Commit Message

Petr Vorel May 26, 2018, 11:15 a.m. UTC
These tests load ipsec_lib.sh and virt_lib.sh.
Currently tst_net.sh doesn't support being used by more libraries, so
when handling getopts the later one wins.
Disabling variables as they aren't used in the runtest file.

Signed-off-by: Petr Vorel <pvorel@suse.cz>
---
Alexey, do you use library variables for debugging?
Or would you prefer to be without this and to have at least one
libraries getopts?


Kind regards,
Petr
---
 testcases/network/virt/macsec01.sh | 1 +
 testcases/network/virt/macsec02.sh | 1 +
 2 files changed, 2 insertions(+)

Comments

Alexey Kodanev May 28, 2018, 2:03 p.m. UTC | #1
On 05/26/2018 02:15 PM, Petr Vorel wrote:
> These tests load ipsec_lib.sh and virt_lib.sh.
> Currently tst_net.sh doesn't support being used by more libraries, so
> when handling getopts the later one wins.
> Disabling variables as they aren't used in the runtest file.
> 
> Signed-off-by: Petr Vorel <pvorel@suse.cz>
> ---
> Alexey, do you use library variables for debugging?
> Or would you prefer to be without this and to have at least one
> libraries getopts?
> 


I'm for keeping the IPsec options in macsec test, some of them are not
explicitly defined in the test, therefore can be changed.

For virt_lib.sh library the better fix would be to define the options
only for vxlan/geneve tests, because only those tests are currently
using them.
Petr Vorel May 29, 2018, 8:08 a.m. UTC | #2
Hi Alexey,

> On 05/26/2018 02:15 PM, Petr Vorel wrote:
> > These tests load ipsec_lib.sh and virt_lib.sh.
> > Currently tst_net.sh doesn't support being used by more libraries, so
> > when handling getopts the later one wins.
> > Disabling variables as they aren't used in the runtest file.

> > Signed-off-by: Petr Vorel <pvorel@suse.cz>
> > ---
> > Alexey, do you use library variables for debugging?
> > Or would you prefer to be without this and to have at least one
> > libraries getopts?



> I'm for keeping the IPsec options in macsec test, some of them are not
> explicitly defined in the test, therefore can be changed.
OK, thanks for info.

> For virt_lib.sh library the better fix would be to define the options
> only for vxlan/geneve tests, because only those tests are currently
> using them.
Could you please make this change?


Kind regards,
Petr

Patch
diff mbox series

diff --git a/testcases/network/virt/macsec01.sh b/testcases/network/virt/macsec01.sh
index 52d6f071a..ddcd4b41c 100755
--- a/testcases/network/virt/macsec01.sh
+++ b/testcases/network/virt/macsec01.sh
@@ -24,6 +24,7 @@  TST_NEEDS_TMPDIR=1
 
 virt_type="macsec"
 VIRT_PERF_THRESHOLD=${VIRT_PERF_THRESHOLD:-100}
+TST_NET_SKIP_PARSE_ARGS=1
 
 . ipsec_lib.sh
 . virt_lib.sh
diff --git a/testcases/network/virt/macsec02.sh b/testcases/network/virt/macsec02.sh
index 617860d41..215973bee 100755
--- a/testcases/network/virt/macsec02.sh
+++ b/testcases/network/virt/macsec02.sh
@@ -24,6 +24,7 @@  TST_NEEDS_TMPDIR=1
 
 virt_type="macsec"
 VIRT_PERF_THRESHOLD=${VIRT_PERF_THRESHOLD:-100}
+TST_NET_SKIP_PARSE_ARGS=1
 
 . ipsec_lib.sh
 . virt_lib.sh