| Message ID | 20180525174952.21965-1-brnkv.i1@gmail.com |
|---|---|
| State | Accepted, archived |
| Delegated to: | David Miller |
| Headers | show |
| Series | atm: zatm: fix memcmp casting | expand |
From: Ivan Bornyakov <brnkv.i1@gmail.com> Date: Fri, 25 May 2018 20:49:52 +0300 > memcmp() returns int, but eprom_try_esi() cast it to unsigned char. One > can lose significant bits and get 0 from non-0 value returned by the > memcmp(). > > Signed-off-by: Ivan Bornyakov <brnkv.i1@gmail.com> Applied, thanks.
diff --git a/drivers/atm/zatm.c b/drivers/atm/zatm.c index 9c9a22958717..a8d2eb0ceb8d 100644 --- a/drivers/atm/zatm.c +++ b/drivers/atm/zatm.c @@ -1151,8 +1151,8 @@ static void eprom_get_byte(struct zatm_dev *zatm_dev, unsigned char *byte, } -static unsigned char eprom_try_esi(struct atm_dev *dev, unsigned short cmd, - int offset, int swap) +static int eprom_try_esi(struct atm_dev *dev, unsigned short cmd, int offset, + int swap) { unsigned char buf[ZEPROM_SIZE]; struct zatm_dev *zatm_dev;
memcmp() returns int, but eprom_try_esi() cast it to unsigned char. One can lose significant bits and get 0 from non-0 value returned by the memcmp(). Signed-off-by: Ivan Bornyakov <brnkv.i1@gmail.com> --- drivers/atm/zatm.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)